From: Jakob Koschel <jakobkoschel@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Naveen Naidu <naveennaidu479@gmail.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Rapoport <rppt@kernel.org>,
"Brian Johannesmeyer" <bjohannesmeyer@gmail.com>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>,
Jakob Koschel <jakobkoschel@gmail.com>
Subject: [PATCH] PCI/PME: replace usage of found with dedicated list iterator variable
Date: Thu, 24 Mar 2022 08:18:52 +0100 [thread overview]
Message-ID: <20220324071852.61587-1-jakobkoschel@gmail.com> (raw)
To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.
To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].
This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.
Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
---
drivers/pci/pcie/pme.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
index ef8ce436ead9..dc8cbf8987ba 100644
--- a/drivers/pci/pcie/pme.c
+++ b/drivers/pci/pcie/pme.c
@@ -130,7 +130,7 @@ static void pcie_pme_handle_request(struct pci_dev *port, u16 req_id)
{
u8 busnr = req_id >> 8, devfn = req_id & 0xff;
struct pci_bus *bus;
- struct pci_dev *dev;
+ struct pci_dev *dev = NULL, *iter;
bool found = false;
/* First, check if the PME is from the root port itself. */
@@ -169,17 +169,17 @@ static void pcie_pme_handle_request(struct pci_dev *port, u16 req_id)
/* Finally, try to find the PME source on the bus. */
down_read(&pci_bus_sem);
- list_for_each_entry(dev, &bus->devices, bus_list) {
- pci_dev_get(dev);
- if (dev->devfn == devfn) {
- found = true;
+ list_for_each_entry(iter, &bus->devices, bus_list) {
+ pci_dev_get(iter);
+ if (iter->devfn == devfn) {
+ dev = iter;
break;
}
- pci_dev_put(dev);
+ pci_dev_put(iter);
}
up_read(&pci_bus_sem);
- if (found) {
+ if (dev) {
/* The device is there, but we have to check its PME status. */
found = pci_check_pme_status(dev);
if (found) {
base-commit: f443e374ae131c168a065ea1748feac6b2e76613
--
2.25.1
reply other threads:[~2022-03-24 7:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324071852.61587-1-jakobkoschel@gmail.com \
--to=jakobkoschel@gmail.com \
--cc=bhelgaas@google.com \
--cc=bjohannesmeyer@gmail.com \
--cc=c.giuffrida@vu.nl \
--cc=h.j.bos@vu.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=naveennaidu479@gmail.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).