From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54D69C433FE for ; Thu, 24 Mar 2022 14:08:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346127AbiCXOJr (ORCPT ); Thu, 24 Mar 2022 10:09:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346005AbiCXOJq (ORCPT ); Thu, 24 Mar 2022 10:09:46 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC829517CD for ; Thu, 24 Mar 2022 07:08:12 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id u22so4060455pfg.6 for ; Thu, 24 Mar 2022 07:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=93vcdK/xA2d3gDff/dGSRlMj0tuRWV7ZnM79a900KCA=; b=aKaURfUNMFCp6cu9fJB91q5Ui3Eo6etz7SRrY9zGxm61qngeQOZmhkjrmT9E08wCiP vlm6/uY+83hWF+qhqvwbK6BqcreN583/zJ97ICfUcI3l4BG4wXLKnjKvo4fSVDFGZROB MCf7Ag+aX8rBBRnWCP/iGbVGxbIokTttCitk+QCZR22MoiwpLwCHdA6hwwakhmWgBGcL DBTkl2W3ovnPdYqppO1XKXM+PsJcnfDQhpZ4Cd03sfiuB/09t3PqXR1DG/mYP49NV5QO 9Q7tGP/aNrO1s2nd/VHZCl3l3e714ZbNNQ+fQ9LLT6tmVruzZI0/u/0a3SQCqvcY9rW3 5RIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=93vcdK/xA2d3gDff/dGSRlMj0tuRWV7ZnM79a900KCA=; b=Av1BR032pgthVtqkRiX/fY7rcWyeO8YTN3ZGWGSqVjN6DdAyDyyZ7MGKYwtVv/N7yb 69OoBRfkY7Bx+Zyw/a2vG0CSl8KTsqmU0Mwqw8KiAZ51z/jFx57zYUUrI+GEMMjT7/NY Ix/ObMLJuW8Djwzf341sGxmAdTM325NbhxnA/0e2V0eHlD9aRokfBwgmkpTDZWc6dxTJ lJPPfC6p7plRUaraMIaoiidEfaB9c0rOvSEqoVSjUNP1+B38oLJ3zfZ5Hj8nNxZeNLEz XU9/N0qfNx6FPVGonhJtStU1JkvSzT+ixby2IasS01sSUcKlhDCcTxpXTrxs8NVYYuOg UC6w== X-Gm-Message-State: AOAM531BE4i/VHvuaUM2HQvhHQF/6VEaobUs1UeugUchBgrP4y+OY0tW qevRmFjOt9dpuV7bX23kXPES X-Google-Smtp-Source: ABdhPJxjNH1ojTh0rmiF8uZ2gnlb/AVtEx8oYA2jDrVBOdB0Sis3oEqfp6h9EDbm/e0f3OM2YGJMKA== X-Received: by 2002:a63:2003:0:b0:381:2dd3:ab4b with SMTP id g3-20020a632003000000b003812dd3ab4bmr4304586pgg.517.1648130892419; Thu, 24 Mar 2022 07:08:12 -0700 (PDT) Received: from thinkpad ([220.158.158.107]) by smtp.gmail.com with ESMTPSA id k6-20020a056a00134600b004faba67f9d4sm3864954pfu.197.2022.03.24.07.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 07:08:11 -0700 (PDT) Date: Thu, 24 Mar 2022 19:38:06 +0530 From: Manivannan Sadhasivam To: Serge Semin Cc: Gustavo Pimentel , Vinod Koul , Jingoo Han , Bjorn Helgaas , Frank Li , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/25] dmaengine: Fix dma_slave_config.dst_addr description Message-ID: <20220324140806.GN2854@thinkpad> References: <20220324014836.19149-1-Sergey.Semin@baikalelectronics.ru> <20220324014836.19149-5-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324014836.19149-5-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Mar 24, 2022 at 04:48:15AM +0300, Serge Semin wrote: > Most likely due to a copy-paste mistake the dst_addr member of the > dma_slave_config structure has been marked as ignored if the !source! > address belong to the memory. That is relevant to the src_addr field of > the structure while the dst_addr field as containing a destination device > address is supposed to be ignored if the destination is the CPU memory. > Let's fix the field description accordingly. > > Signed-off-by: Serge Semin Reviewed-by: Manivannan Sadhasivam One suggestion below. > --- > include/linux/dmaengine.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index 842d4f7ca752..f204ea16ac1c 100644 > --- a/include/linux/dmaengine.h > +++ b/include/linux/dmaengine.h > @@ -395,7 +395,7 @@ enum dma_slave_buswidth { > * should be read (RX), if the source is memory this argument is > * ignored. > * @dst_addr: this is the physical address where DMA slave data > - * should be written (TX), if the source is memory this argument > + * should be written (TX), if the destination is memory this argument Should we rename "memory" to "local memory" or something similar? Thanks, Mani > * is ignored. > * @src_addr_width: this is the width in bytes of the source (RX) > * register where DMA data shall be read. If the source > -- > 2.35.1 >