Re: [PATCH 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy

From: 이왕석 <wangseok.lee@samsung.com>
To: Rob Herring <robh@kernel.org>
Cc: "kernel@axis.com" <kernel@axis.com>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"kw@linux.com" <kw@linux.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	전문기 <moonki.jun@samsung.com>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"jesper.nilsson@axis.com" <jesper.nilsson@axis.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kishon@ti.com" <kishon@ti.com>,
	"lars.persson@axis.com" <lars.persson@axis.com>
Subject: Re: [PATCH 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy
Date: Tue, 29 Mar 2022 14:20:49 +0900	[thread overview]
Message-ID: <20220329052049epcms2p623bd47de38aba8a43689e515bc712ede@epcms2p6> (raw)
In-Reply-To: <1648471865.787623.2153571.nullmailer@robh.at.kernel.org>

> --------- Original Message ---------
> Sender : Rob Herring <robh@kernel.org>
> Date : 2022-03-28 21:51 (GMT+9)
> Title : Re: [PATCH 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy
> 
> On Mon, 28 Mar 2022 17:43:19 +0900, �댁���� wrote:
>> Add description to support Axis, ARTPEC-8 SoC.
>> ARTPEC-8 is the SoC platform of Axis Communications
>> and PCIe phy is designed based on SAMSUNG PHY.
>> 
>> Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com>
>> ---
>>  .../bindings/phy/axis,artpec8-pcie-phy.yaml        | 67 ++++++++++++++++++++++
>>  1 file changed, 67 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml
>> 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.example.dt.yaml:0:0: /example-0/artec8/pcie-phy@16c80000: failed to match any schema with compatible: ['samsung,artpec8-pcie-phy']
> 
> doc reference errors (make refcheckdocs):
> 
> See https://protect2.fireeye.com/v1/url?k=0fdd5edc-6f3fc381-0fdcd593-000babd9f1ba-cd731013fdd72389&q=1&e=df20f229-606a-4e6a-bcb2-2cbdc399248e&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F1610068
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.

Hello Rob Herring
Thanks for your review.

I wrote the wrong "compatible" value.
so i will modify this part and summit it again.
also i checked the result by performing 
"make dt_binding_check DT_SCHEMA_FILES=
Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml".

Thanks.