From: Bjorn Helgaas <helgaas@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Rob Herring <robh@kernel.org>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: pci: layerscape-pci: Add a optional property big-endian
Date: Thu, 14 Apr 2022 14:27:30 -0500 [thread overview]
Message-ID: <20220414192730.GA763552@bhelgaas> (raw)
In-Reply-To: <20220311234938.8706-2-leoyang.li@nxp.com>
On Fri, Mar 11, 2022 at 05:49:35PM -0600, Li Yang wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> This property is to indicate the endianness when accessing the
> PEX_LUT and PF register block, so if these registers are
> implemented in big-endian, specify this property.
>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/pci/layerscape-pci.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> index f36efa73a470..215d2ee65c83 100644
> --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> @@ -40,6 +40,10 @@ Required properties:
> of the data transferred from/to the IP block. This can avoid the software
> cache flush/invalid actions, and improve the performance significantly.
>
> +Optional properties:
> +- big-endian: If the PEX_LUT and PF register block is in big-endian, specify
> + this property.
What's the purpose of this? I don't see any code that uses this
property.
I guess this might be related to of_device_is_big_endian()? I do see
some code that uses of_device_is_big_endian(), but nothing that looks
relevant to layerscape in particular.
> Example:
>
> pcie@3400000 {
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-04-14 19:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 23:49 [PATCH v3 0/4] layerscape-pci binding updates Li Yang
2022-03-11 23:49 ` [PATCH v3 1/4] dt-bindings: pci: layerscape-pci: Add a optional property big-endian Li Yang
2022-04-14 19:27 ` Bjorn Helgaas [this message]
2022-04-14 20:03 ` Leo Li
2022-03-11 23:49 ` [PATCH v3 2/4] dt-bindings: pci: layerscape-pci: Update the description of SCFG property Li Yang
2022-03-11 23:49 ` [PATCH v3 3/4] dt-bindings: pci: layerscape-pci: Add EP mode compatible strings for ls1028a Li Yang
2022-03-11 23:49 ` [PATCH v3 4/4] dt-bindings: pci: layerscape-pci: define AER/PME interrupts Li Yang
2022-04-14 19:40 ` Bjorn Helgaas
2022-04-14 20:10 ` Leo Li
2022-04-08 11:36 ` [PATCH v3 0/4] layerscape-pci binding updates Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414192730.GA763552@bhelgaas \
--to=helgaas@kernel.org \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).