Re: [PATCH 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver

From: Wangseok Lee <wangseok.lee@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	robh+dt <robh+dt@kernel.org>, krzk+dt <krzk+dt@kernel.org>,
	kishon <kishon@ti.com>, vkoul <vkoul@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"jesper.nilsson" <jesper.nilsson@axis.com>,
	"lars.persson" <lars.persson@axis.com>
Cc: bhelgaas <bhelgaas@google.com>,
	linux-phy <linux-phy@lists.infradead.org>,
	linux-pci <linux-pci@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	"lorenzo.pieralisi" <lorenzo.pieralisi@arm.com>,
	kw <kw@linux.com>, linux-arm-kernel <linux-arm-kernel@axis.com>,
	kernel <kernel@axis.com>, Moon-Ki Jun <moonki.jun@samsung.com>,
	Dongjin Yang <dj76.yang@samsung.com>
Subject: Re: [PATCH 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver
Date: Tue, 19 Apr 2022 09:07:30 +0900	[thread overview]
Message-ID: <20220419000730epcms2p77c94d5e55db13ebf2f88b25d16b6ef7a@epcms2p7> (raw)
In-Reply-To: CGME20220419000730epcms2p77c94d5e55db13ebf2f88b25d16b6ef7a@epcms2p7

> On 28/03/2022 04:14, 이왕석 wrote:
>> Add support Axis, ARTPEC-8 SoC.
>> ARTPEC-8 is the SoC platform of Axis Communications.
>> This is based on arm64 and support GEN4 & 2lane.
>> This PCIe controller is based on DesignWare Hardware core
>> and uses DesignWare core functions to implement the driver.
>> This is based on driver/pci/controller/dwc/pci-exynos.c
>> 
>> Signed-off-by: Wangseok Lee 
>> ---
>>  drivers/pci/controller/dwc/Kconfig        |  31 +
>>  drivers/pci/controller/dwc/Makefile       |   1 +
>>  drivers/pci/controller/dwc/pcie-artpec8.c | 912 ++++++++++++++++++++++++++++++
>>  3 files changed, 944 insertions(+)
>>  create mode 100644 drivers/pci/controller/dwc/pcie-artpec8.c
>> 
> 
> I took a look at the your driver and at existing PCIe Exynos driver.
> Unfortunately PCIe Exynos driver is in poor shape, really poor. This
> would explain that maybe it's better to have new driver instead of
> merging them, especially that hardware is different. Although I am still
> waiting for some description of these differences...
> 
> I said that Exynos PCIe looks poor... but what is worse, it looks like
> you based on it so you copied or some bad patterns it had.
> 
> Except this the driver has several coding style issues, so please be
> sure to run checkpatch, sparse and smatch before sending it.
> 
> Please work on this driver to make it close to Linux coding style, so
> there will be no need for us, reviewers, focus on basic stuff.
> 
> Optionally, send all this to staging. :)
> 
> Best regards,
> Krzysztof
Hi,

Thank you for your kindness review.
I will re-work again close to the linux coding style.
Addiltionaly, If you tell me what "bad patterns" you mentioned,
it will be very helpful for the work.
Could you please tell me that?

Thank you.