From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAEFAC433EF for ; Tue, 26 Apr 2022 16:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352802AbiDZQHa (ORCPT ); Tue, 26 Apr 2022 12:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352798AbiDZQHU (ORCPT ); Tue, 26 Apr 2022 12:07:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACD5243EC1; Tue, 26 Apr 2022 09:04:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 436D061A59; Tue, 26 Apr 2022 16:04:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A7CCC385AA; Tue, 26 Apr 2022 16:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650989051; bh=DF6HiaHX+dY5oLx+lPOr2QI/LdmMgjcLKt3ZE8J8gK8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=fUz4dsSHHsZ0RthaQqqNVleFK3yj7u6ZWZ3AqxjSzYd816B8v5+wSSrUlbJhbQPxI 2EEb+sLh/UV0OfQxxkG/by3e08H39Z/H0OtgKBsYiEz6tkjRb2PAFpSYbUpWSRe7KA JufQJb17P6X/yy0AyPKoNLs+yGdUns/bEH9USJGBTMejgYFh/jRoEaRiI8+AQMoT2Q VYQaIYj+rIqNuf2JVNoZvg/wKfz8LJ0yIr9q3R6MfilJysBWIHdYYBGuk8JaZfTQg/ gY9v9s6a0774Gr953EHhaOe6amXWYY43lNAm1Kg8Aq3PDuVB5b/n9+mJjCrBoJiwdH j1/oGcEXQmUhA== Date: Tue, 26 Apr 2022 11:04:09 -0500 From: Bjorn Helgaas To: Frank Wunderlich Cc: linux-rockchip@lists.infradead.org, Frank Wunderlich , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Kishon Vijay Abraham I , Vinod Koul , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Philipp Zabel , Johan Jonker , Peter Geis , Michael Riesch , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [RFC/RFT v2 09/11] dt-bindings: pci: add lane-map to rockchip PCIe binding Message-ID: <20220426160409.GA1731042@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220426132139.26761-10-linux@fw-web.de> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Apr 26, 2022 at 03:21:37PM +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > Create new property for (rockchip) PCIe controller binding to > define lane mapping. > > Rockchip driver uses this for bifurcation (true/false) based > on lanes should be splitted across controllers or not. > > On rk3568 there are 2 PCIe Controllers which share 2 PCIe lanes. > > pcie3x1: pcie@fe270000 //lane1 when using 1+1 > pcie3x2: pcie@fe280000 //lane0 when using 1+1 > > This ends up in one Controller (pcie3x1) uses lane-map = <0 1>; and > the other lane-map = <1 0>; (pcie3x2) > > This means there are 2 lanes (count of numbers), one (by position) > is mapped to the first controller, the other one is used on the other > controller. > > In rockchip PCIe driver the lane-map is simply converted to the > bifurcation bool instead of direct mapping a specific lane to a > controller. > > There is not yet any slot mapping below one controller. > But for binding this may be possible like: > > lane-map = <1 2 3 3 4 4 4 4>; > | | | ... > lane0 | | > lane1 | > lane2 > > on a 8-lane phy. > > This can map lane0 to port1 (number used at this position), > lane1 to port2, lanes 2+3 to port 3 and lanes 4,5,6,7 to port 4. > > Signed-off-by: Frank Wunderlich > --- > v2: > - new patch > --- > Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > index a992970e8b85..998b20b3a9dc 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > @@ -52,6 +52,8 @@ properties: > - const: pclk > - const: aux > > + lane-map: true > + > msi-map: true > > num-lanes: true > @@ -74,8 +76,6 @@ properties: > reset-names: > const: pipe > > - bifurcation: true > - Why are you adding "bifurcation" earlier in the series, then immediately removing it? Why not just add "lane-map" directly and never mention "bifurcation" in the DT at all? > vpcie3v3-supply: true > > required: > @@ -115,6 +115,7 @@ examples: > "aclk_dbi", "pclk", > "aux"; > device_type = "pci"; > + lane-map = <0 1>; > linux,pci-domain = <2>; > max-link-speed = <2>; > msi-map = <0x2000 &its 0x2000 0x1000>; > -- > 2.25.1 > > > -- > linux-phy mailing list > linux-phy@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/linux-phy