From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12879C43217 for ; Wed, 27 Apr 2022 07:55:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359102AbiD0H6h (ORCPT ); Wed, 27 Apr 2022 03:58:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350735AbiD0H6f (ORCPT ); Wed, 27 Apr 2022 03:58:35 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F4453B023 for ; Wed, 27 Apr 2022 00:55:24 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d15so897586plh.2 for ; Wed, 27 Apr 2022 00:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fNHux1IBm/5HLefyE9ps8fak1p3KFESTuY/jt3ka9yU=; b=tSN2lkK/7BcMnlnxCd588MGTAMk8P9VpuIntdx/jrVnwngmDS5zBggXknGWi5gYqTJ G687yRsYUeUk7zhyYGgm22RBDjK129UdzPVt0Mf7GW6ACQAcXbAeSTc1D1WsHTMvjmtH +/yCG9IBKWEqT5xyk+YTp34azvWamK1lLUavDSfergvN0KQDZVTUHDQgJFfQsjA/Eziu K5BG89W+0uj6F+n7sIqpRLb2t07tZH3cO19Oe/QZUxuo8dFajUuxN5I37n1Nlvuk/Qrp oS0ixZUty499qGio0DVX0/5km4fMf9mP+eY6bgDXCqnWUNEIExm2C1xbJXbhS97WhxSz ZBmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fNHux1IBm/5HLefyE9ps8fak1p3KFESTuY/jt3ka9yU=; b=F5PJzdHpUx3l7w6Dc7EpJRb4vrTD4Lu7ZPPhLVB+kWL/ygVB51T+1to9QPc9k2NZ8t YgBTdnkCUzm0U0zng01BPuZm7vR+S2RJE5+lP/UyH8xVHWd6hnoW37lcln77F2FeMsVF iPrE9k6838agjIp6kEerosfyANz0XVaK/EFBeg7rvyR9jPj4NZKguSUGvVkZqa+8Oeg0 M2vC1UJMkZ3CXsb9aUP6GOQ81LJ5/ejGUj8oiwokbUnBv3GN927GKm58Vx3WvYfHXgFU DcXmAJr5i4DXWG+2prTOpAE/DV6EMagwQv2imeCLq71x9YZOYQZweFtgpdu5ruwytrBa c2tg== X-Gm-Message-State: AOAM530mafbeDB0w7M/62UziURSXFpMY8nbIdU50fV5krKiaGzVSDDEN ej/JbGdZKoDXjLDfDqO4LYaI X-Google-Smtp-Source: ABdhPJy+dOT8tPKckt8Xy6LcaOJl1PSgWgXOrviXgmnw02makXUuKn/BDlPXt0wCkZmeJqEWPFRriw== X-Received: by 2002:a17:90a:7acb:b0:1d9:85a5:e1e3 with SMTP id b11-20020a17090a7acb00b001d985a5e1e3mr13841507pjl.172.1651046123549; Wed, 27 Apr 2022 00:55:23 -0700 (PDT) Received: from thinkpad ([117.207.26.174]) by smtp.gmail.com with ESMTPSA id u3-20020a626003000000b00505a38fc90bsm18447482pfb.173.2022.04.27.00.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 00:55:23 -0700 (PDT) Date: Wed, 27 Apr 2022 13:25:16 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Lorenzo Pieralisi , Stanimir Varbanov , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Dmitry Baryshkov , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] PCI: qcom: Fix unbalanced PHY init on probe errors Message-ID: <20220427075516.GB2182@thinkpad> References: <20220401133854.10421-1-johan+linaro@kernel.org> <20220401133854.10421-3-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220401133854.10421-3-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Apr 01, 2022 at 03:38:54PM +0200, Johan Hovold wrote: > Make sure to undo the PHY initialisation (e.g. balance runtime PM) in > case host initialisation fails during probe. > > Fixes: 82a823833f4e ("PCI: qcom: Add Qualcomm PCIe controller driver") > Cc: stable@vger.kernel.org # 4.5 > Cc: Stanimir Varbanov > Signed-off-by: Johan Hovold Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 0b0bd71f1bd2..df47986bda29 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1624,11 +1624,13 @@ static int qcom_pcie_probe(struct platform_device *pdev) > ret = dw_pcie_host_init(pp); > if (ret) { > dev_err(dev, "cannot initialize host\n"); > - goto err_pm_runtime_put; > + goto err_phy_exit; > } > > return 0; > > +err_phy_exit: > + phy_exit(pcie->phy); > err_pm_runtime_put: > pm_runtime_put(dev); > pm_runtime_disable(dev); > -- > 2.35.1 >