From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E02E6C433FE for ; Tue, 3 May 2022 23:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244288AbiECXll (ORCPT ); Tue, 3 May 2022 19:41:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234374AbiECXlk (ORCPT ); Tue, 3 May 2022 19:41:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2D0E42EC0; Tue, 3 May 2022 16:38:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D7EC617EB; Tue, 3 May 2022 23:38:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A049EC385A4; Tue, 3 May 2022 23:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651621085; bh=TddFjYfs0IlmmoRmRJhIId5AulGG33VI0BNiobU2CvQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=lEN+VqFrouY3qh8AlZeGsjaIYP0MaQQQlhpXsVSepSP9KdbbBSuXXKMiHLEGcG9YZ kiZVWt1yUF8om4fV1V8DpcIuYczrnTa/4b9S4l4qMfx98ZdlWVXUqC6Md/EEiGLSJY KmL5Ho4NK6WdEIEFfRJiIl3SDFAzZC0xxXGbt8FVF3D878jtS1HJvdkr9mIHxvzsiO Gbcpz/nIeL/ouVLq+qNZZfmm9k/mgKWcedPUj+SqRF/VWCcngli20fhii3vDanQdh+ iJ3Gfe6PQzcXpbh6gCpOYr8U+0Xlwh/BOSR0C+nOsyPy5wsLVcd7sem18wia46moP9 dB5xoO03WTSFQ== Date: Tue, 3 May 2022 18:38:02 -0500 From: Bjorn Helgaas To: Niklas Schnelle Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Dominik Brodowski , Arnd Bergmann Subject: Re: [RFC v2 25/39] pcmcia: add HAS_IOPORT dependencies Message-ID: <20220503233802.GA420374@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220429135108.2781579-44-schnelle@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Apr 29, 2022 at 03:50:41PM +0200, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. PCMCIA devices are either LEGACY_PCI devices > which implies HAS_IOPORT or require HAS_IOPORT. > > Acked-by: Dominik Brodowski > Co-developed-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle > --- > drivers/pcmcia/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig > index 2ce261cfff8e..32b5cd324c58 100644 > --- a/drivers/pcmcia/Kconfig > +++ b/drivers/pcmcia/Kconfig > @@ -5,7 +5,7 @@ > > menuconfig PCCARD > tristate "PCCard (PCMCIA/CardBus) support" > - depends on !UML > + depends on HAS_IOPORT I don't know much about PC Card. Is there a requirement that these devices must use I/O port space? If so, can you include a spec reference in the commit log? I do see the PC Card spec, r8.1, sec 5.5.4.2.2 says: All CardBus PC Card adapters must support either memory-mapped I/O or both memory-mapped I/O and I/O space. The selection will depend largely on the system architecture the adapter is intended to be used in. The requirement to also support memory-mapped I/O, if I/O space is supported, is driven by the potential emergence of memory-mapped I/O only cards. Supporting both modes may also position the adapter to be sold into multiple system architectures. which sounds like I/O space is optional. > help > Say Y here if you want to attach PCMCIA- or PC-cards to your Linux > computer. These are credit-card size devices such as network cards, > -- > 2.32.0 >