From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v6 6/8] arm: dts: qcom: stop using snps,dw-pcie falback
Date: Fri, 6 May 2022 18:21:05 +0300 [thread overview]
Message-ID: <20220506152107.1527552-7-dmitry.baryshkov@linaro.org> (raw)
In-Reply-To: <20220506152107.1527552-1-dmitry.baryshkov@linaro.org>
Qualcomm PCIe devices are not really compatible with the snps,dw-pcie.
Unlike the generic IP core, they have special requirements regarding
enabling clocks, toggling resets, using the PHY, etc.
This is not to mention that platform snps-dw-pcie driver expects to find
two IRQs declared, while Qualcomm platforms use just one.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm/boot/dts/qcom-apq8064.dtsi | 2 +-
arch/arm/boot/dts/qcom-ipq4019.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
index a1c8ae516d21..ec2f98671a8c 100644
--- a/arch/arm/boot/dts/qcom-apq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
@@ -1370,7 +1370,7 @@ gfx3d1: iommu@7d00000 {
};
pcie: pci@1b500000 {
- compatible = "qcom,pcie-apq8064", "snps,dw-pcie";
+ compatible = "qcom,pcie-apq8064";
reg = <0x1b500000 0x1000>,
<0x1b502000 0x80>,
<0x1b600000 0x100>,
diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
index a9d0566a3190..1e814dbe135e 100644
--- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
@@ -412,7 +412,7 @@ restart@4ab000 {
};
pcie0: pci@40000000 {
- compatible = "qcom,pcie-ipq4019", "snps,dw-pcie";
+ compatible = "qcom,pcie-ipq4019";
reg = <0x40000000 0xf1d
0x40000f20 0xa8
0x80000 0x2000
--
2.35.1
next prev parent reply other threads:[~2022-05-06 15:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 15:20 [PATCH v6 0/8] dt-bindings: YAMLify pci/qcom,pcie schema Dmitry Baryshkov
2022-05-06 15:21 ` [PATCH v6 1/8] dt-bindings: PCI: qcom: Convert to YAML Dmitry Baryshkov
2022-05-10 16:26 ` Rob Herring
2022-05-06 15:21 ` [PATCH v6 2/8] dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms Dmitry Baryshkov
2022-05-10 16:46 ` Rob Herring
2022-05-06 15:21 ` [PATCH v6 3/8] dt-bindings: PCI: qcom: Specify reg-names explicitly Dmitry Baryshkov
2022-05-10 16:48 ` Rob Herring
2022-05-06 15:21 ` [PATCH v6 4/8] dt-bindings: PCI: qcom: Add schema for sc7280 chipset Dmitry Baryshkov
2022-05-10 16:50 ` Rob Herring
2022-05-06 15:21 ` [PATCH v6 5/8] arm64: dts: qcom: stop using snps,dw-pcie falback Dmitry Baryshkov
2022-05-06 15:21 ` Dmitry Baryshkov [this message]
2022-05-06 15:21 ` [PATCH v6 7/8] arm: dts: qcom-*: replace deprecated perst-gpio with perst-gpios Dmitry Baryshkov
2022-05-06 15:21 ` [PATCH v6 8/8] arm64: dts: qcom: " Dmitry Baryshkov
2022-05-10 16:50 ` [PATCH v6 0/8] dt-bindings: YAMLify pci/qcom,pcie schema Rob Herring
2022-05-11 10:13 ` Dmitry Baryshkov
2022-05-11 13:09 ` Lorenzo Pieralisi
2022-05-11 13:53 ` Dmitry Baryshkov
2022-05-11 14:00 ` Lorenzo Pieralisi
2022-05-11 14:09 ` Dmitry Baryshkov
2022-05-11 14:18 ` (subset) " Lorenzo Pieralisi
2022-08-29 23:45 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506152107.1527552-7-dmitry.baryshkov@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).