archive mirror
 help / color / mirror / Atom feed
From: Cyril Brulebois <>
To: Bjorn Helgaas <>
Cc: Thorsten Leemhuis <>,
	Jim Quinlan <>,
	"" <>,
	Linux PCI <>,
Subject: Re: [Bug 215925] New: PCIe regression on Raspberry Pi Compute Module 4 (CM4) breaks booting
Date: Mon, 9 May 2022 19:45:27 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20220509170708.GA604646@bhelgaas>

[-- Attachment #1: Type: text/plain, Size: 1679 bytes --]

Hi Bjorn,

Bjorn Helgaas <> (2022-05-09):
> Cyril, 830aa6f29f07 ("PCI: brcmstb: Split brcm_pcie_setup() into two
> funcs") reverts cleanly as of 57ae8a492116.  Does reverting it avoid
> the regression?

I didn't even try and revert this commit before you suggested doing so
since it was supposed to be some preliminary work. Quoting a part of
its commit message:

    In future commits the brcm_pcie_linkup() function will be called
    indirectly by pci_host_probe() as opposed to the host driver
    invoking it directly.

Anyway, the patch can indeed be reverted on top of v5.18-rc4 or
v5.18-rc6 but the build fails due to the former function being removed,
while being still called from other places:

      CC      drivers/pci/controller/pcie-brcmstb.o
    drivers/pci/controller/pcie-brcmstb.c:199:12: warning: ‘brcm_pcie_linkup’ used but never defined
      199 | static int brcm_pcie_linkup(struct brcm_pcie *pcie);
          |            ^~~~~~~~~~~~~~~~
    aarch64-linux-gnu-ld: drivers/pci/controller/pcie-brcmstb.o: in function `brcm_pcie_add_bus':
    /home/kibi/hack/linux.git/drivers/pci/controller/pcie-brcmstb.c:527: undefined reference to `brcm_pcie_linkup'

See for example:

    commit 93e41f3fca3d4a0f927b784012338c37f80a8a80
    Author: Jim Quinlan <>
    Date:   Thu Jan 6 11:03:29 2022 -0500
        PCI: brcmstb: Add control of subdevice voltage regulators

(And that one cannot be trivially reverted.)

Cyril Brulebois (            <>
D-I release manager -- Release team member -- Freelance Consultant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-05-09 18:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2022-05-02 18:38 ` [Bug 215925] New: PCIe regression on Raspberry Pi Compute Module 4 (CM4) breaks booting Bjorn Helgaas
2022-05-09  7:44   ` Thorsten Leemhuis
2022-05-09 17:07     ` Bjorn Helgaas
2022-05-09 17:45       ` Cyril Brulebois [this message]
2022-05-10 17:22         ` Bjorn Helgaas
2022-05-10 20:07           ` Cyril Brulebois
2022-05-10 20:55             ` Bjorn Helgaas
2022-05-16 21:05     ` Jim Quinlan
2022-05-18 19:47       ` Jim Quinlan
2022-05-20  5:48         ` Thorsten Leemhuis
2022-06-20  7:00     ` [Bug 215925] New: PCIe regression on Raspberry Pi Compute Module 4 (CM4) breaks booting #forregzbot Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).