Re: [PATCH v10 0/9] Enable designware PCI EP EDMA locally

[Serge Semin <fancer.lancer@gmail.com>]

Hello Lorenzo

On Tue, May 10, 2022 at 06:47:49PM +0100, Lorenzo Pieralisi wrote:
> On Wed, May 04, 2022 at 02:18:06AM +0300, Serge Semin wrote:
> > On Mon, May 02, 2022 at 07:57:52PM -0500, Frank Li wrote:
> > > Default Designware EDMA just probe remotely at host side.
> > > This patch allow EDMA driver can probe at EP side.
> > > 
> > > 1. Clean up patch
> > >    dmaengine: dw-edma: Detach the private data and chip info structures
> > >    dmaengine: dw-edma: Remove unused field irq in struct dw_edma_chip
> > >    dmaengine: dw-edma: Change rg_region to reg_base in struct
> > >    dmaengine: dw-edma: rename wr(rd)_ch_cnt to ll_wr(rd)_cnt in struct
> > > 
> > > 2. Enhance EDMA driver to allow prode eDMA at EP side
> > >    dmaengine: dw-edma: Add support for chip specific flags
> > >    dmaengine: dw-edma: Add DW_EDMA_CHIP_32BIT_DBI for chip specific flags
> > > 
> > > 3. Bugs fix at EDMA driver when probe eDMA at EP side
> > >    dmaengine: dw-edma: Fix programming the source & dest addresses for ep
> > >    dmaengine: dw-edma: Don't rely on the deprecated "direction" member
> > > 
> > > 4. change pci-epf-test to use EDMA driver to transfer data.
> > >    PCI: endpoint: Add embedded DMA controller test
> > > 
> > > 5. Using imx8dxl to do test, but some EP functions still have not
> > > upstream yet. So below patch show how probe eDMA driver at EP
> > > controller driver.
> > > https://lore.kernel.org/linux-pci/20220309120149.GB134091@thinkpad/T/#m979eb506c73ab3cfca2e7a43635ecdaec18d8097
> > 
> > As I have already said in my comment to v9, @Lorenzo, @Rob, @Vinod,
> > my patchset:
> > Link: https://lore.kernel.org/linux-pci/20220503225104.12108-1-Sergey.Semin@baikalelectronics.ru
> > is based on this one. In its turn my series depends on the other
> > patchsets:
> > [PATCH v3 0/4] clk: Baikal-T1 DDR/PCIe resets and some xGMAC fixes
> > Link: https://lore.kernel.org/linux-pci/20220503205722.24755-1-Sergey.Semin@baikalelectronics.ru/
> > [PATCH v2 00/13] PCI: dwc: Various fixes and cleanups
> > Link: https://lore.kernel.org/linux-pci/20220503212300.30105-1-Sergey.Semin@baikalelectronics.ru/
> > [PATCH v2 00/17] PCI: dwc: Add dma-ranges/YAML-schema/Baikal-T1 support
> > Link: https://lore.kernel.org/linux-pci/20220503214638.1895-1-Sergey.Semin@baikalelectronics.ru/
> > which are currently on review. I am very much eager to get my patches
> > merged in before the next merge windows. But in order to preserve the
> > consistency of the corresponding repo with my patchsets the repo needs
> > to have the @Frank' patches. Seeing aside with @Frank's series my changes
> > depend on the changes in the clk and pci subsystems, could you please
> > consider choosing a single repository for merging all my and @Frank
> > patches in? Since the changes mostly concern the DW PCIe controller I
> > suggest to use the 'pci/dwc' branch of the
> > 'kernel/git/lpieralisi/pci.git' repository. What do you think?
> > @Lorenzo?
> > 
> 

> Sorry for the delay in replying. I think @Frank's series will
> go via the DMA engine tree, I will do my best to review your
> DWC changes:
> 
> [PATCH v2 00/13] PCI: dwc: Various fixes and cleanups
> Link: https://lore.kernel.org/linux-pci/20220503212300.30105-1-Sergey.Semin@baikalelectronics.ru/
> 
> but I can't guarantee they will make v5.19 and after that I will
> be AFK for two months, which is not good either, I will coordinate
> with Bjorn to see what can we do on this, I am sorry but that's
> all I have to offer at this stage.

This isn't good. Especially the part with leaving the subsystem
unattended for two more months seeing Kishon and Krzysztof haven't
been participating in the review procedure neither.

@Bjorn could you please join the review process of my series and if
they're ok, merge them in together with the @Frank'es patchset through
your repo? As you can see mainly the patchsets have already been
reviewed by @Manivannan. At least the DW PCIe and eDMA parts. There
are still patches waiting for the @Rob ackes though.

Seeing the native PCIe host subsystem will be left unattended for some
time I can help with looking for the DWC PCIe part of it:
drivers/pci/controller/dwc/*. If nobody minds.

-Sergey

> 
> Thanks,
> Lorenzo
> 
> > -Sergey
> > 
> > > 
> > > 
> > > Frank Li (7):
> > >   dmaengine: dw-edma: Remove unused field irq in struct dw_edma_chip
> > >   dmaengine: dw-edma: Detach the private data and chip info structures
> > >   dmaengine: dw-edma: Change rg_region to reg_base in struct
> > >     dw_edma_chip
> > >   dmaengine: dw-edma: Rename wr(rd)_ch_cnt to ll_wr(rd)_cnt in struct
> > >     dw_edma_chip
> > >   dmaengine: dw-edma: Add support for chip specific flags
> > >   dmaengine: dw-edma: Add DW_EDMA_CHIP_32BIT_DBI for chip specific flags
> > >   PCI: endpoint: Enable DMA controller tests for endpoints with DMA
> > >     capabilities
> > > 
> > > Serge Semin (2):
> > >   dmaengine: dw-edma: Drop dma_slave_config.direction field usage
> > >   dmaengine: dw-edma: Fix eDMA Rd/Wr-channels and DMA-direction
> > >     semantics
> > > 
> > >  drivers/dma/dw-edma/dw-edma-core.c            | 141 +++++++++++-------
> > >  drivers/dma/dw-edma/dw-edma-core.h            |  31 +---
> > >  drivers/dma/dw-edma/dw-edma-pcie.c            |  83 +++++------
> > >  drivers/dma/dw-edma/dw-edma-v0-core.c         |  54 ++++---
> > >  drivers/dma/dw-edma/dw-edma-v0-core.h         |   4 +-
> > >  drivers/dma/dw-edma/dw-edma-v0-debugfs.c      |  18 +--
> > >  drivers/dma/dw-edma/dw-edma-v0-debugfs.h      |   8 +-
> > >  drivers/pci/endpoint/functions/pci-epf-test.c | 108 ++++++++++++--
> > >  include/linux/dma/edma.h                      |  61 +++++++-
> > >  9 files changed, 323 insertions(+), 185 deletions(-)
> > > 
> > > -- 
> > > 2.35.1
> > >