From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D541C4332F for ; Thu, 12 May 2022 14:18:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355172AbiELOSd (ORCPT ); Thu, 12 May 2022 10:18:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354853AbiELOST (ORCPT ); Thu, 12 May 2022 10:18:19 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DE1887A03 for ; Thu, 12 May 2022 07:18:14 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id gj17-20020a17090b109100b001d8b390f77bso7966449pjb.1 for ; Thu, 12 May 2022 07:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=7iZZodcw2kcYl7DcsgXoMrjWgWmUo2hoVmfbC2enldQ=; b=f0iav4TX9MWlsCmY6kc9xgrGJbCfS5isN6BM1Z6iWUxV5R949SvxIHYuhyNXGq/LbV iAVEe/k5sttQeWMaw8UJeNzTt7nM8mgs/GC29uCwzVviZ9UmUBlRI+Yz4RUEq3Dnpjdu 2s0PTjvqcKHLtt7RtJpqsNMesXKMwyhVVaDQmx0ZS2gv/W14tS7b3di51NdIdSkN/LgV XzQIgrd3IqcQpA9t8nnDLybJ7SAHI7TXsGvLN72OpLgWmloZOd2HbrLfE11Ys9oztA22 585mp7uatbKavu7kiketYuGxOhssXwkcveNeYR6yEJEx5D8busxanwG2Ez59YvnJLBGT vRRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7iZZodcw2kcYl7DcsgXoMrjWgWmUo2hoVmfbC2enldQ=; b=7kP44ZyVYsARI77nXTZlPrgC12yfmcUrTpa8fa3pIG94bVEOVtqLrG9fxo9ZRRxYir mrSX0pr+rtkMJj5576HZshRLw2K7bC5eo9Q7EKjQQEviR35PyEYXp7oHw0Ux0v06EaCo wIIWZ1DIW7d4yH82KX4ZPwqhpPq3suxj8Bm40v/WU0Zya2NymuemIQorZamWetdGbc+8 n11TEjBRVvmSys/6bpiEd3TH9s+XDaNUzCun/NZdQdpxQJ2i6/yAeFc9oRM6IBUJW6Bc ymvpbA30YAhgZdMhjlZYJYPUpb7toCphe8tZZKlovGsDe2pikenZV+cUKCBMiYB0YvCX 6Otg== X-Gm-Message-State: AOAM5339GYp2yCKv02GXZ0clWxdEDB2Jd5uiNv6Uki211Mda/usKLly6 lKQKcHokD+sxfkDrAHQO76D+ X-Google-Smtp-Source: ABdhPJy0b5z0NMw6JCWSQ6xCOd3R5EJ290CTQnJbuWRxW4kXTEznCyVtk2LbYi8JPVi2vsroZVZbrg== X-Received: by 2002:a17:90a:170c:b0:1dc:20c4:6354 with SMTP id z12-20020a17090a170c00b001dc20c46354mr11089713pjd.113.1652365093661; Thu, 12 May 2022 07:18:13 -0700 (PDT) Received: from thinkpad ([117.202.184.202]) by smtp.gmail.com with ESMTPSA id u1-20020a170903124100b0015e8d4eb1f2sm3997428plh.60.2022.05.12.07.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 07:18:13 -0700 (PDT) Date: Thu, 12 May 2022 19:48:06 +0530 From: Manivannan Sadhasivam To: Serge Semin Cc: Gustavo Pimentel , Vinod Koul , Jingoo Han , Bjorn Helgaas , Lorenzo Pieralisi , Frank Li , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/26] dmaengine: Fix dma_slave_config.dst_addr description Message-ID: <20220512141806.GG35848@thinkpad> References: <20220503225104.12108-1-Sergey.Semin@baikalelectronics.ru> <20220503225104.12108-3-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220503225104.12108-3-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, May 04, 2022 at 01:50:40AM +0300, Serge Semin wrote: > Most likely due to a copy-paste mistake the dst_addr member of the > dma_slave_config structure has been marked as ignored if the !source! > address belong to the memory. That is relevant to the src_addr field of > the structure while the dst_addr field as containing a destination device > address is supposed to be ignored if the destination is the CPU memory. > Let's fix the field description accordingly. > > Signed-off-by: Serge Semin Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > include/linux/dmaengine.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index 842d4f7ca752..f204ea16ac1c 100644 > --- a/include/linux/dmaengine.h > +++ b/include/linux/dmaengine.h > @@ -395,7 +395,7 @@ enum dma_slave_buswidth { > * should be read (RX), if the source is memory this argument is > * ignored. > * @dst_addr: this is the physical address where DMA slave data > - * should be written (TX), if the source is memory this argument > + * should be written (TX), if the destination is memory this argument > * is ignored. > * @src_addr_width: this is the width in bytes of the source (RX) > * register where DMA data shall be read. If the source > -- > 2.35.1 > -- மணிவண்ணன் சதாசிவம்