linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: "Serge Semin" <Sergey.Semin@baikalelectronics.ru>,
	"Serge Semin" <fancer.lancer@gmail.com>,
	"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
	"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	linux-clk@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] clk: baikal-t1: Move reset-controls code into a dedicated module
Date: Tue, 17 May 2022 00:37:26 -0700	[thread overview]
Message-ID: <20220517073729.2FAE2C385B8@smtp.kernel.org> (raw)
In-Reply-To: <20220503205722.24755-4-Sergey.Semin@baikalelectronics.ru>

Quoting Serge Semin (2022-05-03 13:57:21)
> Before adding the directly controlled resets support it's reasonable to
> move the existing resets control functionality into a dedicated object for
> the sake of the CCU dividers clock driver simplification. After the new
> functionality is added clk-ccu-div.c would have got to a mixture of the
> weakly dependent clocks and resets methods. Splitting the methods up into
> the two objects will make code easier to read especially seeing it isn't
> that hard to do.
> 
> As before the CCU reset module will support the trigger-like CCU resets
> only, which are responsible for the AXI-bus, APB-bus and SATA-ref blocks
> reset. The assert/de-assert-capable reset controls support will be added
> in the next commit.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
>  drivers/clk/baikal-t1/Kconfig       |  12 +-
>  drivers/clk/baikal-t1/Makefile      |   1 +
>  drivers/clk/baikal-t1/ccu-rst.c     | 258 ++++++++++++++++++++++++++++
>  drivers/clk/baikal-t1/ccu-rst.h     |  60 +++++++
>  drivers/clk/baikal-t1/clk-ccu-div.c |  94 ++--------

Perhaps this should be done via the auxiliary bus by having the clk
driver register the reset driver and have some private API to pass any
data to the reset driver? Then the whole file could be in
drivers/reset/, reviewed and maintained by the reset maintainer.

  reply	other threads:[~2022-05-17  7:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03 20:57 [PATCH v3 0/4] clk: Baikal-T1 DDR/PCIe resets and some xGMAC fixes Serge Semin
2022-05-03 20:57 ` [PATCH v3 1/4] clk: baikal-t1: Fix invalid xGMAC PTP clock divider Serge Semin
2022-05-03 20:57 ` [PATCH v3 2/4] clk: baikal-t1: Define shared xGMAC ref/ptp clocks parent Serge Semin
2022-05-03 20:57 ` [PATCH v3 3/4] clk: baikal-t1: Move reset-controls code into a dedicated module Serge Semin
2022-05-17  7:37   ` Stephen Boyd [this message]
2022-05-17 12:01     ` Serge Semin
2022-05-03 20:57 ` [PATCH v3 4/4] clk: baikal-t1: Add DDR/PCIe directly controlled resets support Serge Semin
2022-05-12  0:11 ` [PATCH v3 0/4] clk: Baikal-T1 DDR/PCIe resets and some xGMAC fixes Serge Semin
2022-05-12 15:27   ` Lorenzo Pieralisi
2022-05-12 17:11     ` Manivannan Sadhasivam
2022-05-12 21:14       ` Serge Semin
2022-05-17  7:40         ` Stephen Boyd
2022-05-17 10:05           ` Serge Semin
2022-05-13 11:44 ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220517073729.2FAE2C385B8@smtp.kernel.org \
    --to=sboyd@kernel.org \
    --cc=Alexey.Malahov@baikalelectronics.ru \
    --cc=Pavel.Parkhomenko@baikalelectronics.ru \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=bhelgaas@google.com \
    --cc=fancer.lancer@gmail.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jingoohan1@gmail.com \
    --cc=kw@linux.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).