From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Keith Busch" <kbusch@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Stanimir Varbanov" <svarbanov@mm-sol.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Jens Axboe" <axboe@fb.com>,
"Veerabhadrarao Badiganti" <quic_vbadigan@quicinc.com>,
quic_krichai@quicinc.com,
"Nitin Rawat" <quic_nitirawa@quicinc.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Prasad Malisetty" <quic_pmaliset@quicinc.com>,
"Andy Gross" <agross@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rajat Jain" <rajatja@google.com>,
"Saheed O. Bolarinwa" <refactormyself@gmail.com>,
"Rama Krishna" <quic_ramkri@quicinc.com>,
"Stephen Boyd" <swboyd@chromium.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Kalle Valo" <kvalo@kernel.org>
Subject: Re: [PATCH 2/3] PCI: dwc: qcom: Set suspend_poweroff flag for SC7280
Date: Wed, 18 May 2022 09:22:11 +0530 [thread overview]
Message-ID: <20220518035211.GA4791@thinkpad> (raw)
In-Reply-To: <20220517171857.GA1083896@bhelgaas>
On Tue, May 17, 2022 at 12:18:57PM -0500, Bjorn Helgaas wrote:
> [+cc Prasad, Andy, Rob, Krzysztof, Rajat, Saheed, Rama, Stephen,
> Dmitry, Kalle for connection to https://lore.kernel.org/lkml/CAE-0n53ho2DX2rqQMvvKAuDCfsWW62TceTaNPzv5Mn_NQ-U6dA@mail.gmail.com/T/]
>
> Subject line convention for this file is "PCI: qcom:" (not "PCI: dwc:
> qcom:").
>
> Find this from "git log --oneline drivers/pci/controller/dwc/pcie-qcom.c".
>
> On Tue, May 17, 2022 at 08:41:34PM +0530, Manivannan Sadhasivam wrote:
> > On Mon, May 16, 2022 at 03:19:50PM -0500, Bjorn Helgaas wrote:
> > > On Fri, May 13, 2022 at 04:30:26PM +0530, Manivannan Sadhasivam wrote:
> > > > For aggressive power saving on SC7280 SoCs, the power for the
> > > > PCI devices will be taken off during system suspend. Hence,
> > > > notify the same to the PCI device drivers using
> > > > "suspend_poweroff" flag so that the drivers can prepare the PCI
> > > > devices to handle the poweroff and recover them during resume.
> > >
> > > No doubt "power ... will be taken off during system suspend" is
> > > true, but this isn't very informative. Is this a property of
> > > SC7280? A choice made by the SC7280 driver? Why is this not
> > > applicable to other systems?
> >
> > The SC7280's RPMh firmware is cutting off the PCIe power domain
> > during system suspend. And as I explained in previous patch, the RC
> > driver itself may put the devices in D3cold conditionally on this
> > platform. The reason is to save power as this chipset is being used
> > in Chromebooks.
>
> It looks like this should be squashed into the patch you mentioned:
> https://lore.kernel.org/lkml/CAE-0n53ho2DX2rqQMvvKAuDCfsWW62TceTaNPzv5Mn_NQ-U6dA@mail.gmail.com/T/
>
> If Prasad's patch is applied without this, devices will be powered
> off, but nvme will not be prepared for it. Apparently something would
> be broken in that case?
>
Yes, but Prasad's patch is not yet reviewed so likely not get merged until
further respins.
> Also, I think this patch should be reordered so the nvme driver is
> prepared for suspend_poweroff before the qcom driver starts setting
> it. Otherwise there's a window where qcom sets suspend_poweroff and
> powers off devices, but nvme doesn't know about it, and I assume
> something will be broken in that case?
>
As per my understanding, patches in a series should not have build dependency
but they may depend on each other for functionality.
But I don't have any issue in reordering the patches. Will do.
> Please mention RPMh in the commit log, along with the specific
> connection with system suspend, i.e., what OS action enables RPMh to
> cut power.
>
Okay, will do.
Thanks,
Mani
> > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > > ---
> > > > drivers/pci/controller/dwc/pcie-qcom.c | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> > > > index 6ab90891801d..4b0ad2827f8f 100644
> > > > --- a/drivers/pci/controller/dwc/pcie-qcom.c
> > > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> > > > @@ -199,6 +199,7 @@ struct qcom_pcie_cfg {
> > > > unsigned int has_ddrss_sf_tbu_clk:1;
> > > > unsigned int has_aggre0_clk:1;
> > > > unsigned int has_aggre1_clk:1;
> > > > + unsigned int suspend_poweroff:1;
> > > > };
> > > >
> > > > struct qcom_pcie {
> > > > @@ -1220,6 +1221,10 @@ static int qcom_pcie_init_2_7_0(struct qcom_pcie *pcie)
> > > > if (pcie->cfg->pipe_clk_need_muxing)
> > > > clk_set_parent(res->pipe_clk_src, res->ref_clk_src);
> > > >
> > > > + /* Indicate PCI device drivers that the power will be taken off during system suspend */
> > > > + if (pcie->cfg->suspend_poweroff)
> > > > + pci->pp.bridge->suspend_poweroff = true;
> > > > +
> > > > ret = clk_bulk_prepare_enable(res->num_clks, res->clks);
> > > > if (ret < 0)
> > > > goto err_disable_regulators;
> > > > @@ -1548,6 +1553,7 @@ static const struct qcom_pcie_cfg sc7280_cfg = {
> > > > .ops = &ops_1_9_0,
> > > > .has_tbu_clk = true,
> > > > .pipe_clk_need_muxing = true,
> > > > + .suspend_poweroff = true,
> > > > };
> > > >
> > > > static const struct dw_pcie_ops dw_pcie_ops = {
> > > > --
> > > > 2.25.1
> > > >
> >
> > --
> > மணிவண்ணன் சதாசிவம்
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-05-18 3:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 11:00 [PATCH 0/3] PCI: Notify PCI drivers about powerdown during suspend Manivannan Sadhasivam
2022-05-13 11:00 ` [PATCH 1/3] PCI: Add a flag to notify " Manivannan Sadhasivam
2022-05-16 20:18 ` Bjorn Helgaas
2022-05-17 15:09 ` Manivannan Sadhasivam
2022-05-17 17:24 ` Bjorn Helgaas
2022-05-18 3:59 ` Manivannan Sadhasivam
2022-05-26 20:48 ` Rob Herring
2022-05-13 11:00 ` [PATCH 2/3] PCI: dwc: qcom: Set suspend_poweroff flag for SC7280 Manivannan Sadhasivam
2022-05-16 20:19 ` Bjorn Helgaas
2022-05-17 15:11 ` Manivannan Sadhasivam
2022-05-17 17:18 ` Bjorn Helgaas
2022-05-18 3:52 ` Manivannan Sadhasivam [this message]
2022-05-18 16:50 ` Bjorn Helgaas
2022-05-18 8:43 ` Christoph Hellwig
2022-05-13 11:00 ` [PATCH 3/3] nvme-pci: Make use of "suspend_poweroff" flag during system suspend Manivannan Sadhasivam
2022-05-16 5:44 ` [PATCH 0/3] PCI: Notify PCI drivers about powerdown during suspend Christoph Hellwig
2022-05-16 20:15 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518035211.GA4791@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=kvalo@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=quic_krichai@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_pmaliset@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=rajatja@google.com \
--cc=refactormyself@gmail.com \
--cc=robh@kernel.org \
--cc=sagi@grimberg.me \
--cc=svarbanov@mm-sol.com \
--cc=swboyd@chromium.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).