From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD9EC43334 for ; Fri, 10 Jun 2022 08:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343722AbiFJIb3 (ORCPT ); Fri, 10 Jun 2022 04:31:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346335AbiFJI31 (ORCPT ); Fri, 10 Jun 2022 04:29:27 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF7A52B261; Fri, 10 Jun 2022 01:29:24 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id y29so28801061ljd.7; Fri, 10 Jun 2022 01:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=temX1664rcBkx3D1+80w8dBTL4uTtEodtkihYr/KQfY=; b=o8jpBqceOtsY6p03YxtHJ61h2Ck4r3dy5GMmPLabfPnBSyM3eD5ENRMBy1MZzXoTzn 4i+dAZ5bmlOR/OQunHCl2eqnwiAZYTKqi4NRlZBoekdIRoOHv9pw6ms5M5YIW6S66YT+ sRxTSra+kIWT6hez/v18WQO0FN87Ew9Tade87/gIu56yB3tjZM0BNqdSc4QHV+OOna0/ HrEJB3Gu/NNT7VsuuQBFWA9cLuww/4/KDTqsEMnEiDH9FewXp+f+6aXmT/wbyZev4Hno cpofuWBG7JEzTGzBj9yoZGRxMeCs99wJ+ICvnplR5QfWSmuDEeMfuw4CHxkXDrt0fzLX 7Szw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=temX1664rcBkx3D1+80w8dBTL4uTtEodtkihYr/KQfY=; b=01SbPKpuyQF7xNNC19bMuJn4jrJ6/RR0P7kcb+SEi/J9jgstu6nIZ0liXi9U1dbPPs eNYVrFrn6maqMQprFM0qeCW++7VqNr0ns/A1+VKOxZg9WVS9CiZSkQ+e2e/U9GR5BhgK mBB8AfVHKOGzLYNXEznfujb/0JS+l7T+lvBxq2p0IFq/Gc9uFj+UI0Y7S7P4y3HsH0ss EaT/gWsIff2Rj5XU5eRI6TeXyEm+8i6EGND/pphxMuiSotjrjTViQd7VXx5J5yEjzlSC JeHe0AizVzv1kszzcMeRuDMMEov78JJ3Y9znOUniYrvXl87mrqU6dVIWEQrgmgbqbk3n fmsg== X-Gm-Message-State: AOAM531ZIYPA4Up6DKr9SeyJSbBWKZuk6EGesNYh0TflBTAeHrzajKLB p8Kiekk/qZe5qc616FPy9QM= X-Google-Smtp-Source: ABdhPJzWeGTwiRg4rFf280xOQ2NkTLuqer/40d6VlQ7atD6b3uvDUvNngeOoQhfvPXEpyE28lNDlgg== X-Received: by 2002:a2e:91cd:0:b0:255:70be:8ea9 with SMTP id u13-20020a2e91cd000000b0025570be8ea9mr24612392ljg.340.1654849762849; Fri, 10 Jun 2022 01:29:22 -0700 (PDT) Received: from mobilestation ([95.79.189.214]) by smtp.gmail.com with ESMTPSA id k10-20020ac24f0a000000b0047255d211ecsm4605910lfr.283.2022.06.10.01.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 01:29:21 -0700 (PDT) Date: Fri, 10 Jun 2022 11:29:19 +0300 From: Serge Semin To: Manivannan Sadhasivam , Serge Semin Cc: Rob Herring , Bjorn Helgaas , Lorenzo Pieralisi , Alexey Malahov , Pavel Parkhomenko , Jingoo Han , Gustavo Pimentel , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Frank Li , Manivannan Sadhasivam , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/18] PCI: dwc: Various fixes and cleanups Message-ID: <20220610082919.4wetzo7wj4bnjp45@mobilestation> References: <20220610082535.12802-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220610082535.12802-1-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Jun 10, 2022 at 11:25:16AM +0300, Serge Semin wrote: > This patchset is a first one in the series created in the framework of > my Baikal-T1 PCIe/eDMA-related work: > > [1: In-progress v4] PCI: dwc: Various fixes and cleanups > Link: ---you are looking at it--- > [2: In-progress v2] PCI: dwc: Add hw version and dma-ranges support > Link: https://lore.kernel.org/linux-pci/20220503214638.1895-1-Sergey.Semin@baikalelectronics.ru/ > [3: In-progress v2] PCI: dwc: Add extended YAML-schema and Baikal-T1 support > Link: https://lore.kernel.org/linux-pci/20220503214638.1895-1-Sergey.Semin@baikalelectronics.ru/ > [4: In-progress v2] dmaengine: dw-edma: Add RP/EP local DMA support > Link: https://lore.kernel.org/linux-pci/20220503225104.12108-1-Sergey.Semin@baikalelectronics.ru/ > > Note it is very recommended to merge the patchsets in the same order as > they are placed in the list above in order to prevent possible merge > conflicts. Nothing prevents them from being reviewed synchronously though. > Any tests are very welcome! > > As it can be easily inferred from the patchset title, this series is about > the DW PCIe Root Port/Endpoint driver fixes and the code cleanups, where > fixes come before the cleanup patches. The patchset starts with adding the > stop_link() platform-specific method invocation in case of the PCIe host > probe procedure errors. It has been missing in the cleanup-on-error path > of the DW PCIe Host initialization method. After that the unrolled CSRs > layout is added to the iATU disable procedure. In third the disable iATU > procedure is fixed to be called only for the internal ATU as being > specific for the internal ATU implementation. Then the outbound iATU > extended region setup procedure is fixed to have the INCREASE_REGION_SIZE > flag set based on the limit-address - not the region size one. The last > but not least the CDM-check enabling procedure is fixed to be independent > from the non-related num_lanes field state. > > Afterwards there is a series of cleanups. It concerns the changes like > adding braces to the multi-line if-else constructions, trailing new-lines > to the print format-string, dropping unnecessary version checking, and > various code simplifications and optimizations. > > New features like adding two-level DT bindings abstraction, adding better > structured IP-core version interface, adding iATU regions size detection > and the PCIe regions verification procedure, adding dma-ranges support, > introducing a set of generic platform clocks and resets and finally adding > Baikal-T1 PCIe interface support will be submitted in the next part of the > series. > > Link: https://lore.kernel.org/linux-pci/20220324012524.16784-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v2: > - Fix the end address of the example in the patch log with > the INCREASE_REGION_SIZE flag usage fixup. It should be > 0x1000FFFF and not 0x0000FFFF (@Manivannan). > - Add the cleanup-on-error path to the dw_pcie_ep_init() function. > (@Manivannan) > > Link: https://lore.kernel.org/linux-pci/20220503212300.30105-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v3: > - Convert region variable type to u32 in order to fix the implicit type > conversion peculiarity. (@kbot) > - Rebase onto v5.18-rc6. > > Link: https://lore.kernel.org/linux-pci/20220517125058.18488-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v4: > - Move the patch "PCI: dwc: Deallocate EPC memory on EP init error" to > being applied before the cleanup patches. > - Add a new fixes patch: "PCI: dwc: Enable CDM-check independently from > the num_lanes value". > - Add a new cleanup patch: "PCI: dwc: Organize local variables usage". > - Add a new cleanup patch: "PCI: dwc: Re-use local pointer to the > resource data". > - Add a new cleanup patch: "PCI: dwc: Add start_link/stop_link inliners". > - Add a new cleanup patch: "PCI: dwc: Move io_cfg_atu_shared to the Root > Port descriptor". > - Add a new cleanup patch: "PCI: dwc: Add dw_ prefix to the pcie_port > structure name". > - Drop the patch "PCI: dwc: Don't use generic IO-ops for DBI-space > access". (@Rob) > - Drop Manivannan tested tag from the changed patches. @Mani, there are several brand new patches in this series and a few ones updated (@Rob requests). Could you please have a look at the patchset one more time? -Sergey > - Rebase onto v5.18. > > Signed-off-by: Serge Semin > Cc: Alexey Malahov > Cc: Pavel Parkhomenko > Cc: Jingoo Han > Cc: Gustavo Pimentel > Cc: "Krzysztof Wilczyński" > Cc: Frank Li > Cc: Manivannan Sadhasivam > Cc: linux-pci@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > > Serge Semin (18): > PCI: dwc: Stop link in the host init error and de-initialization > PCI: dwc: Add unroll iATU space support to the regions disable method > PCI: dwc: Disable outbound windows for controllers with iATU > PCI: dwc: Set INCREASE_REGION_SIZE flag based on limit address > PCI: dwc: Deallocate EPC memory on EP init error > PCI: dwc: Enable CDM-check independently from the num_lanes value > PCI: dwc: Add braces to the multi-line if-else statements > PCI: dwc: Add trailing new-line literals to the log messages > PCI: dwc: Discard IP-core version checking on unrolled iATU detection > PCI: dwc: Convert Link-up status method to using dw_pcie_readl_dbi() > PCI: dwc: Organize local variables usage > PCI: dwc: Re-use local pointer to the resource data > PCI: dwc: Add start_link/stop_link inliners > PCI: dwc: Move io_cfg_atu_shared to the Root Port descriptor > PCI: dwc: Add dw_ prefix to the pcie_port structure name > PCI: dwc-plat: Simplify the probe method return value handling > PCI: dwc-plat: Discard unused regmap pointer > PCI: dwc-plat: Drop dw_plat_pcie_of_match forward declaration > > drivers/pci/controller/dwc/pci-dra7xx.c | 12 +- > drivers/pci/controller/dwc/pci-exynos.c | 6 +- > drivers/pci/controller/dwc/pci-imx6.c | 6 +- > drivers/pci/controller/dwc/pci-keystone.c | 20 ++-- > .../pci/controller/dwc/pci-layerscape-ep.c | 12 -- > drivers/pci/controller/dwc/pci-layerscape.c | 2 +- > drivers/pci/controller/dwc/pci-meson.c | 2 +- > drivers/pci/controller/dwc/pcie-al.c | 6 +- > drivers/pci/controller/dwc/pcie-armada8k.c | 4 +- > drivers/pci/controller/dwc/pcie-artpec6.c | 4 +- > .../pci/controller/dwc/pcie-designware-ep.c | 30 +++-- > .../pci/controller/dwc/pcie-designware-host.c | 104 ++++++++++-------- > .../pci/controller/dwc/pcie-designware-plat.c | 25 +---- > drivers/pci/controller/dwc/pcie-designware.c | 72 +++++++----- > drivers/pci/controller/dwc/pcie-designware.h | 46 +++++--- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 +- > drivers/pci/controller/dwc/pcie-fu740.c | 2 +- > drivers/pci/controller/dwc/pcie-histb.c | 10 +- > drivers/pci/controller/dwc/pcie-intel-gw.c | 6 +- > drivers/pci/controller/dwc/pcie-keembay.c | 4 +- > drivers/pci/controller/dwc/pcie-kirin.c | 2 +- > drivers/pci/controller/dwc/pcie-qcom.c | 4 +- > drivers/pci/controller/dwc/pcie-spear13xx.c | 6 +- > drivers/pci/controller/dwc/pcie-tegra194.c | 22 ++-- > drivers/pci/controller/dwc/pcie-uniphier.c | 10 +- > drivers/pci/controller/dwc/pcie-visconti.c | 6 +- > 26 files changed, 225 insertions(+), 202 deletions(-) > > -- > 2.35.1 >