From: Bjorn Helgaas <helgaas@kernel.org>
To: Krishna chaitanya chundru <quic_krichai@quicinc.com>
Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com,
quic_hemantk@quicinc.com, quic_nitegupt@quicinc.com,
quic_skananth@quicinc.com, quic_ramkri@quicinc.com,
manivannan.sadhasivam@linaro.org, swboyd@chromium.org,
dmitry.baryshkov@linaro.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks.
Date: Fri, 24 Jun 2022 11:58:13 -0500 [thread overview]
Message-ID: <20220624165813.GA1541013@bhelgaas> (raw)
In-Reply-To: <1656062391-14567-3-git-send-email-quic_krichai@quicinc.com>
On Fri, Jun 24, 2022 at 02:49:50PM +0530, Krishna chaitanya chundru wrote:
> Add missing clocks.
When you revise this, please make your subject line match the history:
dt-bindings: PCI: qcom: Add schema for sc7280 chipset
dt-bindings: PCI: qcom: Specify reg-names explicitly
dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms
dt-bindings: PCI: qcom: Convert to YAML
So your subject line should be something like:
dt-bindings: PCI: qcom: Add sc7280 aggre0 and aggre1 clocks
Please also include the names of the clocks you're adding in the
commit log. This will make the commit log history more specific and
useful for future readers.
This also applies to the other patches.
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
> ---
> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index 0b69b12..313b981 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -438,6 +438,8 @@ allOf:
> - const: slave_q2a # Slave Q2A clock
> - const: tbu # PCIe TBU clock
> - const: ddrss_sf_tbu # PCIe SF TBU clock
> + - const: aggre0 # Aggre NoC PCIE CENTER SF AXI clock
> + - const: aggre1 # Aggre NoC PCIe1 AXI clock
I assume the stuff after "#" is comment and could thus be made
consistent: s/PCIE/PCIe/, is "PCIe1" a typo for "PCIe" or different?
Seems like weird/inconsistent capitalization in general ("CENTER"),
but if you're matching language in a spec, please do that and ignore
my comment :)
> resets:
> maxItems: 1
> reset-names:
> --
> 2.7.4
>
next prev parent reply other threads:[~2022-06-24 16:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 9:19 [PATCH v1 0/3] PCI: qcom: sc7280: add missing clocks Krishna chaitanya chundru
2022-06-24 9:19 ` [PATCH v1 1/3] PCI: qcom: Add missing sc7280 clocks in PCIe driver Krishna chaitanya chundru
2022-06-24 17:05 ` Bjorn Helgaas
2022-06-24 21:06 ` Bjorn Helgaas
2022-06-28 6:39 ` Krishna Chaitanya Chundru
2022-06-24 9:19 ` [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks Krishna chaitanya chundru
2022-06-24 15:23 ` Krzysztof Kozlowski
2022-06-24 16:58 ` Bjorn Helgaas [this message]
2022-06-28 6:43 ` Krishna Chaitanya Chundru
2022-06-24 9:19 ` [PATCH v1 3/3] arm64: dts: qcom: sc7280: Add missing pcie clocks Krishna chaitanya chundru
2022-06-24 15:23 ` Krzysztof Kozlowski
2022-07-01 16:11 ` [PATCH v2 0/3] PCI: qcom: sc7280: add missing aggre0, aggre1 and ddrs sf tbu clocks Krishna chaitanya chundru
2022-07-01 16:11 ` [PATCH v2 1/3] PCI: qcom: Add sc7280 aggre0, aggre1 and ddr sf tbu clocks in PCIe driver Krishna chaitanya chundru
2022-07-01 16:11 ` [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks Krishna chaitanya chundru
2022-07-04 8:24 ` Krzysztof Kozlowski
2022-07-06 11:55 ` Krishna Chaitanya Chundru
2022-07-06 14:59 ` Krzysztof Kozlowski
2022-08-29 17:45 ` Krishna Chaitanya Chundru
2022-08-30 6:23 ` Krzysztof Kozlowski
2022-07-01 16:11 ` [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add missing " Krishna chaitanya chundru
2022-07-04 8:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624165813.GA1541013@bhelgaas \
--to=helgaas@kernel.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_hemantk@quicinc.com \
--cc=quic_krichai@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).