From: Bjorn Helgaas <helgaas@kernel.org>
To: Robert Marko <robimarko@gmail.com>
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
lpieralisi@kernel.org, Rob Herring <robh@kernel.org>,
kw@linux.com, Bjorn Helgaas <bhelgaas@google.com>,
p.zabel@pengutronix.de, jingoohan1@gmail.com,
linux-pci@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
johan+linaro@kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v3 2/2] PCI: qcom: move register accesses to .post_init
Date: Fri, 24 Jun 2022 12:06:41 -0500 [thread overview]
Message-ID: <20220624170641.GA1541953@bhelgaas> (raw)
In-Reply-To: <CAOX2RU4zbG8J59k0L22fbUK2fKFOKvW1O2hTTdW1bEpNv7=vjA@mail.gmail.com>
On Fri, Jun 24, 2022 at 12:46:55PM +0200, Robert Marko wrote:
> On Fri, 24 Jun 2022 at 12:36, Robert Marko <robimarko@gmail.com> wrote:
> > On Thu, 23 Jun 2022 at 23:55, Bjorn Helgaas <helgaas@kernel.org> wrote:
> > > On Thu, Jun 23, 2022 at 05:50:04PM +0200, Robert Marko wrote:
> > > > Move register accesses from .init to .post_init callbacks to maintain
> > > > consinstency for all IP since IPQ8074 specifically requires PHY-s to be
> > > > powered on before register access and its accesses have been moved to
> > > > .post_init.
> > >
> > > This doesn't do the corresponding move for qcom_pcie_init_2_7_0(). Is
> > > that intentional or an oversight?
> >
> > Hi,
> >
> > It was an oversight on my part, will fixup it now, sorry for the mistake.
> >
> > Regards,
> > Robert
>
> Bjorn,
>
> I updated the title and description based on your fixups in your branch,
> hope that is ok.
It's great, thanks for noticing and paying attention to the little
details!
Bjorn
next prev parent reply other threads:[~2022-06-24 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 15:50 [PATCH v3 1/2] PCI: qcom: fix IPQ8074 Gen2 support Robert Marko
2022-06-23 15:50 ` [PATCH v3 2/2] PCI: qcom: move register accesses to .post_init Robert Marko
2022-06-23 21:55 ` Bjorn Helgaas
2022-06-24 10:36 ` Robert Marko
2022-06-24 10:46 ` Robert Marko
2022-06-24 17:06 ` Bjorn Helgaas [this message]
2022-06-23 16:03 ` [PATCH v3 1/2] PCI: qcom: fix IPQ8074 Gen2 support Bjorn Helgaas
2022-06-23 16:17 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624170641.GA1541953@bhelgaas \
--to=helgaas@kernel.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jingoohan1@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=robimarko@gmail.com \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).