From: Bjorn Helgaas <helgaas@kernel.org>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, "Jianmin Lv" <lvjianmin@loongson.cn>,
"Xuefeng Li" <lixuefeng@loongson.cn>,
"Huacai Chen" <chenhuacai@gmail.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH V14 1/7] PCI/ACPI: Guard ARM64-specific mcfg_quirks
Date: Mon, 27 Jun 2022 16:53:53 -0500 [thread overview]
Message-ID: <20220627215353.GA1781942@bhelgaas> (raw)
In-Reply-To: <20220617074330.12605-2-chenhuacai@loongson.cn>
On Fri, Jun 17, 2022 at 03:43:24PM +0800, Huacai Chen wrote:
> Guard ARM64-specific quirks with CONFIG_ARM64 to avoid build errors,
> since mcfg_quirks will be shared by more than one architectures.
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
pci_mcfg.o is only built when CONFIG_ACPI_MCFG=y. Where's the patch
that sets CONFIG_ACPI_MCFG=y for loongson?
I see that "PCI: loongson: Add ACPI init support" adds the #ifdef
CONFIG_LOONGARCH here, but AFAICS we still won't build it.
> ---
> drivers/acpi/pci_mcfg.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c
> index 53cab975f612..63b98eae5e75 100644
> --- a/drivers/acpi/pci_mcfg.c
> +++ b/drivers/acpi/pci_mcfg.c
> @@ -41,6 +41,8 @@ struct mcfg_fixup {
> static struct mcfg_fixup mcfg_quirks[] = {
> /* { OEM_ID, OEM_TABLE_ID, REV, SEGMENT, BUS_RANGE, ops, cfgres }, */
>
> +#ifdef CONFIG_ARM64
> +
> #define AL_ECAM(table_id, rev, seg, ops) \
> { "AMAZON", table_id, rev, seg, MCFG_BUS_ANY, ops }
>
> @@ -169,6 +171,7 @@ static struct mcfg_fixup mcfg_quirks[] = {
> ALTRA_ECAM_QUIRK(1, 13),
> ALTRA_ECAM_QUIRK(1, 14),
> ALTRA_ECAM_QUIRK(1, 15),
> +#endif /* ARM64 */
> };
>
> static char mcfg_oem_id[ACPI_OEM_ID_SIZE];
> --
> 2.27.0
>
next prev parent reply other threads:[~2022-06-27 21:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 7:43 [PATCH V14 0/7] PCI: Loongson pci improvements and quirks Huacai Chen
2022-06-17 7:43 ` [PATCH V14 1/7] PCI/ACPI: Guard ARM64-specific mcfg_quirks Huacai Chen
2022-06-27 21:53 ` Bjorn Helgaas [this message]
2022-06-28 2:52 ` Huacai Chen
2022-06-17 7:43 ` [PATCH V14 2/7] PCI: loongson: Use generic 8/16/32-bit config ops on LS2K/LS7A Huacai Chen
2022-06-17 7:43 ` [PATCH V14 3/7] PCI: loongson: Add ACPI init support Huacai Chen
2022-06-17 7:43 ` [PATCH V14 4/7] PCI: loongson: Don't access non-existant devices Huacai Chen
2022-06-27 21:38 ` Bjorn Helgaas
2022-06-28 13:03 ` Jianmin Lv
2022-06-28 16:04 ` Bjorn Helgaas
2022-06-29 0:33 ` Jianmin Lv
2022-06-29 10:03 ` Huacai Chen
2022-06-17 7:43 ` [PATCH V14 5/7] PCI: loongson: Improve the MRRS quirk for LS7A Huacai Chen
2022-06-17 7:43 ` [PATCH V14 6/7] PCI: Add quirk for LS7A to avoid reboot failure Huacai Chen
2022-06-17 7:43 ` [PATCH V14 7/7] PCI: Add quirk for multifunction devices of LS7A Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627215353.GA1781942@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=lorenzo.pieralisi@arm.com \
--cc=lvjianmin@loongson.cn \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).