From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C804CCA47B for ; Thu, 30 Jun 2022 17:10:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235304AbiF3RKx (ORCPT ); Thu, 30 Jun 2022 13:10:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233126AbiF3RKx (ORCPT ); Thu, 30 Jun 2022 13:10:53 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AEA635269; Thu, 30 Jun 2022 10:10:52 -0700 (PDT) Received: from fraeml738-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LYlFP3bFxz688pK; Fri, 1 Jul 2022 01:10:01 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml738-chm.china.huawei.com (10.206.15.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 30 Jun 2022 19:10:50 +0200 Received: from localhost (10.81.200.250) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 30 Jun 2022 18:10:49 +0100 Date: Thu, 30 Jun 2022 18:10:48 +0100 From: Jonathan Cameron To: Dan Williams CC: , , , , Subject: Re: [PATCH 44/46] cxl/pmem: Delete unused nvdimm attribute Message-ID: <20220630181048.00001248@Huawei.com> In-Reply-To: <20220624041950.559155-19-dan.j.williams@intel.com> References: <165603869943.551046.3498980330327696732.stgit@dwillia2-xfh> <20220624041950.559155-19-dan.j.williams@intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.81.200.250] X-ClientProxiedBy: lhreml754-chm.china.huawei.com (10.201.108.204) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, 23 Jun 2022 21:19:48 -0700 Dan Williams wrote: > While there is a need to go from a LIBNVDIMM 'struct nvdimm' to a CXL > 'struct cxl_nvdimm', there is no use case to go the other direction. > Likely this is a leftover from an early version of the referenced commit > before it implemented devm for releasing the created nvdimm. > > Fixes: 21083f51521f ("cxl/pmem: Register 'pmem' / cxl_nvdimm devices") > Signed-off-by: Dan Williams Must be right given it builds, so no one is using it ;) FWIW: Reviewed-by: Jonathan Cameron > --- > drivers/cxl/cxl.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h > index 734b4479feb2..d6ff6337aa49 100644 > --- a/drivers/cxl/cxl.h > +++ b/drivers/cxl/cxl.h > @@ -411,7 +411,6 @@ struct cxl_nvdimm_bridge { > struct cxl_nvdimm { > struct device dev; > struct cxl_memdev *cxlmd; > - struct nvdimm *nvdimm; > }; > > /**