From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A364C43334 for ; Thu, 7 Jul 2022 18:34:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236640AbiGGSeH (ORCPT ); Thu, 7 Jul 2022 14:34:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236482AbiGGSdt (ORCPT ); Thu, 7 Jul 2022 14:33:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48FDA65D7A; Thu, 7 Jul 2022 11:31:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC9706224A; Thu, 7 Jul 2022 18:31:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0738C3411E; Thu, 7 Jul 2022 18:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657218676; bh=6H4otsM+waE4dVzYoIhYtGakU7UsxGvGs8V4UhCwWLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AVcR9BEnIteKrsshXQBk3+8HHlfCwNMo1smY/GVwny7VKin6zGBR6GacZilBCsr11 JahP8UctdbsythFcaVx6o33iO1MSIhbesQiJqmPPgCu6CdL4/JBi718CJGzHreMiJR +qBtMrbZh6XFFKXEm7NdOOviGGIS1shXKgnHdiWE7pKhAHZnxpn68F+w9bvPkwnMnC LaD69S6gLKX26hhirXP7KB7pYEr8z1HHWPIh4uuZr+55wh6bMqKQYUWJGSPZfqu3u5 97jxigOgnLftXe9WL+HZpc7va+ERTvJzwsjtYU/PsupoPRe2R79M1LVRY03Lm45lgf zxxyuy44HaPzQ== Received: by pali.im (Postfix) id CC3F07B1; Thu, 7 Jul 2022 20:31:12 +0200 (CEST) Date: Thu, 7 Jul 2022 20:31:12 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Jason Gunthorpe Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ARM: Marvell: Update PCIe fixup Message-ID: <20220707183112.f7dgz3lzordxnqhj@pali> References: <20211101150405.14618-1-pali@kernel.org> <20211102171259.9590-1-pali@kernel.org> <20211109225332.kqyfm4h4kwcnhhhl@pali> <20220514182125.xfvnw7yj2rmxpi7l@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220514182125.xfvnw7yj2rmxpi7l@pali> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org PING? I have not received any reply! On Saturday 14 May 2022 20:21:25 Pali Rohár wrote: > On Tuesday 09 November 2021 23:53:32 Pali Rohár wrote: > > On Tuesday 02 November 2021 18:12:58 Pali Rohár wrote: > > > - The code relies on rc_pci_fixup being called, which only happens > > > when CONFIG_PCI_QUIRKS is enabled, so add that to Kconfig. Omitting > > > this causes a booting failure with a non-obvious cause. > > > - Update rc_pci_fixup to set the class properly, copying the > > > more modern style from other places > > > - Correct the rc_pci_fixup comment > > > > > > This patch just re-applies commit 1dc831bf53fd ("ARM: Kirkwood: Update > > > PCI-E fixup") for all other Marvell ARM platforms which have same buggy > > > PCIe controller and do not use pci-mvebu.c controller driver yet. > > > > > > Long-term goal for these Marvell ARM platforms should be conversion to > > > pci-mvebu.c controller driver and removal of these fixups in arch code. > > > > > > Signed-off-by: Pali Rohár > > > Cc: Jason Gunthorpe > > > Cc: stable@vger.kernel.org > > > > Hello! Patch 2/2 was already applied into mips-next. Could you review > > also this patch 1/2? > > PING? > > > > > > > --- > > > Changes in v2: > > > * Move MIPS change into separate patch > > > * Add information that this patch is for platforms which do not use pci-mvebu.c > > > --- > > > arch/arm/Kconfig | 1 + > > > arch/arm/mach-dove/pcie.c | 11 ++++++++--- > > > arch/arm/mach-mv78xx0/pcie.c | 11 ++++++++--- > > > arch/arm/mach-orion5x/Kconfig | 1 + > > > arch/arm/mach-orion5x/pci.c | 12 +++++++++--- > > > 5 files changed, 27 insertions(+), 9 deletions(-) > > > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > > index fc196421b2ce..9f157e973555 100644 > > > --- a/arch/arm/Kconfig > > > +++ b/arch/arm/Kconfig > > > @@ -400,6 +400,7 @@ config ARCH_DOVE > > > select GENERIC_IRQ_MULTI_HANDLER > > > select GPIOLIB > > > select HAVE_PCI > > > + select PCI_QUIRKS if PCI > > > select MVEBU_MBUS > > > select PINCTRL > > > select PINCTRL_DOVE > > > diff --git a/arch/arm/mach-dove/pcie.c b/arch/arm/mach-dove/pcie.c > > > index ee91ac6b5ebf..ecf057a0f5ba 100644 > > > --- a/arch/arm/mach-dove/pcie.c > > > +++ b/arch/arm/mach-dove/pcie.c > > > @@ -135,14 +135,19 @@ static struct pci_ops pcie_ops = { > > > .write = pcie_wr_conf, > > > }; > > > > > > +/* > > > + * The root complex has a hardwired class of PCI_CLASS_MEMORY_OTHER, when it > > > + * is operating as a root complex this needs to be switched to > > > + * PCI_CLASS_BRIDGE_HOST or Linux will errantly try to process the BAR's on > > > + * the device. Decoding setup is handled by the orion code. > > > + */ > > > static void rc_pci_fixup(struct pci_dev *dev) > > > { > > > - /* > > > - * Prevent enumeration of root complex. > > > - */ > > > if (dev->bus->parent == NULL && dev->devfn == 0) { > > > int i; > > > > > > + dev->class &= 0xff; > > > + dev->class |= PCI_CLASS_BRIDGE_HOST << 8; > > > for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { > > > dev->resource[i].start = 0; > > > dev->resource[i].end = 0; > > > diff --git a/arch/arm/mach-mv78xx0/pcie.c b/arch/arm/mach-mv78xx0/pcie.c > > > index 636d84b40466..9362b5fc116f 100644 > > > --- a/arch/arm/mach-mv78xx0/pcie.c > > > +++ b/arch/arm/mach-mv78xx0/pcie.c > > > @@ -177,14 +177,19 @@ static struct pci_ops pcie_ops = { > > > .write = pcie_wr_conf, > > > }; > > > > > > +/* > > > + * The root complex has a hardwired class of PCI_CLASS_MEMORY_OTHER, when it > > > + * is operating as a root complex this needs to be switched to > > > + * PCI_CLASS_BRIDGE_HOST or Linux will errantly try to process the BAR's on > > > + * the device. Decoding setup is handled by the orion code. > > > + */ > > > static void rc_pci_fixup(struct pci_dev *dev) > > > { > > > - /* > > > - * Prevent enumeration of root complex. > > > - */ > > > if (dev->bus->parent == NULL && dev->devfn == 0) { > > > int i; > > > > > > + dev->class &= 0xff; > > > + dev->class |= PCI_CLASS_BRIDGE_HOST << 8; > > > for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { > > > dev->resource[i].start = 0; > > > dev->resource[i].end = 0; > > > diff --git a/arch/arm/mach-orion5x/Kconfig b/arch/arm/mach-orion5x/Kconfig > > > index e94a61901ffd..7189a5b1ec46 100644 > > > --- a/arch/arm/mach-orion5x/Kconfig > > > +++ b/arch/arm/mach-orion5x/Kconfig > > > @@ -6,6 +6,7 @@ menuconfig ARCH_ORION5X > > > select GPIOLIB > > > select MVEBU_MBUS > > > select FORCE_PCI > > > + select PCI_QUIRKS > > > select PHYLIB if NETDEVICES > > > select PLAT_ORION_LEGACY > > > help > > > diff --git a/arch/arm/mach-orion5x/pci.c b/arch/arm/mach-orion5x/pci.c > > > index 76951bfbacf5..5145fe89702e 100644 > > > --- a/arch/arm/mach-orion5x/pci.c > > > +++ b/arch/arm/mach-orion5x/pci.c > > > @@ -509,14 +509,20 @@ static int __init pci_setup(struct pci_sys_data *sys) > > > /***************************************************************************** > > > * General PCIe + PCI > > > ****************************************************************************/ > > > + > > > +/* > > > + * The root complex has a hardwired class of PCI_CLASS_MEMORY_OTHER, when it > > > + * is operating as a root complex this needs to be switched to > > > + * PCI_CLASS_BRIDGE_HOST or Linux will errantly try to process the BAR's on > > > + * the device. Decoding setup is handled by the orion code. > > > + */ > > > static void rc_pci_fixup(struct pci_dev *dev) > > > { > > > - /* > > > - * Prevent enumeration of root complex. > > > - */ > > > if (dev->bus->parent == NULL && dev->devfn == 0) { > > > int i; > > > > > > + dev->class &= 0xff; > > > + dev->class |= PCI_CLASS_BRIDGE_HOST << 8; > > > for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { > > > dev->resource[i].start = 0; > > > dev->resource[i].end = 0; > > > -- > > > 2.20.1 > > >