From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: "Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Vinod Koul" <vkoul@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 22/24] dmaengine: dw-edma: Bypass dma-ranges mapping for the local setup
Date: Sat, 9 Jul 2022 14:01:22 +0530 [thread overview]
Message-ID: <20220709083122.GQ5063@thinkpad> (raw)
In-Reply-To: <20220610091459.17612-23-Sergey.Semin@baikalelectronics.ru>
On Fri, Jun 10, 2022 at 12:14:57PM +0300, Serge Semin wrote:
> DW eDMA doesn't perform any translation of the traffic generated on the
> CPU/Application side. It just generates read/write AXI-bus requests with
> the specified addresses. But in case if the dma-ranges DT-property is
> specified for a platform device node, Linux will use it to map the CPU
> memory regions into the DMAable bus ranges. This isn't what we want for
> the eDMA embedded into the locally accessed DW PCIe Root Port and
> End-point. In order to work that around let's set the chan_dma_dev flag
> for each DW eDMA channel thus forcing the client drivers to getting a
> custom dma-ranges-less parental device for the mappings.
>
> Note it will only work for the client drivers using the
> dmaengine_get_dma_device() method to get the parental DMA device.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
>
> ---
>
> Changelog v2:
> - Fix the comment a bit to being clearer. (@Manivannan)
>
> Changelog v3:
> - Conditionally set dchan->dev->device.dma_coherent field since it can
> be missing on some platforms. (@Manivannan)
> - Remove Manivannan' rb and tb tags since the patch content has been
> changed.
> ---
> drivers/dma/dw-edma/dw-edma-core.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index 6a8282eaebaf..4f56149dc8d8 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
> @@ -716,6 +716,26 @@ static int dw_edma_alloc_chan_resources(struct dma_chan *dchan)
> if (chan->status != EDMA_ST_IDLE)
> return -EBUSY;
>
> + /* Bypass the dma-ranges based memory regions mapping for the eDMA
> + * controlled from the CPU/Application side since in that case
> + * the local memory address is left untranslated.
> + */
> + if (chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL) {
> + dchan->dev->chan_dma_dev = true;
> +
> +#if defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_DEVICE) || \
> + defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU) || \
> + defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL)
> + dchan->dev->device.dma_coherent = chan->dw->chip->dev->dma_coherent;
> +#endif
> +
> + dma_coerce_mask_and_coherent(&dchan->dev->device,
> + dma_get_mask(chan->dw->chip->dev));
> + dchan->dev->device.dma_parms = chan->dw->chip->dev->dma_parms;
> + } else {
> + dchan->dev->chan_dma_dev = false;
> + }
> +
> pm_runtime_get(chan->dw->chip->dev);
>
> return 0;
> --
> 2.35.1
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-07-09 8:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 9:14 [PATCH v3 00/24] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2022-06-10 9:14 ` [PATCH v3 01/24] dmaengine: Fix dma_slave_config.dst_addr description Serge Semin
2022-06-10 9:14 ` [PATCH v3 02/24] dmaengine: dw-edma: Release requested IRQs on failure Serge Semin
2022-06-10 9:14 ` [PATCH v3 03/24] dmaengine: dw-edma: Convert ll/dt phys-address to PCIe bus/DMA address Serge Semin
2022-06-10 9:14 ` [PATCH v3 04/24] dmaengine: dw-edma: Fix missing src/dst address of the interleaved xfers Serge Semin
2022-06-10 9:14 ` [PATCH v3 05/24] dmaengine: dw-edma: Don't permit non-inc " Serge Semin
2022-06-10 9:14 ` [PATCH v3 06/24] dmaengine: dw-edma: Fix invalid interleaved xfers semantics Serge Semin
2022-06-10 9:14 ` [PATCH v3 07/24] dmaengine: dw-edma: Add CPU to PCIe bus address translation Serge Semin
2022-06-10 9:14 ` [PATCH v3 08/24] dmaengine: dw-edma: Add PCIe bus address getter to the remote EP glue-driver Serge Semin
2022-06-10 9:14 ` [PATCH v3 09/24] dmaengine: dw-edma: Drop chancnt initialization Serge Semin
2022-06-10 9:14 ` [PATCH v3 10/24] dmaengine: dw-edma: Fix DebugFS reg entry type Serge Semin
2022-06-10 9:14 ` [PATCH v3 11/24] dmaengine: dw-edma: Stop checking debugfs_create_*() return value Serge Semin
2022-06-10 9:14 ` [PATCH v3 12/24] dmaengine: dw-edma: Add dw_edma prefix to the DebugFS nodes descriptor Serge Semin
2022-06-10 9:14 ` [PATCH v3 13/24] dmaengine: dw-edma: Convert DebugFS descs to being kz-allocated Serge Semin
2022-06-10 9:14 ` [PATCH v3 14/24] dmaengine: dw-edma: Rename DebugFS dentry variables to 'dent' Serge Semin
2022-06-10 9:14 ` [PATCH v3 15/24] dmaengine: dw-edma: Simplify the DebugFS context CSRs init procedure Serge Semin
2022-06-10 9:14 ` [PATCH v3 16/24] dmaengine: dw-edma: Move eDMA data pointer to DebugFS node descriptor Serge Semin
2022-06-10 9:14 ` [PATCH v3 17/24] dmaengine: dw-edma: Join Write/Read channels into a single device Serge Semin
2022-06-10 9:14 ` [PATCH v3 18/24] dmaengine: dw-edma: Use DMA-engine device DebugFS subdirectory Serge Semin
2022-06-10 9:14 ` [PATCH v3 19/24] dmaengine: dw-edma: Use non-atomic io-64 methods Serge Semin
2022-07-06 5:42 ` Yoshihiro Shimoda
2022-07-06 14:28 ` [EXT] " Frank Li
2022-07-07 0:35 ` Yoshihiro Shimoda
2022-06-10 9:14 ` [PATCH v3 20/24] dmaengine: dw-edma: Drop DT-region allocation Serge Semin
2022-06-10 9:14 ` [PATCH v3 21/24] dmaengine: dw-edma: Replace chip ID number with device name Serge Semin
2022-06-10 9:14 ` [PATCH v3 22/24] dmaengine: dw-edma: Bypass dma-ranges mapping for the local setup Serge Semin
2022-07-09 8:31 ` Manivannan Sadhasivam [this message]
2022-06-10 9:14 ` [PATCH v3 23/24] dmaengine: dw-edma: Skip cleanup procedure if no private data found Serge Semin
2022-06-10 9:14 ` [PATCH v3 24/24] PCI: dwc: Add DW eDMA engine support Serge Semin
2022-07-09 8:36 ` Manivannan Sadhasivam
2022-06-10 9:21 ` [PATCH v3 00/24] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2022-07-11 14:45 ` Manivannan Sadhasivam
2022-07-11 14:49 ` Manivannan Sadhasivam
2022-07-11 15:39 ` Serge Semin
2022-07-21 12:16 ` Vinod Koul
2022-07-28 11:33 ` Serge Semin
2022-07-28 12:48 ` Vinod Koul
2022-07-28 14:17 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220709083122.GQ5063@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Frank.Li@nxp.com \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).