From: Vidya Sagar <vidyas@nvidia.com>
To: <bhelgaas@google.com>, <lpieralisi@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<jingoohan1@gmail.com>, <gustavo.pimentel@synopsys.com>
Cc: <kw@linux.com>, <kishon@ti.com>, <linux-pci@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kthota@nvidia.com>,
<mmaddireddy@nvidia.com>, <vidyas@nvidia.com>,
<sagar.tv@gmail.com>
Subject: [PATCH V5 0/9] PCI: tegra: Add Tegra234 PCIe support
Date: Wed, 13 Jul 2022 14:30:20 +0530 [thread overview]
Message-ID: <20220713090029.30395-1-vidyas@nvidia.com> (raw)
Tegra234 has a total of 11 PCIe controllers based on Synopsys DesignWare core.
There are three Universal PHY (UPHY) blocks (viz. HSIO, NVHS and GBE) with
each block supporting 8 lanes respectively. Controllers:0~4 use UPHY lanes
from HSIO block, Controllers:5,6 use UPHY lanes from NVHS block and
Controllers:7~10 use UPHY lanes from GBE block. Lane mapping in each block
is controlled in XBAR module by BPMP-FW. Since PCIe core has PIPE interface,
a glue module called PIPE-to-UPHY (P2U) is used to connect each UPHY lane
(applicable to all three UPHY bricks i.e. HSIO/NVHS/GBE) to PCIe controller.
All the controllers can operate in the RootPort mode where as only controllers
C5, C6, C7 and C10 can operate in the EndPoint mode.
This patch series
- Adds support for Tegra234 in the existing P2U PHY driver
- Adds support for Tegra234 in the existing PCIe platform controller driver
- Adds device tree nodes for all PCIe controllers
- Enables nodes applicable to P3737-0000 platform
Testing done on P3737-0000 platform
- PCIe link is up with on-board Broadcom WiFi controller
- PCIe link is up with an NVMe drive connected to M.2 Key-M slot and its
functionality is verified
- PCIe link is up with a variety of cards (NICs and USB3.0 add-on cards)
connected to CEM slot and their functionality is verified
- PCIe link is up with C5 controller configured for the endpoint mode with
a host
V5:
* Addressed review comments from Rob
V4:
* Addressed review comments from Krzysztof and Rob
* Changes are only in schema files and regulator patch
* Dropped PHY related patches as they are already accepted
V3:
* Add DT nodes for the controllers that can work in the EndPoint mode
* Converted the existing device-tree binding documentation from .txt to .yaml
* Add T234 specific information to the RP and EP .yaml documentation files
* Added regulators required to power up required power rails
V2:
* Dropped 3 patches that add clocks & resets IDs, power-domain IDs and
memory IDs for PCIe controllers as the patches are already available
in linux-next
* Based on Bjorn's review comment, reverted the commit b57256918399 ("PCI:
tegra194: Rename tegra_pcie_dw to tegra194_pcie") and pushed it as a
separate patch before adding support for T234 in the existing driver
* Addressed review comments from Rob for the other changes
Vidya Sagar (9):
dt-bindings: pci: tegra: Convert to json-schema
dt-bindings: PCI: tegra234: Add schema for tegra234 rootport mode
dt-bindings: PCI: tegra234: Add schema for tegra234 endpoint mode
arm64: tegra: Add regulators required for PCIe
arm64: tegra: Add P2U and PCIe controller nodes to Tegra234 DT
arm64: tegra: Enable PCIe slots in P3737-0000 board
PCI: Disable MSI for Tegra234 root ports
Revert "PCI: tegra194: Rename tegra_pcie_dw to tegra194_pcie"
PCI: tegra: Add Tegra234 PCIe support
.../bindings/pci/nvidia,tegra194-pcie-ep.yaml | 318 ++++++
.../bindings/pci/nvidia,tegra194-pcie.txt | 245 -----
.../bindings/pci/nvidia,tegra194-pcie.yaml | 349 +++++++
.../devicetree/bindings/pci/snps,dw-pcie.yaml | 4 +-
.../boot/dts/nvidia/tegra234-p3701-0000.dtsi | 36 +
.../nvidia/tegra234-p3737-0000+p3701-0000.dts | 51 +
arch/arm64/boot/dts/nvidia/tegra234.dtsi | 927 ++++++++++++++++++
drivers/pci/controller/dwc/pcie-tegra194.c | 622 ++++++++----
drivers/pci/quirks.c | 13 +-
9 files changed, 2118 insertions(+), 447 deletions(-)
create mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
delete mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt
create mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
--
2.34.1
next reply other threads:[~2022-07-13 9:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 9:00 Vidya Sagar [this message]
2022-07-13 9:00 ` [PATCH V5 1/9] dt-bindings: pci: tegra: Convert to json-schema Vidya Sagar
2022-07-13 9:00 ` [PATCH V5 2/9] dt-bindings: PCI: tegra234: Add schema for tegra234 rootport mode Vidya Sagar
2022-07-18 20:49 ` Rob Herring
2022-07-13 9:00 ` [PATCH V5 3/9] dt-bindings: PCI: tegra234: Add schema for tegra234 endpoint mode Vidya Sagar
2022-07-18 20:49 ` Rob Herring
2022-07-13 9:00 ` [PATCH V5 4/9] arm64: tegra: Add regulators required for PCIe Vidya Sagar
2022-07-13 9:00 ` [PATCH V5 5/9] arm64: tegra: Add P2U and PCIe controller nodes to Tegra234 DT Vidya Sagar
2022-07-13 9:00 ` [PATCH V5 6/9] arm64: tegra: Enable PCIe slots in P3737-0000 board Vidya Sagar
2022-07-13 9:00 ` [PATCH V5 7/9] PCI: Disable MSI for Tegra234 root ports Vidya Sagar
2022-07-13 9:00 ` [PATCH V5 8/9] Revert "PCI: tegra194: Rename tegra_pcie_dw to tegra194_pcie" Vidya Sagar
2022-07-13 9:00 ` [PATCH V5 9/9] PCI: tegra: Add Tegra234 PCIe support Vidya Sagar
2022-07-13 21:17 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713090029.30395-1-vidyas@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kthota@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).