From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F12C43334 for ; Tue, 19 Jul 2022 14:36:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239219AbiGSOgL (ORCPT ); Tue, 19 Jul 2022 10:36:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239240AbiGSOfW (ORCPT ); Tue, 19 Jul 2022 10:35:22 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6748B2BE7; Tue, 19 Jul 2022 07:27:52 -0700 (PDT) Received: from fraeml713-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LnLfH174Rz67xNR; Tue, 19 Jul 2022 22:23:19 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml713-chm.china.huawei.com (10.206.15.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 19 Jul 2022 16:27:50 +0200 Received: from localhost (10.81.209.49) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 19 Jul 2022 15:27:49 +0100 Date: Tue, 19 Jul 2022 15:27:47 +0100 From: Jonathan Cameron To: Dan Williams CC: , , , , , Subject: Re: [PATCH 17/46] cxl/hdm: Track next decoder to allocate Message-ID: <20220719152747.00001fad@Huawei.com> In-Reply-To: <62ca4da570a4e_3177ca294eb@dwillia2-xfh.notmuch> References: <165603869943.551046.3498980330327696732.stgit@dwillia2-xfh> <165603882752.551046.12620934370518380800.stgit@dwillia2-xfh> <20220629163102.000016c4@Huawei.com> <62ca4da570a4e_3177ca294eb@dwillia2-xfh.notmuch> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.81.209.49] X-ClientProxiedBy: lhreml749-chm.china.huawei.com (10.201.108.199) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sat, 9 Jul 2022 20:55:17 -0700 Dan Williams wrote: > Jonathan Cameron wrote: > > On Thu, 23 Jun 2022 19:47:07 -0700 > > Dan Williams wrote: > > > > > The CXL specification enforces that endpoint decoders are committed in > > > hw instance id order. In preparation for adding dynamic DPA allocation, > > > record the hw instance id in endpoint decoders, and enforce allocations > > > to occur in hw instance id order. > > > > > > Signed-off-by: Dan Williams > > > > dpa_end isn't a good name given the value isn't a Device Physical Address. > > > > Otherwise looks fine, > > > > Jonathan > > > > > --- > > > drivers/cxl/core/hdm.c | 14 ++++++++++++++ > > > drivers/cxl/core/port.c | 1 + > > > drivers/cxl/cxl.h | 2 ++ > > > 3 files changed, 17 insertions(+) > > > > > > diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c > > > index 3f929231b822..8805afe63ebf 100644 > > > --- a/drivers/cxl/core/hdm.c > > > +++ b/drivers/cxl/core/hdm.c > > > @@ -153,6 +153,7 @@ static void __cxl_dpa_release(struct cxl_endpoint_decoder *cxled, bool remove_ac > > > cxled->skip = 0; > > > __release_region(&cxlds->dpa_res, res->start, resource_size(res)); > > > cxled->dpa_res = NULL; > > > + port->dpa_end--; > > > } > > > > > > static void cxl_dpa_release(void *cxled) > > > @@ -183,6 +184,18 @@ static int __cxl_dpa_reserve(struct cxl_endpoint_decoder *cxled, > > > return -EBUSY; > > > } > > > > > > + if (port->dpa_end + 1 != cxled->cxld.id) { > > > + /* > > > + * Assumes alloc and commit order is always in hardware instance > > > + * order per expectations from 8.2.5.12.20 Committing Decoder > > > + * Programming that enforce decoder[m] committed before > > > + * decoder[m+1] commit start. > > > + */ > > > + dev_dbg(dev, "decoder%d.%d: expected decoder%d.%d\n", port->id, > > > + cxled->cxld.id, port->id, port->dpa_end + 1); > > > + return -EBUSY; > > > + } > > > + > > > if (skip) { > > > res = __request_region(&cxlds->dpa_res, base - skip, skip, > > > dev_name(dev), 0); > > > @@ -213,6 +226,7 @@ static int __cxl_dpa_reserve(struct cxl_endpoint_decoder *cxled, > > > cxled->cxld.id, cxled->dpa_res); > > > cxled->mode = CXL_DECODER_MIXED; > > > } > > > + port->dpa_end++; > > > > > > return 0; > > > } > > > diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c > > > index 9d632c8c580b..54bf032cbcb7 100644 > > > --- a/drivers/cxl/core/port.c > > > +++ b/drivers/cxl/core/port.c > > > @@ -485,6 +485,7 @@ static struct cxl_port *cxl_port_alloc(struct device *uport, > > > port->uport = uport; > > > port->component_reg_phys = component_reg_phys; > > > ida_init(&port->decoder_ida); > > > + port->dpa_end = -1; > > > INIT_LIST_HEAD(&port->dports); > > > INIT_LIST_HEAD(&port->endpoints); > > > > > > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h > > > index aa223166f7ef..d8edbdaa6208 100644 > > > --- a/drivers/cxl/cxl.h > > > +++ b/drivers/cxl/cxl.h > > > @@ -326,6 +326,7 @@ struct cxl_nvdimm { > > > * @dports: cxl_dport instances referenced by decoders > > > * @endpoints: cxl_ep instances, endpoints that are a descendant of this port > > > * @decoder_ida: allocator for decoder ids > > > + * @dpa_end: cursor to track highest allocated decoder for allocation ordering > > > > dpa_end not a good name as this isn't a Device Physical Address. > > Ok, renamed it to 'hdm_end'. Suitable to add "Reviewed-by" now? Reviewed-by: Jonathan Cameron Though I'll probably catch up with a later version when I've gotten through more of my email and add it there as well so you don't have to add it manually. Thanks, J