From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA8DFC43334 for ; Thu, 21 Jul 2022 10:08:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233040AbiGUKIE (ORCPT ); Thu, 21 Jul 2022 06:08:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232939AbiGUKIE (ORCPT ); Thu, 21 Jul 2022 06:08:04 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99F57691D2 for ; Thu, 21 Jul 2022 03:08:03 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id s206so1235735pgs.3 for ; Thu, 21 Jul 2022 03:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=a9YjzXGdq5669WOd8WnAMplMXRiXL/2vmSMeSJuFMgI=; b=bghQzs4KeeC3qf2IwPpeOjfcv8rcRJmxobbTEu1b1LgfoUir1gN0ploWyqiZ/dgsb2 LjQ5wAhxQocOojaMFuJEIvWhUQLwUTD05e1KfQb0bwQC+dNjhgEO0YmTNHcM3wpsT875 YFwKCNI/iOvGie/4whVieQ7k2Czb7Gspx3QastMBjK+R6oOaGw1PbGPpwNxmK+nrAn71 yUEFqXwdGQYxrE4n66E8fGNcd0qdnzYz8g04XTx61zKpEQRedqNajeYwAiEyuWXFaXnR nzFsOsg59s2s5mgufW2dwdmktIUBQOa1ngBaXh5fKi+hzzQ57DYS/gik7KPpgltoD+HR ItrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=a9YjzXGdq5669WOd8WnAMplMXRiXL/2vmSMeSJuFMgI=; b=ERUnq93cwgGlFMg9s3tnnjt1SEuHKYZm2F2YwofcpdZavANgPo6ZGxevxrPJvrx8rn klOxQiZun1pA1nUIePhdp2I2NcU4N7nYtIE3hWcKFMs5IwTshu7c6bKWHVfUXQXEO4UI asXpy61b0agYtnur1/vxPvtPCyqehPEKvXX6wlvqCDgWJksQ79aehEKr4uFDxWkH6sm0 7+fUzqtPpM2HcRMa0LViGJNjLCj7tnoLVdbOgFmjPP26CstGAfpKlJQHYBr6umvoC0kF hY7A1GOX5nJjRmM071iBYmwKFsNjEkNZgK5in28LRBebx/5dWswFG9XTrco5Lm3jM2jH rRKw== X-Gm-Message-State: AJIora+e8LvsRrvHrkAGT2ODtfeee79sJp3e6fQbFode55HW/I9t4wp1 5UZofv5CFK11sqOR8sSjovLUf/823CkY X-Google-Smtp-Source: AGRyM1sEfVv500oMdF2vFfQRbAZm/PaTgquheMbdnclqX3E0EU7EPtOQjMjqRA0wgnuh4pIx0FcawQ== X-Received: by 2002:a63:5b5e:0:b0:41a:5e8f:b127 with SMTP id l30-20020a635b5e000000b0041a5e8fb127mr7727534pgm.104.1658398083074; Thu, 21 Jul 2022 03:08:03 -0700 (PDT) Received: from thinkpad ([117.217.186.184]) by smtp.gmail.com with ESMTPSA id x1-20020aa79561000000b00528c26c84a3sm1293525pfq.64.2022.07.21.03.07.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 03:08:02 -0700 (PDT) Date: Thu, 21 Jul 2022 15:37:56 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov , y@thinkpad Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Johan Hovold , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [RFC PATCH 4/4] PCI: qcom-ep: call phy_set_mode_ext() Message-ID: <20220721100756.GD39125@thinkpad> References: <20220719200626.976084-1-dmitry.baryshkov@linaro.org> <20220719200626.976084-5-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220719200626.976084-5-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Subject could be, "PCI: qcom: Set PHY in RC mode" On Tue, Jul 19, 2022 at 11:06:26PM +0300, Dmitry Baryshkov wrote: > Call phy_set_mode_ext() to notify the PHY driver that the PHY is being > used in the EP mode. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c > index ec99116ad05c..11f887a2f7c4 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > @@ -240,6 +240,10 @@ static int qcom_pcie_enable_resources(struct qcom_pcie_ep *pcie_ep) > if (ret) > goto err_disable_clk; > > + ret = phy_set_mode_ext(pcie->phy, PHY_MODE_PCIE, 1); > + if (ret) > + goto err_phy_exit; > + > ret = phy_power_on(pcie_ep->phy); > if (ret) > goto err_phy_exit; > -- > 2.35.1 > -- மணிவண்ணன் சதாசிவம்