From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Jingoo Han <jingoohan1@gmail.com>, Frank Li <Frank.Li@nxp.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Serge Semin" <Sergey.Semin@baikalelectronics.ru>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 23/24] dmaengine: dw-edma: Skip cleanup procedure if no private data found
Date: Thu, 28 Jul 2022 17:28:40 +0300 [thread overview]
Message-ID: <20220728142841.12305-24-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20220728142841.12305-1-Sergey.Semin@baikalelectronics.ru>
DW eDMA driver private data is preserved in the passed DW eDMA chip info
structure. If either probe procedure failed or for some reason the passed
info object doesn't have private data pointer initialized we need to halt
the DMA device cleanup procedure in order to prevent possible system
crashes.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-By: Vinod Koul <vkoul@kernel.org>
---
drivers/dma/dw-edma/dw-edma-core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 4f56149dc8d8..5736a537f4c8 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -1040,6 +1040,10 @@ int dw_edma_remove(struct dw_edma_chip *chip)
struct dw_edma *dw = chip->dw;
int i;
+ /* Skip removal if no private data found */
+ if (!dw)
+ return -ENODEV;
+
/* Disable eDMA */
dw_edma_v0_core_off(dw);
--
2.35.1
next prev parent reply other threads:[~2022-07-28 14:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 14:28 [PATCH v4 00/24] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2022-07-28 14:28 ` [PATCH v4 01/24] dmaengine: Fix dma_slave_config.dst_addr description Serge Semin
2022-07-28 14:28 ` [PATCH v4 02/24] dmaengine: dw-edma: Release requested IRQs on failure Serge Semin
2022-07-28 14:28 ` [PATCH v4 03/24] dmaengine: dw-edma: Convert ll/dt phys-address to PCIe bus/DMA address Serge Semin
2022-07-28 14:28 ` [PATCH v4 04/24] dmaengine: dw-edma: Fix missing src/dst address of the interleaved xfers Serge Semin
2022-07-28 14:28 ` [PATCH v4 05/24] dmaengine: dw-edma: Don't permit non-inc " Serge Semin
2022-07-28 14:28 ` [PATCH v4 06/24] dmaengine: dw-edma: Fix invalid interleaved xfers semantics Serge Semin
2022-07-28 14:28 ` [PATCH v4 07/24] dmaengine: dw-edma: Add CPU to PCIe bus address translation Serge Semin
2022-07-28 14:28 ` [PATCH v4 08/24] dmaengine: dw-edma: Add PCIe bus address getter to the remote EP glue-driver Serge Semin
2022-07-28 14:28 ` [PATCH v4 09/24] dmaengine: dw-edma: Drop chancnt initialization Serge Semin
2022-07-28 14:28 ` [PATCH v4 10/24] dmaengine: dw-edma: Fix DebugFS reg entry type Serge Semin
2022-07-28 14:28 ` [PATCH v4 11/24] dmaengine: dw-edma: Stop checking debugfs_create_*() return value Serge Semin
2022-07-28 14:28 ` [PATCH v4 12/24] dmaengine: dw-edma: Add dw_edma prefix to the DebugFS nodes descriptor Serge Semin
2022-07-28 14:28 ` [PATCH v4 13/24] dmaengine: dw-edma: Convert DebugFS descs to being kz-allocated Serge Semin
2022-07-28 14:28 ` [PATCH v4 14/24] dmaengine: dw-edma: Rename DebugFS dentry variables to 'dent' Serge Semin
2022-07-28 14:28 ` [PATCH v4 15/24] dmaengine: dw-edma: Simplify the DebugFS context CSRs init procedure Serge Semin
2022-07-28 14:28 ` [PATCH v4 16/24] dmaengine: dw-edma: Move eDMA data pointer to DebugFS node descriptor Serge Semin
2022-07-28 14:28 ` [PATCH v4 17/24] dmaengine: dw-edma: Join Write/Read channels into a single device Serge Semin
2022-07-28 14:28 ` [PATCH v4 18/24] dmaengine: dw-edma: Use DMA-engine device DebugFS subdirectory Serge Semin
2022-07-28 14:28 ` [PATCH v4 19/24] dmaengine: dw-edma: Use non-atomic io-64 methods Serge Semin
2022-07-28 14:28 ` [PATCH v4 20/24] dmaengine: dw-edma: Drop DT-region allocation Serge Semin
2022-07-28 14:28 ` [PATCH v4 21/24] dmaengine: dw-edma: Replace chip ID number with device name Serge Semin
2022-07-28 14:28 ` [PATCH v4 22/24] dmaengine: dw-edma: Bypass dma-ranges mapping for the local setup Serge Semin
2022-07-28 14:28 ` Serge Semin [this message]
2022-07-28 14:28 ` [PATCH v4 24/24] PCI: dwc: Add DW eDMA engine support Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728142841.12305-24-Sergey.Semin@baikalelectronics.ru \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Frank.Li@nxp.com \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).