From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B84CC38145 for ; Wed, 24 Aug 2022 15:07:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238106AbiHXPHM (ORCPT ); Wed, 24 Aug 2022 11:07:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237980AbiHXPHK (ORCPT ); Wed, 24 Aug 2022 11:07:10 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF8D88C003 for ; Wed, 24 Aug 2022 08:07:08 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id w29so11197367pfj.3 for ; Wed, 24 Aug 2022 08:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc; bh=en5fJioWb1/tYEyOYyeymC+F2mSt5gCOg/3YQO22W/s=; b=kmCU1wRgOodNOCpDQZjRxGbuZn9IFI1hLbQdaa4sSq5wQ9RROkfwkRrG/Rp/8n83lb rc00wtM8LXLy9/SA2AIkJwV5ORHesIwyVxoK5HRzXziJETcKR23ORwxKipF1UGglYVpm mL1HEdU4h9uiX6F5dhtaz1Ni7e2FB/ZzORfCWPJKyrp4dlBaRfG4dXQdoEmS0VxSicRm Yyzdmn3iMplldGN2NooCN8di1J1LMBoBfuwEf+bmtdbZiXqgiGqWVkxSVAUzfVINE4z9 /T6JsvjbjCVTszRlwuHZnaLWOX0s1uxD2ksoNU5+bez5Utccbtx+QyHUtlnMZq1tMbx7 OLkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=en5fJioWb1/tYEyOYyeymC+F2mSt5gCOg/3YQO22W/s=; b=ZniUTxCnx3fJncKAvxK6hBVkECyIPBAty24EF/zqrPx1nKGa/3i2vU6xMjY2ItF+Y3 NJ0UBf8aP4xj9nFvX+DHFETlT1FMktGm77N4ctdX/5tv+xl/yVCrZi7fPeaXGtFGuuEV FdTRz0eBhxuKGau/pOZ+/iVSCwcf6p9FugMoLsmBMQdjCMnL64ReqOgzauMJRJEbmKa8 c15CRDIrj63Ezx4Lh5wxIV2F3QbAN519EJLLMg8DPoJVkwkyif8SXc0QzLbqhEklTw8r +S1yVSua6xmhJ0ldu/Z0zKaoNntiEnFXOTYgONvS8lJk5pMYgQQj84BTJVTMXnQwtg7a 2WWg== X-Gm-Message-State: ACgBeo3wmv0UiE6QjkwCt+Mt+lNnZJFmCRlP7BMC2kHh9sGbc936Vdx8 EXEGKkX7f2bT/EEFzwLXx25A X-Google-Smtp-Source: AA6agR4I9qbzYAiGbI+cKiSPz6vV8dLS8BKWrwUL0WyVPYcNCgprOjlUILqDhdnHLbLF43532+mQ7w== X-Received: by 2002:a65:6cc7:0:b0:42a:4d40:8dc1 with SMTP id g7-20020a656cc7000000b0042a4d408dc1mr19894592pgw.321.1661353628331; Wed, 24 Aug 2022 08:07:08 -0700 (PDT) Received: from thinkpad ([117.207.24.28]) by smtp.gmail.com with ESMTPSA id q4-20020aa79604000000b005367a03d566sm7673082pfg.112.2022.08.24.08.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 08:07:07 -0700 (PDT) Date: Wed, 24 Aug 2022 20:36:58 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Johan Hovold , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH v1 3/4] PCI: qcom: Setup PHY to work in RC mode Message-ID: <20220824150658.GG4767@thinkpad> References: <20220726203401.595934-1-dmitry.baryshkov@linaro.org> <20220726203401.595934-4-dmitry.baryshkov@linaro.org> <20220824145748.GF4767@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220824145748.GF4767@thinkpad> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Aug 24, 2022 at 08:27:58PM +0530, Manivannan Sadhasivam wrote: > On Tue, Jul 26, 2022 at 11:34:00PM +0300, Dmitry Baryshkov wrote: > > Call phy_set_mode_ext() to notify the PHY driver that the PHY is being > > used in the RC mode. > > > > Signed-off-by: Dmitry Baryshkov > > Reviewed-by: Manivannan Sadhasivam > > Thanks, > Mani > > > --- > > drivers/pci/controller/dwc/pcie-qcom.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > index 93d75cda4b04..f85f2579c087 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > @@ -1485,6 +1485,10 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp) > > if (ret) > > return ret; > > > > + ret = phy_set_mode_ext(pcie->phy, PHY_MODE_PCIE, 0); > > + if (ret) > > + return err_deinit; Oops... Missed this one. Should be goto err_deinit; Thanks, Mani > > + > > ret = phy_power_on(pcie->phy); > > if (ret) > > goto err_deinit; > > -- > > 2.35.1 > > > > -- > மணிவண்ணன் சதாசிவம் -- மணிவண்ணன் சதாசிவம்