From: kernel test robot <lkp@intel.com>
To: Xiaochun Lee <lixiaochun.2888@163.com>,
nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev
Cc: kbuild-all@lists.01.org, lpieralisi@kernel.org, robh@kernel.org,
kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, Xiaochun Lee <lixc17@lenovo.com>
Subject: Re: [PATCH v1] PCI: Set no io resource for bridges that behind VMD controller
Date: Fri, 23 Sep 2022 23:21:29 +0800 [thread overview]
Message-ID: <202209240714.ronvmf1X-lkp@intel.com> (raw)
In-Reply-To: <1663075485-20591-1-git-send-email-lixiaochun.2888@163.com>
Hi Xiaochun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on linus/master v6.0-rc6 next-20220923]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Xiaochun-Lee/PCI-Set-no-io-resource-for-bridges-that-behind-VMD-controller/20220913-213745
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: um-allmodconfig (https://download.01.org/0day-ci/archive/20220924/202209240714.ronvmf1X-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/f97a8ba561d7cf5a755c8f42421138e8b1073cf9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Xiaochun-Lee/PCI-Set-no-io-resource-for-bridges-that-behind-VMD-controller/20220913-213745
git checkout f97a8ba561d7cf5a755c8f42421138e8b1073cf9
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=um SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/pci/quirks.c: In function 'quirk_vmd_no_iosize':
>> drivers/pci/quirks.c:5985:13: error: implicit declaration of function 'is_vmd' [-Werror=implicit-function-declaration]
5985 | if (is_vmd(bridge->bus) && bridge->is_hotplug_bridge) {
| ^~~~~~
cc1: some warnings being treated as errors
vim +/is_vmd +5985 drivers/pci/quirks.c
5959
5960 #if defined(CONFIG_X86_64) || defined(CONFIG_X86)
5961 /*
5962 * VMD-enabled root ports use Enhanced Configuration Access Mechanism (ECAM)
5963 * access PCI Express configuration space, and offer VMD_CFGBAR as
5964 * base of PCI Express configuration space for the bridges behind it.
5965 * The configuration space includes IO resources, but these IO
5966 * resources are not actually used on X86, especially the NVMes as
5967 * device connnected on this hot plug bridges, and it can result
5968 * in BAR#13 assign IO resource failed. So we clear IO resources
5969 * by setting an IO base value greater than limit to these bridges.
5970 * Hence, append kernel parameter "pci=hpiosize=0KB" can avoid
5971 * this BAR#13 failed messages show out.
5972 */
5973 static void quirk_vmd_no_iosize(struct pci_dev *bridge)
5974 {
5975 u8 io_base_lo, io_limit_lo;
5976 u16 io_low;
5977 u32 io_upper16;
5978 unsigned long io_mask, base, limit;
5979
5980 io_mask = PCI_IO_RANGE_MASK;
5981 if (bridge->io_window_1k)
5982 io_mask = PCI_IO_1K_RANGE_MASK;
5983
5984 /* VMD Domain */
> 5985 if (is_vmd(bridge->bus) && bridge->is_hotplug_bridge) {
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-09-23 15:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 13:24 [PATCH v1] PCI: Set no io resource for bridges that behind VMD controller Xiaochun Lee
2022-09-23 15:21 ` kernel test robot [this message]
2022-09-25 9:52 ` [External] " Xiaochun XC17 Li
2022-09-25 12:57 ` Bjorn Helgaas
2022-09-27 2:40 ` Xiaochun XC17 Li
2022-09-27 15:52 ` Bjorn Helgaas
2022-11-11 23:54 ` Bjorn Helgaas
2022-11-16 3:34 ` [External] " Xiaochun XC17 Li
2022-11-16 4:05 ` Bjorn Helgaas
2022-11-16 4:26 ` Xiaochun XC17 Li
2022-11-16 17:42 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209240714.ronvmf1X-lkp@intel.com \
--to=lkp@intel.com \
--cc=bhelgaas@google.com \
--cc=jonathan.derrick@linux.dev \
--cc=kbuild-all@lists.01.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lixc17@lenovo.com \
--cc=lixiaochun.2888@163.com \
--cc=lpieralisi@kernel.org \
--cc=nirmal.patel@linux.intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).