From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org
Cc: "Dan J Williams" <dan.j.williams@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Tony Luck" <tony.luck@intel.com>,
"David E Box" <david.e.box@intel.com>,
"Yunying Sun" <yunying.sun@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Giovanni Cabiddu" <giovanni.cabiddu@intel.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Hans de Goede" <hdegoede@redhat.com>,
"Florent DELAHAYE" <linuxkernelml@undead.fr>,
"Konrad J Hambrick" <kjhambrick@gmail.com>,
"Matt Hansen" <2lprbe78@duck.com>,
"Nicholas Johnson" <nicholas.johnson-opensource@outlook.com.au>,
"Benoit Grégoire" <benoitg@coeus.ca>,
"Werner Sembach" <wse@tuxedocomputers.com>,
mumblingdrunkard@protonmail.com, linux-kernel@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: [PATCH 0/2] PCI: Fix extended config space regression
Date: Tue, 10 Jan 2023 12:02:41 -0600 [thread overview]
Message-ID: <20230110180243.1590045-1-helgaas@kernel.org> (raw)
From: Bjorn Helgaas <bhelgaas@google.com>
07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map") appeared
in v6.2-rc1 and broke extended config space on several machines.
This broke drivers that use things in extended config space, e.g., perf,
VSEC telemetry, EDAC, QAT, etc.
This happened because mmconfig-shared.c checks to see that ECAM space is
reserved in E820 or ACPI motherboard resources. If it's not, it assumes
ECAM doesn't work. 07eab0901ede removed some E820 entries, so it looked
like ECAM was no longer reserved, so we stopped using it.
The machines where this broke don't reserve the ECAM in ACPI PNP0C02
devices (which seems to be what the PCI Firmware spec requires), but they
do mention it in the EFI memory map as EfiMemoryMappedIO.
Bjorn Helgaas (2):
x86/pci: Simplify is_mmconf_reserved() messages
x86/pci: Treat EfiMemoryMappedIO as reservation of ECAM space
arch/x86/pci/mmconfig-shared.c | 44 +++++++++++++++++++++++++++++-----
1 file changed, 38 insertions(+), 6 deletions(-)
--
2.25.1
next reply other threads:[~2023-01-10 18:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 18:02 Bjorn Helgaas [this message]
2023-01-10 18:02 ` [PATCH 1/2] x86/pci: Simplify is_mmconf_reserved() messages Bjorn Helgaas
2023-01-10 18:07 ` Dan Williams
2023-01-10 18:12 ` Bjorn Helgaas
2023-01-10 18:02 ` [PATCH 2/2] x86/pci: Treat EfiMemoryMappedIO as reservation of ECAM space Bjorn Helgaas
2023-01-10 18:15 ` Rafael J. Wysocki
2023-01-10 18:29 ` Dan Williams
2023-01-10 19:30 ` Bjorn Helgaas
2023-10-12 15:33 ` Tomasz Pala
2023-10-16 17:31 ` Tomasz Pala
2023-10-26 20:53 ` Bjorn Helgaas
2023-11-03 19:18 ` Bjorn Helgaas
2023-11-09 18:44 ` Bjorn Helgaas
2023-11-18 14:21 ` Tomasz Pala
2023-11-20 16:29 ` Bjorn Helgaas
2023-11-21 15:24 ` Tomasz Pala
2023-11-21 18:19 ` Bjorn Helgaas
2023-11-08 17:47 ` Bjorn Helgaas
2023-11-08 20:20 ` Bjorn Helgaas
2023-12-06 11:54 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-01-10 20:38 ` [PATCH 0/2] PCI: Fix extended config space regression Liang, Kan
2023-01-10 22:57 ` Luck, Tony
2023-01-11 12:10 ` Giovanni Cabiddu
2023-01-11 22:30 ` Bjorn Helgaas
2023-01-12 5:50 ` Sun, Yunying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110180243.1590045-1-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=2lprbe78@duck.com \
--cc=benoitg@coeus.ca \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david.e.box@intel.com \
--cc=giovanni.cabiddu@intel.com \
--cc=hdegoede@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kan.liang@linux.intel.com \
--cc=kjhambrick@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxkernelml@undead.fr \
--cc=mika.westerberg@linux.intel.com \
--cc=mumblingdrunkard@protonmail.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=tony.luck@intel.com \
--cc=wse@tuxedocomputers.com \
--cc=yunying.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).