archive mirror
 help / color / mirror / Atom feed
From: Lukas Wunner <>
To: Anatoli Antonovitch <>
	Anatoli Antonovitch <>
Subject: Re: [PATCH] PCI/hotplug: Replaced down_write_nested with hotplug_slot_rwsem if ctrl->depth > 0 when taking the ctrl->reset_lock.
Date: Fri, 20 Jan 2023 10:28:24 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Anatoli,

On Fri, Jan 13, 2023 at 12:01:31PM -0500, Anatoli Antonovitch wrote:
> It is to avoid any potential issues when S3 resume but at the same
> time we want to hot-unplug.
> To fix the race between pciehp and AER reported in

I've just submitted an alternative patch to fix this, could you give
it a spin and see if the issue goes away?

That alternative approach is preferable IMO because it also solves the
problem that marking devices as permanently offline isn't possible
concurrently to driver bind/unbind at the moment.  Additionally,
the alternative patch simplifies locking and reduces code size.

Thanks and sorry for my belated response.


  reply	other threads:[~2023-01-20  9:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 17:01 [PATCH] PCI/hotplug: Replaced down_write_nested with hotplug_slot_rwsem if ctrl->depth > 0 when taking the ctrl->reset_lock Anatoli Antonovitch
2023-01-20  9:28 ` Lukas Wunner [this message]
2023-01-20 21:35   ` Anatoli Antonovitch
2023-01-21  7:21     ` Lukas Wunner
2023-01-23 19:30       ` Anatoli Antonovitch
2023-02-13 14:59         ` Anatoli Antonovitch
2023-02-17 16:03           ` Bjorn Helgaas
2023-02-17 18:37             ` Deucher, Alexander
2023-02-19 20:21               ` Lukas Wunner
2023-04-10 20:36                 ` Anatoli Antonovitch
  -- strict thread matches above, loose matches on Subject: below --
2023-01-05 18:43 Anatoli Antonovitch
2023-01-05 19:18 ` Bjorn Helgaas
     [not found]   ` <>
2023-01-16 18:37     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).