linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Anatoli Antonovitch <anatoli.antonovitch@amd.com>
Cc: Anatoli Antonovitch <a.antonovitch@gmail.com>,
	linux-pci@vger.kernel.org, bhelgaas@google.com,
	Alexander.Deucher@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH] PCI/hotplug: Replaced down_write_nested with hotplug_slot_rwsem if ctrl->depth > 0 when taking the ctrl->reset_lock.
Date: Sat, 21 Jan 2023 08:21:48 +0100	[thread overview]
Message-ID: <20230121072148.GA13969@wunner.de> (raw)
In-Reply-To: <d14fd1b2-41c9-75bd-5b76-d2c396c1ebb7@amd.com>

On Fri, Jan 20, 2023 at 04:35:01PM -0500, Anatoli Antonovitch wrote:
> On 2023-01-20 04:28, Lukas Wunner wrote:
> > I've just submitted an alternative patch to fix this, could you give
> > it a spin and see if the issue goes away?
> > 
> > https://patchwork.kernel.org/project/linux-pci/patch/3dc88ea82bdc0e37d9000e413d5ebce481cbd629.1674205689.git.lukas@wunner.de/
> 
> The patch has been tested on the same setup.
> Unfortunately, this alternative approach with optimization and simplified
> locking is not resolve the issue in
> https://bugzilla.kernel.org/show_bug.cgi?id=215590
> 
> I have uploaded the log dmesg_6_2_rc4_hotadd_aer_fix_a6bd101b8f84.txt into
> the bugzilla for your patch.

You're now getting a different deadlock.  That one is addressed by this
old patch (it's already linked from the bugzilla):

https://lore.kernel.org/linux-pci/908047f7699d9de9ec2efd6b79aa752d73dab4b6.1595329748.git.lukas@wunner.de/

If you apply that patch plus the new one, do you still see a deadlock?

Thanks,

Lukas

  reply	other threads:[~2023-01-21  7:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 17:01 [PATCH] PCI/hotplug: Replaced down_write_nested with hotplug_slot_rwsem if ctrl->depth > 0 when taking the ctrl->reset_lock Anatoli Antonovitch
2023-01-20  9:28 ` Lukas Wunner
2023-01-20 21:35   ` Anatoli Antonovitch
2023-01-21  7:21     ` Lukas Wunner [this message]
2023-01-23 19:30       ` Anatoli Antonovitch
2023-02-13 14:59         ` Anatoli Antonovitch
2023-02-17 16:03           ` Bjorn Helgaas
2023-02-17 18:37             ` Deucher, Alexander
2023-02-19 20:21               ` Lukas Wunner
2023-04-10 20:36                 ` Anatoli Antonovitch
  -- strict thread matches above, loose matches on Subject: below --
2023-01-05 18:43 Anatoli Antonovitch
2023-01-05 19:18 ` Bjorn Helgaas
     [not found]   ` <5b9a2dc7-54ab-82c5-81e7-1770a4ec891c@amd.com>
2023-01-16 18:37     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230121072148.GA13969@wunner.de \
    --to=lukas@wunner.de \
    --cc=Alexander.Deucher@amd.com \
    --cc=a.antonovitch@gmail.com \
    --cc=anatoli.antonovitch@amd.com \
    --cc=bhelgaas@google.com \
    --cc=christian.koenig@amd.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).