From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: kishon@kernel.org, lpieralisi@kernel.org, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
kw@linux.com, robh@kernel.org, vigneshr@ti.com
Subject: Re: [RESEND v4 2/5] PCI: tegra194: Move dw_pcie_ep_linkup() to threaded IRQ handler
Date: Tue, 24 Jan 2023 12:37:22 +0530 [thread overview]
Message-ID: <20230124070722.GA4947@thinkpad> (raw)
In-Reply-To: <7c9c11e5-c5f2-d36f-6204-ebc76646ee35@nvidia.com>
On Mon, Jan 23, 2023 at 12:52:18PM +0530, Vidya Sagar wrote:
> Thanks for pushing this change.
>
> Reviewed-by: Vidya Sagar <vidyas@nvidia.com>
>
Thanks Vidya! I will push a next version with a fix for an issue
identified by kbot. Hopefully that will get merged for 6.3.
Thanks,
Mani
> On 1/11/2023 5:10 PM, Manivannan Sadhasivam wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > dw_pcie_ep_linkup() may take more time to execute depending on the EPF
> > driver implementation. Calling this API in the hard IRQ handler is not
> > encouraged since the hard IRQ handlers are supposed to complete quickly.
> >
> > So move the dw_pcie_ep_linkup() call to threaded IRQ handler.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > drivers/pci/controller/dwc/pcie-tegra194.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> > index 02d78a12b6e7..09825b4a075e 100644
> > --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> > @@ -286,6 +286,7 @@ struct tegra_pcie_dw {
> > struct gpio_desc *pex_refclk_sel_gpiod;
> > unsigned int pex_rst_irq;
> > int ep_state;
> > + long link_status;
> > };
> >
> > static inline struct tegra_pcie_dw *to_tegra_pcie(struct dw_pcie *pci)
> > @@ -449,9 +450,13 @@ static void pex_ep_event_hot_rst_done(struct tegra_pcie_dw *pcie)
> > static irqreturn_t tegra_pcie_ep_irq_thread(int irq, void *arg)
> > {
> > struct tegra_pcie_dw *pcie = arg;
> > + struct dw_pcie_ep *ep = &pcie->pci.ep;
> > struct dw_pcie *pci = &pcie->pci;
> > u32 val, speed;
> >
> > + if (test_and_clear_bit(0, &pcie->link_status))
> > + dw_pcie_ep_linkup(ep);
> > +
> > speed = dw_pcie_readw_dbi(pci, pcie->pcie_cap_base + PCI_EXP_LNKSTA) &
> > PCI_EXP_LNKSTA_CLS;
> > clk_set_rate(pcie->core_clk, pcie_gen_freq[speed - 1]);
> > @@ -498,7 +503,6 @@ static irqreturn_t tegra_pcie_ep_irq_thread(int irq, void *arg)
> > static irqreturn_t tegra_pcie_ep_hard_irq(int irq, void *arg)
> > {
> > struct tegra_pcie_dw *pcie = arg;
> > - struct dw_pcie_ep *ep = &pcie->pci.ep;
> > int spurious = 1;
> > u32 status_l0, status_l1, link_status;
> >
> > @@ -514,7 +518,8 @@ static irqreturn_t tegra_pcie_ep_hard_irq(int irq, void *arg)
> > link_status = appl_readl(pcie, APPL_LINK_STATUS);
> > if (link_status & APPL_LINK_STATUS_RDLH_LINK_UP) {
> > dev_dbg(pcie->dev, "Link is up with Host\n");
> > - dw_pcie_ep_linkup(ep);
> > + set_bit(0, &pcie->link_status);
> > + return IRQ_WAKE_THREAD;
> > }
> > }
> >
> > --
> > 2.25.1
> >
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-01-24 7:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 11:40 [RESEND v4 0/5] PCI: endpoint: Rework the EPC to EPF notification Manivannan Sadhasivam
2023-01-11 11:40 ` [RESEND v4 1/5] PCI: dra7xx: Use threaded IRQ handler for "dra7xx-pcie-main" IRQ Manivannan Sadhasivam
2023-01-11 11:40 ` [RESEND v4 2/5] PCI: tegra194: Move dw_pcie_ep_linkup() to threaded IRQ handler Manivannan Sadhasivam
2023-01-18 14:01 ` Manivannan Sadhasivam
2023-01-23 7:22 ` Vidya Sagar
2023-01-24 7:07 ` Manivannan Sadhasivam [this message]
2023-01-11 11:40 ` [RESEND v4 3/5] PCI: endpoint: Use a separate lock for protecting epc->pci_epf list Manivannan Sadhasivam
2023-01-11 11:40 ` [RESEND v4 4/5] PCI: endpoint: Use callback mechanism for passing events from EPC to EPF Manivannan Sadhasivam
2023-01-11 11:40 ` [RESEND v4 5/5] PCI: endpoint: Use link_up() callback in place of LINK_UP notifier Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124070722.GA4947@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=bhelgaas@google.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=vidyas@nvidia.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).