From: Oskari Lemmela <oskari@lemmela.net>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: "Ryder Lee" <ryder.lee@mediatek.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, "Oskari Lemmela" <oskari@lemmela.net>
Subject: [PATCH] PCI: mediatek: increase link training timeout
Date: Sun, 26 Mar 2023 15:12:17 +0300 [thread overview]
Message-ID: <20230326121217.2664953-1-oskari@lemmela.net> (raw)
Some PCI devices fail to complete link training in 100ms.
Increase link training timeout by 20ms to 120ms.
Signed-off-by: Oskari Lemmela <oskari@lemmela.net>
---
drivers/pci/controller/pcie-mediatek.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c
index ae5ad05ddc1d..67b8cf0dc9f7 100644
--- a/drivers/pci/controller/pcie-mediatek.c
+++ b/drivers/pci/controller/pcie-mediatek.c
@@ -720,10 +720,10 @@ static int mtk_pcie_startup_port_v2(struct mtk_pcie_port *port)
if (soc->need_fix_device_id)
writew(soc->device_id, port->base + PCIE_CONF_DEVICE_ID);
- /* 100ms timeout value should be enough for Gen1/2 training */
+ /* 120ms timeout value should be enough for Gen1/2 training */
err = readl_poll_timeout(port->base + PCIE_LINK_STATUS_V2, val,
!!(val & PCIE_PORT_LINKUP_V2), 20,
- 100 * USEC_PER_MSEC);
+ 120 * USEC_PER_MSEC);
if (err)
return -ETIMEDOUT;
@@ -785,10 +785,10 @@ static int mtk_pcie_startup_port(struct mtk_pcie_port *port)
val &= ~PCIE_PORT_PERST(port->slot);
writel(val, pcie->base + PCIE_SYS_CFG);
- /* 100ms timeout value should be enough for Gen1/2 training */
+ /* 120ms timeout value should be enough for Gen1/2 training */
err = readl_poll_timeout(port->base + PCIE_LINK_STATUS, val,
!!(val & PCIE_PORT_LINKUP), 20,
- 100 * USEC_PER_MSEC);
+ 120 * USEC_PER_MSEC);
if (err)
return -ETIMEDOUT;
--
2.34.1
next reply other threads:[~2023-03-26 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 12:12 Oskari Lemmela [this message]
2023-05-01 20:36 ` [PATCH] PCI: mediatek: increase link training timeout Bjorn Helgaas
2023-05-02 17:43 ` Oskari Lemmelä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230326121217.2664953-1-oskari@lemmela.net \
--to=oskari@lemmela.net \
--cc=bhelgaas@google.com \
--cc=jianjun.wang@mediatek.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).