From: "Krzysztof Wilczyński" <kw@linux.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
mani@kernel.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com,
roy.zang@nxp.com, marek.vasut+renesas@gmail.com,
linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 0/3] PCI: dwc: Improve code readability
Date: Mon, 13 Nov 2023 19:09:14 +0900 [thread overview]
Message-ID: <20231113100914.GB1583963@rocinante> (raw)
In-Reply-To: <20231113013300.2132152-1-yoshihiro.shimoda.uh@renesas.com>
Hi Yoshihiro!
> This patch series is based on the latest pci.git / next branch.
[...]
Thank you for following up to tidy things up! Much appreciated.
Now, while you are looking at things, can you also take care about the following:
drivers/pci/controller/dwc/pcie-rcar-gen4.c:439:15: warning: cast to smaller integer type 'enum dw_pcie_device_mode' from 'const void *' [-Wvoid-pointer-to-enum-cast]
This requires adding structs for each data member of the of_device_id type.
Some examples from other drivers:
- https://elixir.bootlin.com/linux/v6.6.1/source/drivers/pci/controller/dwc/pcie-tegra194.c#L2440
- https://elixir.bootlin.com/linux/v6.6.1/source/drivers/pci/controller/dwc/pci-keystone.c#L1074
Thank you! :)
Krzysztof
next prev parent reply other threads:[~2023-11-13 10:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 1:32 [PATCH 0/3] PCI: dwc: Improve code readability Yoshihiro Shimoda
2023-11-13 1:32 ` [PATCH 1/3] PCI: dwc: Rename to .init in struct dw_pcie_ep_ops Yoshihiro Shimoda
2023-11-13 10:14 ` Serge Semin
2023-11-13 11:49 ` Yoshihiro Shimoda
2023-11-13 1:32 ` [PATCH 2/3] PCI: dwc: Rename to .get_dbi_offset " Yoshihiro Shimoda
2023-11-13 10:34 ` Serge Semin
2023-11-13 1:33 ` [PATCH 3/3] PCI: dwc: Add dw_pcie_ep_{read,write}_dbi[2] helpers Yoshihiro Shimoda
2023-11-13 12:41 ` Serge Semin
2023-11-14 1:29 ` Yoshihiro Shimoda
2023-11-13 10:09 ` Krzysztof Wilczyński [this message]
2023-11-13 11:07 ` [PATCH 0/3] PCI: dwc: Improve code readability Geert Uytterhoeven
2023-11-13 11:47 ` Yoshihiro Shimoda
2023-11-13 12:22 ` Krzysztof Wilczyński
2023-11-13 12:57 ` Geert Uytterhoeven
2023-11-13 13:18 ` Krzysztof Wilczyński
2023-11-14 0:20 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113100914.GB1583963@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=robh@kernel.org \
--cc=roy.zang@nxp.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).