From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: "Bjorn Andersson" <andersson@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>
Cc: linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: [PATCH v2 2/3] PCI: qcom: Read back PARF_LTSSM register
Date: Sat, 10 Feb 2024 18:10:06 +0100 [thread overview]
Message-ID: <20240210-topic-8280_pcie-v2-2-1cef4b606883@linaro.org> (raw)
In-Reply-To: <20240210-topic-8280_pcie-v2-0-1cef4b606883@linaro.org>
To ensure write completion, read the PARF_LTSSM register after setting
the LTSSM enable bit before polling for "link up".
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/pci/controller/dwc/pcie-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index cbde9effa352..6a469ed213ce 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -539,6 +539,7 @@ static void qcom_pcie_2_3_2_ltssm_enable(struct qcom_pcie *pcie)
val = readl(pcie->parf + PARF_LTSSM);
val |= LTSSM_EN;
writel(val, pcie->parf + PARF_LTSSM);
+ readl(pcie->parf + PARF_LTSSM);
}
static int qcom_pcie_get_resources_2_3_2(struct qcom_pcie *pcie)
--
2.40.1
next prev parent reply other threads:[~2024-02-10 17:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 17:10 [PATCH v2 0/3] Qualcomm PCIe RC shutdown & reinit Konrad Dybcio
2024-02-10 17:10 ` [PATCH v2 1/3] PCI: qcom: reshuffle reset logic in 2_7_0 .init Konrad Dybcio
2024-02-12 21:14 ` Bjorn Helgaas
2024-02-15 11:51 ` Konrad Dybcio
2024-02-10 17:10 ` Konrad Dybcio [this message]
2024-02-12 21:17 ` [PATCH v2 2/3] PCI: qcom: Read back PARF_LTSSM register Bjorn Helgaas
2024-02-14 21:35 ` Konrad Dybcio
2024-02-14 22:28 ` Bjorn Helgaas
2024-02-15 10:21 ` Konrad Dybcio
2024-02-15 16:11 ` Bjorn Helgaas
2024-02-15 18:44 ` Konrad Dybcio
2024-02-16 6:52 ` Johan Hovold
2024-03-15 10:16 ` Konrad Dybcio
2024-03-15 11:16 ` Manivannan Sadhasivam
2024-03-15 16:47 ` Johan Hovold
2024-03-27 19:37 ` Konrad Dybcio
2024-03-27 19:38 ` Konrad Dybcio
2024-02-10 17:10 ` [PATCH v2 3/3] PCI: qcom: properly implement RC shutdown/power up Konrad Dybcio
2024-02-12 21:32 ` Bjorn Helgaas
2024-02-14 21:33 ` Konrad Dybcio
2024-02-15 7:13 ` Johan Hovold
2024-02-15 10:22 ` Konrad Dybcio
2024-02-20 4:12 ` Krishna Chaitanya Chundru
2024-03-27 19:37 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240210-topic-8280_pcie-v2-2-1cef4b606883@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=johan+linaro@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).