From: Onkarnarth <onkarnath.1@samsung.com>
To: rafael@kernel.org, lenb@kernel.org, bhelgaas@google.com,
viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
r.thapliyal@samsung.com, maninder1.s@samsung.com,
helgaas@kernel.org, Onkarnath <onkarnath.1@samsung.com>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Subject: [PATCH v3 2/2] cpufreq/schedutil: print errors with %pe for better readability of logs
Date: Tue, 13 Feb 2024 13:14:16 +0530 [thread overview]
Message-ID: <20240213074416.2169929-2-onkarnath.1@samsung.com> (raw)
In-Reply-To: <20240213074416.2169929-1-onkarnath.1@samsung.com>
From: Onkarnath <onkarnath.1@samsung.com>
Instead of printing errros as a number(%ld), it's better to print in string
format for better readability of logs.
Signed-off-by: Onkarnath <onkarnath.1@samsung.com>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
---
v1 -> v2: Updated subject as per file history.
v2 -> v3: No change in this patch, change done in PATCH v3 1/2.
kernel/sched/cpufreq_schedutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index eece6244f9d2..2c42eaa56fa3 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -671,7 +671,7 @@ static int sugov_kthread_create(struct sugov_policy *sg_policy)
"sugov:%d",
cpumask_first(policy->related_cpus));
if (IS_ERR(thread)) {
- pr_err("failed to create sugov thread: %ld\n", PTR_ERR(thread));
+ pr_err("failed to create sugov thread: %pe\n", thread);
return PTR_ERR(thread);
}
--
2.25.1
next prev parent reply other threads:[~2024-02-13 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240213074430epcas5p4c520bf2cce121cf5fa970eed429231a8@epcas5p4.samsung.com>
2024-02-13 7:44 ` [PATCH v3 1/2] ACPI: use %pe for better readability of errors while printing Onkarnarth
[not found] ` <CGME20240213074436epcas5p4757b38265bea29c3bb6f1e0aa90f602a@epcas5p4.samsung.com>
2024-02-13 7:44 ` Onkarnarth [this message]
2024-02-13 22:14 ` Bjorn Helgaas
2024-02-15 19:56 ` Rafael J. Wysocki
[not found] ` <CGME20240213074430epcas5p4c520bf2cce121cf5fa970eed429231a8@epcms5p3>
2024-02-16 5:45 ` Onkarnath
2024-02-16 18:29 ` Rafael J. Wysocki
2024-02-16 18:32 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213074416.2169929-2-onkarnath.1@samsung.com \
--to=onkarnath.1@samsung.com \
--cc=bhelgaas@google.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=helgaas@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=r.thapliyal@samsung.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).