From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D351120B11 for ; Fri, 8 Mar 2024 17:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709917845; cv=none; b=ASX8htpZ2BJ662tBRwZtwxR6PmK13QCJkUlGNIaOVl3x23U+gI9vuIlZSf7OHlISZMMdUpxm0NwUqNmeJOG816YCccJ+paMZ4yp0Lb7c57Yy/gAnF7JR6ee9BXxpS98+o598P2gH3Y5wH+X/uOYPobOyAc2VNum4kx5f98qnAFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709917845; c=relaxed/simple; bh=HzEEo1FuAZnGJUVCVuHaKfjVwk766+6hzwh+AAu2Lkc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z1pznbzI8Yjwie2OLTbnRJ0Cumitx+ZcP+ZqCtypTIknTSp8RhhKCPcIlGSyUZPCwHNmdgLIDSJU2P7Fbfx1FOBZdkTFsAMDVAM4sXWYwTxISMDfej/hlBALCmzMWvULSnHQ3kbIdBp/lCWPW2OT+2ERQPf4OJ5EPrIVdrvLxa4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xMQdxgs3; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xMQdxgs3" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-5e42b4bbfa4so737286a12.1 for ; Fri, 08 Mar 2024 09:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709917842; x=1710522642; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=w2kWEuzgRtKwEAwMhmmNmodaPq/DI7wxcR5vXLJ04Wo=; b=xMQdxgs3l7YLOjNGixyvgxQtqkeyBA1La7VbiP36ZjCqGMQKgVr8elooWoqrsbixxe fgtYeLBIvJy6Vl1Qk3qViMvdVIpdjAfXdwcgCsIxdTaGfUhLZ6e7y54DlJBtLQQnNkLd IOMHJIJWbaX/CN8vASDqWtNUKLQAPgl9PchVV7Ln+btysY0ivb71NElMS7x3oZspWlkG W/jwdOkoyQ+fnAR42HxIkXNaBol/RB33zsoBRGFL0XLgSp0Q5gstYAgDLoyUXyZkPgI/ 06bY8lXBGux2fy0/oewvjWsdOE2XS4wmUYq1SU4WOs4a+mqFjfqJbB4IVhKLgc05ygc5 9APg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709917842; x=1710522642; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w2kWEuzgRtKwEAwMhmmNmodaPq/DI7wxcR5vXLJ04Wo=; b=u3gKEt+p+NcY5yruzyGGZf2Q6RHsq+rkO5wn+oWX975fB8al0saKf7rEtwYBru7jxh UuIapbPnCzka8pGqO2s05cGfqWx6gp5fk2J45u5L9x9NPilUZYb7BT9S/vHKCYd9y9+l TU7wyZEshexmD58xxfGtDByysy4/eC8OwzuZW1NsSYlXPkGeOlZ4OH/7hTYkSy22UI2U ODAboGgXWwB6vkGU1c8XWUWiTOTkcIIWOXDBd6sADUbmtH+OzpGJqix2IkvjW/HwtG+R hVBtppRMKWe+paPruGw26OKdj5hhsEnPaf197QF4rzTbMPBYQsR4MVV7t6FlNs+hEyx4 3VBQ== X-Forwarded-Encrypted: i=1; AJvYcCW9WzzZBtYv3VjgE2ofo0kVjfh0yiDMKjtXFd+AldZTBvCf+EB2bGgteF/CQ89Q9kqlZq35iSH0wi28+Jp8ur1Bnza7XGvVdWdU X-Gm-Message-State: AOJu0Yy4yC4SVJjxfl3UDsfB8LTa9HH/V4uwVdyQtcZeOD0Ox/jS4XMw y0doR86CywJ4KYWv56wh03TGDlN2jjMgVW4SpFgidLJPR8Gt3fzX3DR8+6OqXg== X-Google-Smtp-Source: AGHT+IFZZccyoD4Rjms9sGylhl/6bi13hc3TIZoTOmk5GJOEjCrpAwbGuEHC37AMF3es6hymzRJPLA== X-Received: by 2002:a17:90b:318:b0:29b:b6bb:17ba with SMTP id ay24-20020a17090b031800b0029bb6bb17bamr567988pjb.46.1709917841853; Fri, 08 Mar 2024 09:10:41 -0800 (PST) Received: from thinkpad ([117.217.183.232]) by smtp.gmail.com with ESMTPSA id k61-20020a17090a3ec300b0029ba1b5a692sm2470187pjc.12.2024.03.08.09.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 09:10:41 -0800 (PST) Date: Fri, 8 Mar 2024 22:40:29 +0530 From: Manivannan Sadhasivam To: Andy Shevchenko Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lorenzo Pieralisi , linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, Vignesh Raghavendra , Siddharth Vadapalli , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Yue Wang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Bjorn Andersson , Konrad Dybcio , Thierry Reding , Jonathan Hunter Subject: Re: [PATCH v1 1/1] PCI: dwc: Remove unused of_gpio.h Message-ID: <20240308171029.GB53064@thinkpad> References: <20240307122840.3682287-1-andriy.shevchenko@linux.intel.com> <20240308095547.GI3789@thinkpad> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 08, 2024 at 02:09:25PM +0200, Andy Shevchenko wrote: > On Fri, Mar 08, 2024 at 03:25:47PM +0530, Manivannan Sadhasivam wrote: > > On Thu, Mar 07, 2024 at 02:28:40PM +0200, Andy Shevchenko wrote: > > > of_gpio.h is deprecated and subject to remove. > > > The driver doesn't use it, simply remove the unused header. > > > What about the rest? > > > > drivers/pci/controller/dwc/pcie-kirin.c > > drivers/pci/controller/dwc/pci-imx6.c > > Have you chance to look at them? > Ok. I failed to spot the usage of of_get_named_gpio() in both drivers. But you already submitted a patch to convert kirin last year [1], and that didn't get any love from the maintainers. Could you please respin? Perhaps convert imx6 also? [1] https://lore.kernel.org/all/20230213180735.42117-1-andriy.shevchenko@linux.intel.com/ > > There is also one non-dwc driver: > > > > drivers/pci/controller/pci-aardvark.c > > Keyword: non-dwc. > This patch is for DesignWare controllers that confirmed not using the header. > > > It is better to remove it from all PCI drivers in a single patch. > > I disagree on this. These are different drivers and even inside DesignWare not > all of them can be converted with a simple change like this one. > Since this is just a header removal I thought you can just send a single patch for these drivers since there is nothing special that warrants a separate patch for aardvark (both are inside the drivers/pci/ hierarchy). But anyway, I wouldn't press for it. > That said, please consider applying this one as is. > I can give my R-o-b tag, but Lorenzo or Krzysztof will apply this. Reviewed-by: Manivannan Sadhasivam - Mani -- மணிவண்ணன் சதாசிவம்