linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Kalle Valo <kvalo@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Saravana Kannan <saravanak@google.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Arnd Bergmann <arnd@arndb.de>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Alex Elder <elder@linaro.org>,
	Srini Kandagatla <srinivas.kandagatla@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Abel Vesa <abel.vesa@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Lukas Wunner <lukas@wunner.de>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
	linux-pm@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH v6 11/16] PCI/pwrctl: create platform devices for child OF nodes of the port node
Date: Mon, 25 Mar 2024 14:16:19 +0100	[thread overview]
Message-ID: <20240325131624.26023-12-brgl@bgdev.pl> (raw)
In-Reply-To: <20240325131624.26023-1-brgl@bgdev.pl>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

In preparation for introducing PCI device power control - a set of
library functions that will allow powering-up of PCI devices before
they're detected on the PCI bus - we need to populate the devices
defined on the device-tree.

We are reusing the platform bus as it provides us with all the
infrastructure we need to match the pwrctl drivers against the
compatibles from OF nodes.

These platform devices will be probed by the driver core and bound to
the PCI pwrctl drivers we'll introduce later.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/pci/bus.c    | 9 ++++++++-
 drivers/pci/remove.c | 2 ++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
index 826b5016a101..17ab41094c4e 100644
--- a/drivers/pci/bus.c
+++ b/drivers/pci/bus.c
@@ -12,6 +12,7 @@
 #include <linux/errno.h>
 #include <linux/ioport.h>
 #include <linux/of.h>
+#include <linux/of_platform.h>
 #include <linux/proc_fs.h>
 #include <linux/slab.h>
 
@@ -342,8 +343,14 @@ void pci_bus_add_device(struct pci_dev *dev)
 	 */
 	pcibios_bus_add_device(dev);
 	pci_fixup_device(pci_fixup_final, dev);
-	if (pci_is_bridge(dev))
+	if (pci_is_bridge(dev)) {
 		of_pci_make_dev_node(dev);
+		retval = of_platform_populate(dev->dev.of_node, NULL, NULL,
+					      &dev->dev);
+		if (retval)
+			pci_err(dev, "failed to populate child OF nodes (%d)\n",
+				retval);
+	}
 	pci_create_sysfs_dev_files(dev);
 	pci_proc_attach_device(dev);
 	pci_bridge_d3_update(dev);
diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
index d749ea8250d6..fc9db2805888 100644
--- a/drivers/pci/remove.c
+++ b/drivers/pci/remove.c
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 #include <linux/pci.h>
 #include <linux/module.h>
+#include <linux/of_platform.h>
 #include "pci.h"
 
 static void pci_free_resources(struct pci_dev *dev)
@@ -22,6 +23,7 @@ static void pci_stop_dev(struct pci_dev *dev)
 		device_release_driver(&dev->dev);
 		pci_proc_detach_device(dev);
 		pci_remove_sysfs_dev_files(dev);
+		of_platform_depopulate(&dev->dev);
 		of_pci_remove_node(dev);
 
 		pci_dev_assign_added(dev, false);
-- 
2.40.1


  parent reply	other threads:[~2024-03-25 13:17 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 13:16 [PATCH v6 00/16] power: sequencing: implement the subsystem and add first users Bartosz Golaszewski
2024-03-25 13:16 ` [PATCH v6 01/16] regulator: dt-bindings: describe the PMU module of the QCA6390 package Bartosz Golaszewski
2024-03-25 14:33   ` Mark Brown
2024-03-27 18:17   ` Krzysztof Kozlowski
2024-03-27 18:55     ` Bartosz Golaszewski
2024-03-28  9:06       ` Krzysztof Kozlowski
2024-03-28  9:07   ` Krzysztof Kozlowski
2024-03-25 13:16 ` [PATCH v6 02/16] regulator: dt-bindings: describe the PMU module of the WCN7850 package Bartosz Golaszewski
2024-03-25 14:34   ` Mark Brown
2024-03-27 18:19   ` Krzysztof Kozlowski
2024-03-27 18:56     ` Bartosz Golaszewski
2024-03-25 13:16 ` [PATCH v6 03/16] dt-bindings: net: bluetooth: qualcomm: describe regulators for QCA6390 Bartosz Golaszewski
2024-03-25 13:16 ` [PATCH v6 04/16] dt-bindings: net: wireless: qcom,ath11k: describe the ath11k on QCA6390 Bartosz Golaszewski
2024-03-25 13:57   ` Kalle Valo
2024-03-25 14:09     ` Bartosz Golaszewski
2024-03-25 14:37       ` Kalle Valo
2024-03-25 16:23         ` Bartosz Golaszewski
2024-03-26 15:12           ` Kalle Valo
2024-03-26 16:32             ` Bartosz Golaszewski
2024-03-26 17:05               ` Johan Hovold
2024-03-26  8:11         ` Johan Hovold
2024-03-25 20:03       ` Jeff Johnson
2024-03-25 13:16 ` [PATCH v6 05/16] dt-bindings: net: wireless: describe the ath12k PCI module Bartosz Golaszewski
2024-03-25 14:01   ` Kalle Valo
2024-04-03 14:56     ` Bartosz Golaszewski
2024-04-05  9:33       ` Kalle Valo
2024-04-05  9:37         ` Krzysztof Kozlowski
2024-04-05  9:41           ` Krzysztof Kozlowski
2024-04-05  9:52         ` Bartosz Golaszewski
2024-04-05 15:44           ` Jeff Johnson
2024-03-27 18:21   ` Krzysztof Kozlowski
2024-03-25 13:16 ` [PATCH v6 06/16] arm64: dts: qcom: sm8550-qrd: add the Wifi node Bartosz Golaszewski
2024-03-25 13:16 ` [PATCH v6 07/16] arm64: dts: qcom: sm8650-qrd: " Bartosz Golaszewski
2024-03-25 13:16 ` [PATCH v6 08/16] arm64: dts: qcom: qrb5165-rb5: " Bartosz Golaszewski
2024-03-25 13:16 ` [PATCH v6 09/16] PCI: hold the rescan mutex when scanning for the first time Bartosz Golaszewski
2024-03-25 13:16 ` [PATCH v6 10/16] PCI/pwrctl: reuse the OF node for power controlled devices Bartosz Golaszewski
2024-03-25 13:16 ` Bartosz Golaszewski [this message]
2024-03-25 13:16 ` [PATCH v6 12/16] PCI/pwrctl: add PCI power control core code Bartosz Golaszewski
2024-03-27 16:16   ` Simon Horman
2024-03-25 13:16 ` [PATCH v6 13/16] power: sequencing: implement the pwrseq core Bartosz Golaszewski
2024-03-25 13:16 ` [PATCH v6 14/16] power: pwrseq: add a driver for the PMU module on the QCom WCN chipsets Bartosz Golaszewski
2024-03-25 13:16 ` [PATCH v6 15/16] Bluetooth: qca: use the power sequencer for QCA6390 Bartosz Golaszewski
2024-03-25 13:16 ` [PATCH v6 16/16] PCI/pwrctl: add a PCI power control driver for power sequenced devices Bartosz Golaszewski
2024-04-06  3:03 ` [PATCH v6 00/16] power: sequencing: implement the subsystem and add first users Xilin Wu
2024-04-09 15:35   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240325131624.26023-12-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=edumazet@google.com \
    --cc=elder@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=lukas@wunner.de \
    --cc=m.szyprowski@samsung.com \
    --cc=mani@kernel.org \
    --cc=marcel@holtmann.org \
    --cc=neil.armstrong@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=saravanak@google.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).