From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Kevin Tian <kevin.tian@intel.com>, Marc Zyngier <maz@kernel.org>,
Reinette Chatre <reinette.chatre@intel.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Dave Jiang <dave.jiang@intel.com>,
Megha Dey <megha.dey@intel.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Robin Murphy <robin.murphy@arm.com>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH v2 6/7] Revert "x86/apic/msi: Enable PCI/IMS"
Date: Wed, 10 Apr 2024 17:13:06 -0500 [thread overview]
Message-ID: <20240410221307.2162676-7-helgaas@kernel.org> (raw)
In-Reply-To: <20240410221307.2162676-1-helgaas@kernel.org>
From: Bjorn Helgaas <bhelgaas@google.com>
This reverts commit 6e24c887732901140f4e82ba2315c2e15f06f1d6.
IMS (Interrupt Message Store) support appeared in v6.2, but there are no
users yet.
Remove it for now. We can add it back when a user comes along.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
arch/x86/kernel/apic/msi.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/x86/kernel/apic/msi.c b/arch/x86/kernel/apic/msi.c
index d9651f15ae4f..340769242dea 100644
--- a/arch/x86/kernel/apic/msi.c
+++ b/arch/x86/kernel/apic/msi.c
@@ -184,7 +184,6 @@ static int x86_msi_prepare(struct irq_domain *domain, struct device *dev,
alloc->type = X86_IRQ_ALLOC_TYPE_PCI_MSI;
return 0;
case DOMAIN_BUS_PCI_DEVICE_MSIX:
- case DOMAIN_BUS_PCI_DEVICE_IMS:
alloc->type = X86_IRQ_ALLOC_TYPE_PCI_MSIX;
return 0;
default:
@@ -229,10 +228,6 @@ static bool x86_init_dev_msi_info(struct device *dev, struct irq_domain *domain,
case DOMAIN_BUS_PCI_DEVICE_MSI:
case DOMAIN_BUS_PCI_DEVICE_MSIX:
break;
- case DOMAIN_BUS_PCI_DEVICE_IMS:
- if (!(pops->supported_flags & MSI_FLAG_PCI_IMS))
- return false;
- break;
default:
WARN_ON_ONCE(1);
return false;
--
2.34.1
next prev parent reply other threads:[~2024-04-10 22:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 22:13 [PATCH v2 0/7] PCI/MSI: Remove IMS (Interrupt Message Store) support for now Bjorn Helgaas
2024-04-10 22:13 ` [PATCH v2 1/7] Revert "PCI/MSI: Provide stubs for IMS functions" Bjorn Helgaas
2024-04-10 22:13 ` [PATCH v2 2/7] Revert "PCI/MSI: Provide pci_ims_alloc/free_irq()" Bjorn Helgaas
2024-04-10 22:13 ` [PATCH v2 3/7] Revert "PCI/MSI: Provide IMS (Interrupt Message Store) support" Bjorn Helgaas
2024-04-10 22:13 ` [PATCH v2 4/7] Revert "iommu/amd: Enable PCI/IMS" Bjorn Helgaas
2024-04-11 5:12 ` Tian, Kevin
2024-04-10 22:13 ` [PATCH v2 5/7] Revert "iommu/vt-d: " Bjorn Helgaas
2024-04-11 5:13 ` Tian, Kevin
2024-04-10 22:13 ` Bjorn Helgaas [this message]
2024-04-11 5:13 ` [PATCH v2 6/7] Revert "x86/apic/msi: " Tian, Kevin
2024-04-10 22:13 ` [PATCH v2 7/7] Revert "genirq/msi: Provide constants for PCI/IMS support" Bjorn Helgaas
2024-04-11 5:14 ` Tian, Kevin
2024-04-10 22:45 ` [PATCH v2 0/7] PCI/MSI: Remove IMS (Interrupt Message Store) support for now Thomas Gleixner
2024-04-10 22:46 ` Jason Gunthorpe
2024-04-12 21:31 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410221307.2162676-7-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maz@kernel.org \
--cc=megha.dey@intel.com \
--cc=reinette.chatre@intel.com \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).