From: Rob Herring <robh@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Jon Lin" <jon.lin@rock-chips.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Simon Xue" <xxm@rock-chips.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 01/12] dt-bindings: PCI: snps,dw-pcie-ep: Add vendor specific reg-name
Date: Thu, 25 Apr 2024 10:49:28 -0500 [thread overview]
Message-ID: <20240425154928.GA2600809-robh@kernel.org> (raw)
In-Reply-To: <20240424-rockchip-pcie-ep-v1-v1-1-b1a02ddad650@kernel.org>
On Wed, Apr 24, 2024 at 05:16:19PM +0200, Niklas Cassel wrote:
> Considering that some drivers (e.g. pcie-dw-rockchip.c) already use the
> reg-name "apb" for the device tree binding in Root Complex mode
> (snps,dw-pcie.yaml), it doesn't make sense that those drivers should use a
> different reg-name when running in Endpoint mode (snps,dw-pcie-ep.yaml).
>
> Therefore, since "apb" is already defined in snps,dw-pcie.yaml, add it
> also for snps,dw-pcie-ep.yaml.
>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
> Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml
> index bbdb01d22848..00dec01f1f73 100644
> --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml
> @@ -100,7 +100,7 @@ properties:
> for new bindings.
> oneOf:
> - description: See native 'elbi/app' CSR region for details.
> - enum: [ link, appl ]
> + enum: [ apb, link, appl ]
This section is for existing bindings. IOW, don't use or add to them
for new users. New users should "See native 'elbi/app' CSR region".
Rob
next prev parent reply other threads:[~2024-04-25 15:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 15:16 [PATCH 00/12] PCI: dw-rockchip: Add endpoint mode support Niklas Cassel
2024-04-24 15:16 ` [PATCH 01/12] dt-bindings: PCI: snps,dw-pcie-ep: Add vendor specific reg-name Niklas Cassel
2024-04-25 15:49 ` Rob Herring [this message]
2024-04-25 15:54 ` Rob Herring
2024-04-24 15:16 ` [PATCH 02/12] dt-bindings: PCI: snps,dw-pcie-ep: Add vendor specific interrupt-names Niklas Cassel
2024-04-25 15:55 ` Rob Herring
2024-04-24 15:16 ` [PATCH 03/12] dt-bindings: PCI: snps,dw-pcie-ep: Add tx_int{a,b,c,d} legacy irqs Niklas Cassel
2024-04-25 16:20 ` Rob Herring
2024-04-24 15:16 ` [PATCH 04/12] dt-bindings: rockchip: Add DesignWare based PCIe Endpoint controller Niklas Cassel
2024-04-25 16:08 ` Rob Herring
2024-04-30 11:34 ` Niklas Cassel
2024-04-24 15:16 ` [PATCH 05/12] PCI: dw-rockchip: Fix weird indentation Niklas Cassel
2024-04-24 15:16 ` [PATCH 06/12] PCI: dw-rockchip: Add rockchip_pcie_ltssm() helper Niklas Cassel
2024-04-24 15:16 ` [PATCH 07/12] PCI: dw-rockchip: Refactor the driver to prepare for EP mode Niklas Cassel
2024-04-24 15:16 ` [PATCH 08/12] PCI: dw-rockchip: Add explicit rockchip,rk3588-pcie compatible Niklas Cassel
2024-04-24 15:16 ` [PATCH 09/12] PCI: dw-rockchip: Add endpoint mode support Niklas Cassel
2024-04-24 15:16 ` [PATCH 10/12] misc: pci_endpoint_test: Add support for rockchip rk3588 Niklas Cassel
2024-04-25 19:16 ` Frank Li
2024-04-30 11:42 ` Niklas Cassel
2024-04-24 15:16 ` [PATCH 11/12] arm64: dts: rockchip: Add PCIe endpoint mode support Niklas Cassel
2024-04-24 15:16 ` [PATCH 12/12] arm64: dts: rockchip: Add rock5b overlays for PCIe endpoint mode Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425154928.GA2600809-robh@kernel.org \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=jon.lin@rock-chips.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=shawn.lin@rock-chips.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).