From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: p.zabel@pengutronix.de, l.stach@pengutronix.de,
bhelgaas@google.com, lorenzo.pieralisi@arm.com, robh@kernel.org,
shawnguo@kernel.org, vkoul@kernel.org,
Richard Zhu <hongxing.zhu@nxp.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-imx@nxp.com, Richard Zhu <hongxing.zhu@nxp.com>
Subject: Re: (EXT) [PATCH v2 6/7] arm64: dts: imx8mp-evk: Add PCIe support
Date: Thu, 24 Mar 2022 11:04:35 +0100 [thread overview]
Message-ID: <2236205.ElGaqSPkdT@steina-w> (raw)
In-Reply-To: <1646644054-24421-7-git-send-email-hongxing.zhu@nxp.com>
Hello Richard,
thanks for providing PCIe support for iMX8MP.
Am Montag, 7. März 2022, 10:07:33 CET schrieb Richard Zhu:
> Add PCIe support on i.MX8MP EVK board.
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 55 ++++++++++++++++++++
> 1 file changed, 55 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts index
> 2eb943210678..ed77455a3f73 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> @@ -5,6 +5,7 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/phy/phy-imx8-pcie.h>
> #include "imx8mp.dtsi"
>
> / {
> @@ -33,6 +34,12 @@ memory@40000000 {
> <0x1 0x00000000 0 0xc0000000>;
> };
>
> + pcie0_refclk: pcie0-refclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <100000000>;
> + };
> +
> reg_can1_stby: regulator-can1-stby {
> compatible = "regulator-fixed";
> regulator-name = "can1-stby";
> @@ -55,6 +62,17 @@ reg_can2_stby: regulator-can2-stby {
> enable-active-high;
> };
>
> + reg_pcie0: regulator-pcie {
> + compatible = "regulator-fixed";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pcie0_reg>;
> + regulator-name = "MPCIE_3V3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&gpio2 6 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> reg_usdhc2_vmmc: regulator-usdhc2 {
> compatible = "regulator-fixed";
> pinctrl-names = "default";
> @@ -297,6 +315,30 @@ pca6416: gpio@20 {
> };
> };
>
> +&pcie_phy {
> + fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
> + clocks = <&pcie0_refclk>;
> + clock-names = "ref";
> + status = "okay";
> +};
> +
> +&pcie{
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pcie0>;
> + reset-gpio = <&gpio2 7 GPIO_ACTIVE_LOW>;
> + clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
> + <&clk IMX8MP_CLK_PCIE_ROOT>,
> + <&clk IMX8MP_CLK_HSIO_AXI>;
> + clock-names = "pcie", "pcie_aux", "pcie_bus";
This causes the following warnings in dtbs_check (paths stripped):
imx8mp-evk.dtb: pcie@33800000: clock-names:1: 'pcie_bus' was expected
From schema: Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
imx8mp-evk.dtb: pcie@33800000: clock-names:2: 'pcie_phy' was expected
From schema: Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
The bindings want 4 clocks for imx8mq (and imx8mp which seems similar):
* pcie
* pcie_bus
* pcie_phy
* pcie_aux
Ignoring the order there is no pcie_phy clock anymore, it was removed in
commit 1840518ae7de ("clk: imx8mp: Remove the none exist pcie clocks"). I was
wondering why, because the PCIE_PHY_CLK_ROOT at register 0xa380 inside CCM is
listed in RM.
So there is a clock missing for 'pcie_phy' or the binding needs some update
for imx8mp, no?
Regards,
Alexander
> + assigned-clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
> + <&clk IMX8MP_CLK_PCIE_AUX>;
> + assigned-clock-rates = <500000000>, <10000000>;
> + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_500M>,
> + <&clk IMX8MP_SYS_PLL2_50M>;
> + vpcie-supply = <®_pcie0>;
> + status = "okay";
> +};
> +
> &snvs_pwrkey {
> status = "okay";
> };
> @@ -442,6 +484,19 @@ MX8MP_IOMUXC_I2C3_SDA__I2C3_SDA 0x400001c3
>
> >;
>
> };
>
> + pinctrl_pcie0: pcie0grp {
> + fsl,pins = <
> + MX8MP_IOMUXC_I2C4_SCL__PCIE_CLKREQ_B
0x61 /* open drain, pull up */
> + MX8MP_IOMUXC_SD1_DATA5__GPIO2_IO07
0x41
> + >;
> + };
> +
> + pinctrl_pcie0_reg: pcie0reggrp {
> + fsl,pins = <
> + MX8MP_IOMUXC_SD1_DATA4__GPIO2_IO06
0x41
> + >;
> + };
> +
> pinctrl_pmic: pmicgrp {
> fsl,pins = <
> MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03
0x000001c0
next prev parent reply other threads:[~2022-03-24 10:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 9:07 [PATCH v2 0/7] Add the iMX8MP PCIe support Richard Zhu
2022-03-07 9:07 ` [PATCH v2 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support Richard Zhu
2022-04-04 9:34 ` Philipp Zabel
2022-04-15 7:32 ` Hongxing Zhu
2022-04-26 3:27 ` Hongxing Zhu
2022-04-14 20:48 ` Lucas Stach
2022-04-18 4:54 ` Hongxing Zhu
2022-03-07 9:07 ` [PATCH v2 2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding Richard Zhu
2022-03-08 1:07 ` Rob Herring
2022-03-10 2:04 ` Hongxing Zhu
2022-03-07 9:07 ` [PATCH v2 3/7] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY support Richard Zhu
2022-03-08 10:04 ` Lucas Stach
2022-03-09 6:05 ` Hongxing Zhu
2022-04-14 20:58 ` Lucas Stach
2022-04-18 4:55 ` Hongxing Zhu
2022-04-27 15:18 ` Lucas Stach
2022-04-28 1:29 ` Hongxing Zhu
2022-05-26 1:32 ` Hongxing Zhu
2022-03-07 9:07 ` [PATCH v2 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible string Richard Zhu
2022-03-10 20:10 ` Rob Herring
2022-03-07 9:07 ` [PATCH v2 5/7] arm64: dts: imx8mp: add the iMX8MP PCIe support Richard Zhu
2022-04-14 21:02 ` Lucas Stach
2022-04-18 4:55 ` Hongxing Zhu
2022-05-23 18:47 ` Tim Harvey
2022-05-24 2:44 ` Hongxing Zhu
2022-03-07 9:07 ` [PATCH v2 6/7] arm64: dts: imx8mp-evk: Add " Richard Zhu
2022-03-24 10:04 ` Alexander Stein [this message]
2022-03-28 3:00 ` (EXT) " Hongxing Zhu
2022-04-14 21:04 ` Lucas Stach
2022-04-18 4:55 ` Hongxing Zhu
2022-03-07 9:07 ` [PATCH v2 7/7] PCI: imx6: Add the iMX8MP " Richard Zhu
2022-05-12 16:08 ` Lorenzo Pieralisi
2022-05-13 2:22 ` Hongxing Zhu
2022-03-09 7:57 ` (EXT) [PATCH v2 0/7] " Alexander Stein
2022-03-10 2:03 ` Hongxing Zhu
2022-04-07 20:41 ` Tim Harvey
2022-04-08 3:14 ` Hongxing Zhu
2022-04-08 8:12 ` Lucas Stach
2022-04-11 3:32 ` Hongxing Zhu
2022-04-13 7:21 ` Lucas Stach
2022-04-13 7:55 ` Hongxing Zhu
2022-04-11 22:18 ` Tim Harvey
2022-04-14 20:45 ` Lucas Stach
2022-04-18 4:54 ` Hongxing Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2236205.ElGaqSPkdT@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).