linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dongdong Liu <liudongdong3@huawei.com>
To: <bhelgaas@google.com>, <keith.busch@intel.com>,
	<linux-pci@vger.kernel.org>
Subject: [Bug report] PCIe NVME SSD hotplug surprise removal issue
Date: Thu, 10 Jan 2019 16:17:12 +0800	[thread overview]
Message-ID: <252786ac-fc97-0c17-4219-d47d1d394def@huawei.com> (raw)

Hi Bjorn, Keith

The lspci -tv topology is as below.
  +-[0000:80]-+-00.0-[81]----00.0  Huawei Technologies Co., Ltd. Device 3714
  |           +-02.0-[82]----00.0  Huawei Technologies Co., Ltd. Device 3714
  |           +-04.0-[83]----00.0  Huawei Technologies Co., Ltd. Device 3714
  |           +-06.0-[84]----00.0  Huawei Technologies Co., Ltd. Device 3714
  |                   +-08.0-[|           +-0c.0-[86]--
  |           +-10.0-[87]----00.0  Huawei Technologies Co., Ltd. Device 3714

Then surprise removal 87:00.0 NVME SSD card. The issue is as below.
The SSD card is still present.

[  178.610064] pciehp 0000:80:10.0:pcie004: Slot(36): Link Down
[  178.725009] iommu: Removing device 0000:87:00.0 from group 12
[  178.731278] pciehp 0000:80:10.0:pcie004: Slot(36): Card present
[  180.731129] pcieport 0000:80:10.0: Data Link Layer Link Active not set in 1000 msec
[  182.243128] pciehp 0000:80:10.0:pcie004: Failed to check link status

Then lspci -s 80:10.0 -vvv|grep -i SltSta
SltSta:Status: AttnBtn- PowerFlt- MRL- CmdCplt- PresDet- Interlock
We can see the card is not present (PresDet-).

Data Link Layer State Changed (link down) event reported
prior to Presence Detect Changed (card is not present).
Current code pciehp_handle_presence_or_link_change() seems have such issue.

Any idea to resolve the issue.

Thanks,
Dongdong


             reply	other threads:[~2019-01-10  8:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10  8:17 Dongdong Liu [this message]
2019-01-10 13:12 ` [Bug report] PCIe NVME SSD hotplug surprise removal issue Dongdong Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=252786ac-fc97-0c17-4219-d47d1d394def@huawei.com \
    --to=liudongdong3@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=keith.busch@intel.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).