From: Jerome Brunet <jbrunet@baylibre.com>
To: Hanjie Lin <hanjie.lin@amlogic.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: Rob Herring <robh@kernel.org>,
Jianxin Pan <jianxin.pan@amlogic.com>,
linux-pci@vger.kernel.org, Yixun Lan <yixun.lan@amlogic.com>,
Yue Wang <yue.wang@amlogic.com>,
Qiufang Dai <qiufang.dai@amlogic.com>,
Liang Yang <liang.yang@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] PCI: meson: add the Amlogic Meson PCIe phy driver
Date: Thu, 30 Aug 2018 10:56:05 +0200 [thread overview]
Message-ID: <2558005d0cad11feb9d6775b2ed237351098fa06.camel@baylibre.com> (raw)
In-Reply-To: <b8deb2ef-5e73-b508-616e-b0303a0adc78@amlogic.com>
On Thu, 2018-08-30 at 16:02 +0800, Hanjie Lin wrote:
> > I thought you said there was only phy on this platform.
> > If that's the case, what is this reset shared with ?
>
> Amlogic axg soc includes two pcie controllers and they share the same pcie phy.
> Because of two pcie controllers, meson_pcie_phy_probe() will be called two times.
> So, the phy reset must be shared.
You are abusing the API then.
The phy should have exclusive control of its *own* reset line, not other device
should claim this reset.
I should then manage the fact that it may have more than one consumer.
prev parent reply other threads:[~2018-08-30 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 7:33 [PATCH v2 0/2] add the Amlogic Meson PCIe phy driver Hanjie Lin
2018-08-24 7:33 ` [PATCH v2 1/2] dt-bindings: phy: add DT bindings for Amlogic Meson PCIe Phy controller Hanjie Lin
2018-08-29 0:37 ` Rob Herring
2018-08-30 7:50 ` Hanjie Lin
2018-08-24 7:33 ` [PATCH v2 2/2] PCI: meson: add the Amlogic Meson PCIe phy driver Hanjie Lin
2018-08-29 15:57 ` Jerome Brunet
2018-08-30 8:02 ` Hanjie Lin
2018-08-30 8:56 ` Jerome Brunet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2558005d0cad11feb9d6775b2ed237351098fa06.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=carlo@caione.org \
--cc=hanjie.lin@amlogic.com \
--cc=jian.hu@amlogic.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=qiufang.dai@amlogic.com \
--cc=robh@kernel.org \
--cc=yixun.lan@amlogic.com \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).