From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Leonard Crestez To: "lorenzo.pieralisi@arm.com" Subject: Re: [RESEND] PCI: imx: Initial imx7d pm support Date: Mon, 3 Sep 2018 13:52:13 +0000 Message-ID: <29a8f58b4efe3e3671eec1ee78b566d69034db61.camel@nxp.com> References: <20180828100758.GA27217@e107981-ln.cambridge.arm.com> <20180828145511.GA32352@e107981-ln.cambridge.arm.com> In-Reply-To: <20180828145511.GA32352@e107981-ln.cambridge.arm.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "A.s. Dong" , "Joao.Pinto@synopsys.com" , Richard Zhu , "kernel@pengutronix.de" , Anson Huang , "andrew.smirnov@gmail.com" , "jingoohan1@gmail.com" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , dl-linux-imx , "p.zabel@pengutronix.de" , "linux-pci@vger.kernel.org" , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" , "l.stach@pengutronix.de" Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Tue, 2018-08-28 at 15:55 +0100, Lorenzo Pieralisi wrote: > On Tue, Aug 28, 2018 at 01:00:02PM +0000, Leonard Crestez wrote: > > On Tue, 2018-08-28 at 11:07 +0100, Lorenzo Pieralisi wrote: > > > On Mon, Aug 27, 2018 at 02:28:37PM +0300, Leonard Crestez wrote: > > > > On imx7d the pcie-phy power domain is turned off in suspend and this can > > > > make the system hang after resume when attempting any read from PCI. > > > > > > > > Fix this by adding minimal suspend/resume code from the nxp internal > > > > tree. This will prepare for powering down on suspend and reset the block > > > > on resume. > > > > > > > > Code is only for imx7d but a very similar sequence can be used for > > > > other socs. > > > > > > > > The original author is mostly Richard Zhu , this > > > > patch adjusts the code to the upstream imx7d implemention using reset > > > > controls and power domains. > > > > > > I will add a Suggested-by: replacing this paragraph, it is always better > > > to add proper tags rather than credit hidden in commit logs messages. > > > > Isn't "Originally-by:" a better tag for this? > > We can add that, yes or add Richard as patch author, as you prefer to > give him credit. I think "Originally-by:" is a better fit because there is no clear correspondence with patches from the vendor tree. -- Regards, Leonard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel