* [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static
@ 2020-04-15 8:49 Jason Yan
2020-04-15 10:07 ` Andy Shevchenko
2020-05-05 10:47 ` Lorenzo Pieralisi
0 siblings, 2 replies; 4+ messages in thread
From: Jason Yan @ 2020-04-15 8:49 UTC (permalink / raw)
To: lorenzo.pieralisi, amurray, bhelgaas, p.zabel, gustavo.pimentel,
yanaijie, andriy.shevchenko, eswara.kota, linux-pci,
linux-kernel
Cc: Hulk Robot
Fix the following sparse warning:
drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol
'intel_pcie_cpu_addr' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/pci/controller/dwc/pcie-intel-gw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c
index fc2a12212dec..2d8dbb318087 100644
--- a/drivers/pci/controller/dwc/pcie-intel-gw.c
+++ b/drivers/pci/controller/dwc/pcie-intel-gw.c
@@ -453,7 +453,7 @@ static int intel_pcie_msi_init(struct pcie_port *pp)
return 0;
}
-u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
+static u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
{
return cpu_addr + BUS_IATU_OFFSET;
}
--
2.21.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static
2020-04-15 8:49 [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static Jason Yan
@ 2020-04-15 10:07 ` Andy Shevchenko
2020-04-15 13:09 ` Jason Yan
2020-05-05 10:47 ` Lorenzo Pieralisi
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2020-04-15 10:07 UTC (permalink / raw)
To: Jason Yan
Cc: lorenzo.pieralisi, amurray, bhelgaas, p.zabel, gustavo.pimentel,
eswara.kota, linux-pci, linux-kernel, Hulk Robot
On Wed, Apr 15, 2020 at 04:49:53PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
>
> drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol
> 'intel_pcie_cpu_addr' was not declared. Should it be static?
Please, learn how to use get_maintainers.pl to avoid spamming people.
Hint:
scripts/get_maintainer.pl --git --git-min-percent=67
would give advantage, though it still requires a common sense to be applied.
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-intel-gw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c
> index fc2a12212dec..2d8dbb318087 100644
> --- a/drivers/pci/controller/dwc/pcie-intel-gw.c
> +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c
> @@ -453,7 +453,7 @@ static int intel_pcie_msi_init(struct pcie_port *pp)
> return 0;
> }
>
> -u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
> +static u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
> {
> return cpu_addr + BUS_IATU_OFFSET;
> }
> --
> 2.21.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static
2020-04-15 10:07 ` Andy Shevchenko
@ 2020-04-15 13:09 ` Jason Yan
0 siblings, 0 replies; 4+ messages in thread
From: Jason Yan @ 2020-04-15 13:09 UTC (permalink / raw)
To: Andy Shevchenko
Cc: lorenzo.pieralisi, amurray, bhelgaas, p.zabel, gustavo.pimentel,
eswara.kota, linux-pci, linux-kernel, Hulk Robot
在 2020/4/15 18:07, Andy Shevchenko 写道:
> On Wed, Apr 15, 2020 at 04:49:53PM +0800, Jason Yan wrote:
>> Fix the following sparse warning:
>>
>> drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol
>> 'intel_pcie_cpu_addr' was not declared. Should it be static?
>
> Please, learn how to use get_maintainers.pl to avoid spamming people.
> Hint:
> scripts/get_maintainer.pl --git --git-min-percent=67
> would give advantage, though it still requires a common sense to be applied.
>
I'm so sorry to bother you with this. I will be more careful when I'm
sending patches.
Thanks,
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static
2020-04-15 8:49 [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static Jason Yan
2020-04-15 10:07 ` Andy Shevchenko
@ 2020-05-05 10:47 ` Lorenzo Pieralisi
1 sibling, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2020-05-05 10:47 UTC (permalink / raw)
To: Jason Yan
Cc: amurray, bhelgaas, p.zabel, gustavo.pimentel, andriy.shevchenko,
eswara.kota, linux-pci, linux-kernel, Hulk Robot
On Wed, Apr 15, 2020 at 04:49:53PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
>
> drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol
> 'intel_pcie_cpu_addr' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-intel-gw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/dwc, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c
> index fc2a12212dec..2d8dbb318087 100644
> --- a/drivers/pci/controller/dwc/pcie-intel-gw.c
> +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c
> @@ -453,7 +453,7 @@ static int intel_pcie_msi_init(struct pcie_port *pp)
> return 0;
> }
>
> -u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
> +static u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
> {
> return cpu_addr + BUS_IATU_OFFSET;
> }
> --
> 2.21.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-05 10:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 8:49 [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static Jason Yan
2020-04-15 10:07 ` Andy Shevchenko
2020-04-15 13:09 ` Jason Yan
2020-05-05 10:47 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).