linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Paul Burton <paulburton@kernel.org>,
	linux-mips@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Thomas Bogendoerfer <tbogendoerfer@suse.de>
Subject: Re: [PATCH] PCI: export pci_find_host_bridge() to fix MFD build error
Date: Tue, 20 Oct 2020 09:04:31 -0700	[thread overview]
Message-ID: <2cdd59ba-4832-c25a-50e5-62766070675d@infradead.org> (raw)
In-Reply-To: <84b55881-21ba-aa5b-7b56-7d8e411771f9@infradead.org>

On 10/20/20 8:51 AM, Randy Dunlap wrote:
> On 10/20/20 7:06 AM, Randy Dunlap wrote:
>> On 10/20/20 1:02 AM, Christoph Hellwig wrote:
>>> On Sun, Oct 18, 2020 at 11:14:53PM -0700, Randy Dunlap wrote:
>>>> Fix a build error in drivers/mfd/ioc.o by exporting
>>>> pci_find_host_bridge().
>>>>
>>>> ERROR: modpost: "pci_find_host_bridge" [drivers/mfd/ioc3.ko] undefined!
>>>
>>> I think the mfd code should be fixed to not depend on such an internal
>>> symbol instead.
>>>
>>
>> Thanks for commenting. and I am not surprised.
>>
>> Adding Cc: for Thomas and Lee.
> 
> BTW, if someone wants to use the MFD ioc3 driver now,
> without any source code patches, they can just build it in
> (SGI_MFD_IOC3=y) instead of building it as a loadable module.
> 
> It builds successfully and can use pci_find_host_bridge().
> pci_find_host_bridge() just isn't exported for loadable modules.
> 
> So this could be useful (PCI=y):
> 
> config SGI_MFD_IOC3
> 	tristate "SGI IOC3 core driver"
> 	depends on PCI=y && MIPS && 64BIT
> 	select MFD_CORE

Wow. That's not correct at all. Need more coffee.

Just set SGI_MFD_IOC3=y and it will be fine.

-- 
~Randy


  reply	other threads:[~2020-10-20 16:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19  6:14 Randy Dunlap
2020-10-20  8:02 ` Christoph Hellwig
2020-10-20 14:06   ` Randy Dunlap
2020-10-20 15:51     ` Randy Dunlap
2020-10-20 16:04       ` Randy Dunlap [this message]
2020-10-21 10:08   ` Thomas Bogendoerfer
2020-10-23  6:47     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cdd59ba-4832-c25a-50e5-62766070675d@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=bhelgaas@google.com \
    --cc=hch@infradead.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=paulburton@kernel.org \
    --cc=tbogendoerfer@suse.de \
    --cc=tsbogend@alpha.franken.de \
    --subject='Re: [PATCH] PCI: export pci_find_host_bridge() to fix MFD build error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).