linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Stanimir Varbanov" <svarbanov@mm-sol.com>,
	"Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] dt-bindings: PCI: qcom: Add SC8280XP to binding
Date: Fri, 1 Jul 2022 10:37:55 +0200	[thread overview]
Message-ID: <2f3cc247-d56d-2338-d8e8-3ab32bf7f7ad@linaro.org> (raw)
In-Reply-To: <20220629141000.18111-5-johan+linaro@kernel.org>

On 29/06/2022 16:09, Johan Hovold wrote:
> Add the SC8280XP platform to the binding.
> 
> SC8280XP use four host interrupts for MSI routing so remove the obsolete
> comment referring to newer chipsets supporting one or eight interrupts
> (e.g. for backwards compatibility).
> 

(...)

>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,pcie-sc8280xp
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 4
> +          maxItems: 4
> +        interrupt-names:
> +          items:
> +            - const: msi0
> +            - const: msi1
> +            - const: msi2
> +            - const: msi3

What the previous #3 commit is missing is:
"This allows for adding further platforms with for example four MSI
interrupts, without resorting to nested conditionals."

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

  reply	other threads:[~2022-07-01  8:38 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 14:09 [PATCH 00/10] PCI: qcom: Add support for SC8280XP and SA8540P Johan Hovold
2022-06-29 14:09 ` [PATCH 01/10] dt-bindings: PCI: qcom: Fix reset conditional Johan Hovold
2022-06-29 14:37   ` Dmitry Baryshkov
2022-07-01  8:29   ` Krzysztof Kozlowski
2022-07-09  7:49   ` Manivannan Sadhasivam
2022-07-13 16:18   ` Bjorn Helgaas
2022-06-29 14:09 ` [PATCH 02/10] dt-bindings: PCI: qcom: Fix msi-interrupt conditional Johan Hovold
2022-06-29 14:37   ` Dmitry Baryshkov
2022-07-01  8:29   ` Krzysztof Kozlowski
2022-07-07 13:34   ` Dmitry Baryshkov
2022-07-07 13:41     ` Dmitry Baryshkov
2022-07-07 13:53       ` Johan Hovold
2022-07-09  7:50   ` Manivannan Sadhasivam
2022-06-29 14:09 ` [PATCH 03/10] dt-bindings: PCI: qcom: Enumerate platforms with single msi interrupt Johan Hovold
2022-07-01  8:33   ` Krzysztof Kozlowski
2022-07-01  8:38     ` Johan Hovold
2022-07-01 18:38       ` Rob Herring
2022-07-04 14:21         ` Johan Hovold
2022-07-01  8:35   ` Krzysztof Kozlowski
2022-07-09  7:58   ` Manivannan Sadhasivam
2022-06-29 14:09 ` [PATCH 04/10] dt-bindings: PCI: qcom: Add SC8280XP to binding Johan Hovold
2022-07-01  8:37   ` Krzysztof Kozlowski [this message]
2022-07-01  8:41     ` Johan Hovold
2022-07-09  8:00   ` Manivannan Sadhasivam
2022-07-11  9:36     ` Johan Hovold
2022-06-29 14:09 ` [PATCH 05/10] dt-bindings: PCI: qcom: Add SA8540P " Johan Hovold
2022-07-01  8:38   ` Krzysztof Kozlowski
2022-07-01  8:42     ` Johan Hovold
2022-07-09  8:02   ` Manivannan Sadhasivam
2022-07-11  9:38     ` Johan Hovold
2022-06-29 14:09 ` [PATCH 06/10] PCI: qcom: Add support for SC8280XP Johan Hovold
2022-07-01 18:29   ` Rob Herring
2022-07-04 14:10     ` Johan Hovold
2022-07-09  8:18   ` Manivannan Sadhasivam
2022-06-29 14:09 ` [PATCH 07/10] PCI: qcom: Add support for SA8540P Johan Hovold
2022-07-01 18:29   ` Rob Herring
2022-07-09  8:19   ` Manivannan Sadhasivam
2022-06-29 14:09 ` [PATCH 08/10] PCI: qcom: Make all optional clocks optional Johan Hovold
2022-07-01 18:34   ` Rob Herring
2022-07-09  8:23   ` Manivannan Sadhasivam
2022-06-29 14:09 ` [PATCH 09/10] PCI: qcom: Clean up IP configurations Johan Hovold
2022-07-01 18:35   ` Rob Herring
2022-07-09  8:25   ` Manivannan Sadhasivam
2022-06-29 14:10 ` [PATCH 10/10] PCI: qcom: Sort device-id table Johan Hovold
2022-07-01  8:40   ` Krzysztof Kozlowski
2022-07-01  8:46     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f3cc247-d56d-2338-d8e8-3ab32bf7f7ad@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=johan+linaro@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=svarbanov@mm-sol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).