linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yicong Yang <yangyicong@hisilicon.com>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: <helgaas@kernel.org>, <linux-pci@vger.kernel.org>,
	<prime.zeng@huawei.com>, <linuxarm@openeuler.org>
Subject: Re: [Linuxarm] Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag
Date: Wed, 10 Feb 2021 17:29:18 +0800	[thread overview]
Message-ID: <313c711f-ab0f-b0ec-cfee-8bb65bdfee03@hisilicon.com> (raw)
In-Reply-To: <YCKN0+wsH/W2lZ+Q@rocinante>

On 2021/2/9 21:27, Krzysztof Wilczyński wrote:
> Hi Yicong,
> 
> [...]
>>> By the way, did you have some issues with things like pr_debug() and other
>>> things printing debug information not working correctly before?
>>
>> i cannot remember that i have met any, so maybe they work properly. :)
> [...]
> 
> That's good to know!  I suspect, some of the pr_debug() invocations
> might not be working correctly at the moment, so this is a nice
> improvement.
> 
> Having said that, if you have some time, can you update the patch
> against the PCI tree with the commit message from this thread?
> 
>   https://lore.kernel.org/lkml/1612868899-9185-1-git-send-email-yangyicong@hisilicon.com/
> 
> The commit messages there for the individual patches are much nicer, so
> if you don't mind, it would be nice have the same one in the PCI tree.
> 
> My review still applies.
> 
> Thank you again for sending the patch over!

Bjorn has applied this with nicer commit. Thanks for reviewing this. :)

Regards,
Yicong

> 
> Krzysztof
> _______________________________________________
> Linuxarm mailing list -- linuxarm@openeuler.org
> To unsubscribe send an email to linuxarm-leave@openeuler.org
> 


  reply	other threads:[~2021-02-10  9:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 11:30 Yicong Yang
2021-02-04 12:28 ` Krzysztof Wilczyński
2021-02-04 13:19   ` Yicong Yang
2021-02-09 13:27     ` Krzysztof Wilczyński
2021-02-10  9:29       ` Yicong Yang [this message]
2021-02-04 16:10 ` Bjorn Helgaas
2021-02-05  1:32   ` Yicong Yang
2021-02-09 21:25 ` Bjorn Helgaas
2021-02-09 23:43   ` Krzysztof Wilczyński
2021-02-10  9:33   ` Yicong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=313c711f-ab0f-b0ec-cfee-8bb65bdfee03@hisilicon.com \
    --to=yangyicong@hisilicon.com \
    --cc=helgaas@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=prime.zeng@huawei.com \
    --subject='Re: [Linuxarm] Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).