From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9FABC433FE for ; Wed, 23 Feb 2022 19:19:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244335AbiBWTTj (ORCPT ); Wed, 23 Feb 2022 14:19:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244321AbiBWTTh (ORCPT ); Wed, 23 Feb 2022 14:19:37 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC3DF46145 for ; Wed, 23 Feb 2022 11:19:09 -0800 (PST) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 7C1EF3FC9E for ; Wed, 23 Feb 2022 19:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645643948; bh=OsmDWPse4xUb7lllvZErJnLq536hKmJqOuDcEnXswgI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pyi3ZOsftRe4LCarU+sJ6V9zOGZ1f2csY6Ye3gN++YLm0D91rrcv3GRDbrIdPrAnU KossIc9JSbE3oNYq6ku9O22UXEO2o2js/uhDaaSAFBroR6N+CrTI/y/flxACvVQSJA p5ssWrFAJRdX+kf44kuNx52Pw0M3CpZukl/3jNw0NeLCSrwEMP9OhCyukUHmiR4y95 Fan33RM5XlgKofNgCWBgba5PBrP14Gp8EyXk4U6qmHYOHNBhgBqMyioyXfH6br3b3s abHNwAngTxkyadwJGAbvWHg+wWYKiKnRjwgBY4xrSKK2WM2hiAL+jCgBxPBMMjwT4X 77C5OzygbQjmg== Received: by mail-ej1-f72.google.com with SMTP id v2-20020a170906292200b006a94a27f903so7520968ejd.8 for ; Wed, 23 Feb 2022 11:19:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OsmDWPse4xUb7lllvZErJnLq536hKmJqOuDcEnXswgI=; b=L2Bg30uT910MiWKfQX+Jag+xukuXxCetb7EKeEGLdBu+V1/i7GCSXeYXy1sFHgEEBM b32slcoXB7eDj69088jemBg97MmCspqFkH8Z4hjqIt4M3XEJhO6FUYUFFgAZQUrftjcR 4uikNBJXjRZ1qRJWiur8mX+bcbu1oL/Zp+hg4ZGfJugS95dQ8qmse73GFauFXgNACZrF Itv/XpkmZmDKqQbaMRK9xuqg6/eZi8kupCyuBLaaCnmm+1/xPRtRL5FBwsP3D8EImhar mr9lmzrwuANrFKnXTdBKb8xfbHscBVOUrOPptV2e3+aokjxrjheLHpFS25qNSK1LVg/7 KvPg== X-Gm-Message-State: AOAM53215lCZDHU/POzah98wysVq98aaboLHOjUVev1dbcGeWIqLQgFw 9aDj5T5zX7pgeciEjLZJDyHFulccDWrpDVJF4XkuFfrBof6PeYXqc/Pq1SUFLiD6LHILEAplT+d qj/LYrLWHavAGgZQB9ZZfjS13hN7dhdFq/cZevg== X-Received: by 2002:a17:906:6b8e:b0:6b9:1f27:73e with SMTP id l14-20020a1709066b8e00b006b91f27073emr863408ejr.361.1645643947951; Wed, 23 Feb 2022 11:19:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJ9QUyPanWfiXE6vKIo8o+c2pwl8ckmaYif3CteDvcltA9YiJZAZD09dYlCxpl8UKoIvZBag== X-Received: by 2002:a17:906:6b8e:b0:6b9:1f27:73e with SMTP id l14-20020a1709066b8e00b006b91f27073emr863390ejr.361.1645643947743; Wed, 23 Feb 2022 11:19:07 -0800 (PST) Received: from [192.168.0.127] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id x14sm302707edd.63.2022.02.23.11.19.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Feb 2022 11:19:07 -0800 (PST) Message-ID: <31c4f987-6480-278f-1d49-02bd611b521c@canonical.com> Date: Wed, 23 Feb 2022 20:19:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 09/11] clk: imx: scu: fix kfree() of static memory on setting driver_override Content-Language: en-US To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds Cc: Rasmus Villemoes , stable@vger.kernel.org References: <20220223191310.347669-1-krzysztof.kozlowski@canonical.com> <20220223191441.348109-3-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski In-Reply-To: <20220223191441.348109-3-krzysztof.kozlowski@canonical.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 23/02/2022 20:14, Krzysztof Kozlowski wrote: > The driver_override field from platform driver should not be initialized > from static memory (string literal) because the core later kfree() it, > for example when driver_override is set via sysfs. > > Use dedicated helper to set driver_override properly. > > Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support") > Cc: > Signed-off-by: Krzysztof Kozlowski > --- > drivers/clk/imx/clk-scu.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c > index 083da31dc3ea..15e1d670e51f 100644 > --- a/drivers/clk/imx/clk-scu.c > +++ b/drivers/clk/imx/clk-scu.c > @@ -683,7 +683,12 @@ struct clk_hw *imx_clk_scu_alloc_dev(const char *name, > return ERR_PTR(ret); > } > > - pdev->driver_override = "imx-scu-clk"; > + ret = driver_set_override(&pdev->dev, &pdev->driver_override, > + "imx-scu-clk"); > + if (ret) { > + platform_device_put(pdev); > + return ret; This is wrong - should be ERR_PTR. Best regards, Krzysztof