From: Heiner Kallweit <hkallweit1@gmail.com>
To: Frederick Lawler <fred@fredlawl.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Greg KH <gregkh@linuxfoundation.org>,
Rajat Jain <rajatja@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v3 0/4] PCI/ASPM: add sysfs attributes for controlling ASPM
Date: Fri, 23 Aug 2019 23:30:16 +0200 [thread overview]
Message-ID: <32e53ab5-148c-35df-2ac0-f770edc6ae5d@gmail.com> (raw)
In-Reply-To: <9e5ef666-1ef9-709a-cd7a-ca43eeb9e4a4@gmail.com>
On 23.08.2019 08:11, Heiner Kallweit wrote:
> Background of this extension is a problem with the r8169 network driver.
> Several combinations of board chipsets and network chip versions have
> problems if ASPM is enabled, therefore we have to disable ASPM per
> default. However especially on notebooks ASPM can provide significant
> power-saving, therefore we want to give users the option to enable
> ASPM. With the new sysfs attributes users can control which ASPM
> link-states are disabled.
>
> v2:
> - use a dedicated sysfs attribute per link state
> - allow separate control of ASPM and PCI PM L1 sub-states
>
> v3:
> - patch 3: statically allocate the attribute group
> - patch 3: replace snprintf with printf
> - add patch 4
>
> Heiner Kallweit (4):
> PCI/ASPM: add L1 sub-state support to pci_disable_link_state
> PCI/ASPM: allow to re-enable Clock PM
> PCI/ASPM: add sysfs attributes for controlling ASPM
> PCI/ASPM: remove Kconfig option PCIEASPM_DEBUG and related code
>
> Documentation/ABI/testing/sysfs-bus-pci | 13 +
> drivers/pci/pci-sysfs.c | 6 +-
> drivers/pci/pci.h | 12 +-
> drivers/pci/pcie/Kconfig | 7 -
> drivers/pci/pcie/aspm.c | 300 ++++++++++++++++++------
> include/linux/pci-aspm.h | 10 +-
> 6 files changed, 254 insertions(+), 94 deletions(-)
>
Found a functional error during more testing. Will submit a v4 once fixed.
Please disregard this series.
prev parent reply other threads:[~2019-08-23 21:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 6:11 [PATCH v3 0/4] PCI/ASPM: add sysfs attributes for controlling ASPM Heiner Kallweit
2019-08-23 6:12 ` [PATCH v3 1/4] PCI/ASPM: add L1 sub-state support to pci_disable_link_state Heiner Kallweit
2019-08-23 6:12 ` [PATCH v3 2/4] PCI/ASPM: allow to re-enable Clock PM Heiner Kallweit
2019-08-23 6:15 ` [PATCH v3 3/4] PCI/ASPM: add sysfs attributes for controlling ASPM Heiner Kallweit
2019-08-23 6:15 ` [PATCH v3 4/4] PCI/ASPM: remove Kconfig option PCIEASPM_DEBUG and related code Heiner Kallweit
2019-08-23 21:30 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32e53ab5-148c-35df-2ac0-f770edc6ae5d@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=fred@fredlawl.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-pci@vger.kernel.org \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).