From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Lukas Wunner <lukas@wunner.de>,
Heiner Kallweit <hkallweit1@gmail.com>,
Sinan Kaya <okaya@codeaurora.org>,
Keith Busch <keith.busch@intel.com>,
Oza Pawandeep <poza@codeaurora.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: pciehp: Disable Data Link Layer State Changed event on suspend
Date: Mon, 07 Jan 2019 23:26:42 +0100 [thread overview]
Message-ID: <3338376.uz3xVmb2pH@aspire.rjw.lan> (raw)
In-Reply-To: <20190107143959.75267-3-mika.westerberg@linux.intel.com>
On Monday, January 7, 2019 3:39:59 PM CET Mika Westerberg wrote:
> Commit 0e157e528604 ("PCI/PME: Implement runtime PM callbacks") tried to
> solve an issue where the hierarchy immediately wakes up when it is
> transitioned into D3cold. It turns out preventing PME propagation in
> some PCIe hierarchies not supporting D3cold.
>
> I looked more closely what might cause the immediate wakeup. It happens
> when the ACPI power resource of the root port is turned off. The AML
> code associated with the _OFF() method of the ACPI power resource
> executes PCIe L2/3 ready transition and waits it to complete. Right
> after the L2/3 ready transition is started the root port receives PME
> from the downstream port.
>
> The simplest hierarchy where this happens looks like this:
>
> 00:1d.0 PCIe Root port
> ^
> |
> v
> 05:00.0 PCIe switch #1 upstream port
> 06:01.0 PCIe switch #1 downstream hotplug port
> ^
> |
> v
> 08:00.0 Pcie switch #2 upstream port
>
> It seems that the PCIe link between the two switches, before
> PME_Turn_Off/PME_TO_Ack is complete for the whole hierarchy, goes
> inactive and triggers PME towards the root port bringing it back to D0.
> Disabling Data Link Layer State Changed event (DLLSCE) prevents the
> issue and still allows the downstream hotplug port to notice when a
> device is plugged/unplugged.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=202103
> Fixes: 0e157e528604 ("PCI/PME: Implement runtime PM callbacks")
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/pci/hotplug/pciehp_hpc.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
> index cd9eae650aa5..6fdaa8d48ebe 100644
> --- a/drivers/pci/hotplug/pciehp_hpc.c
> +++ b/drivers/pci/hotplug/pciehp_hpc.c
> @@ -736,12 +736,18 @@ void pcie_clear_hotplug_events(struct controller *ctrl)
>
> void pcie_enable_interrupt(struct controller *ctrl)
> {
> - pcie_write_cmd(ctrl, PCI_EXP_SLTCTL_HPIE, PCI_EXP_SLTCTL_HPIE);
> + u16 mask;
> +
> + mask = PCI_EXP_SLTCTL_HPIE | PCI_EXP_SLTCTL_DLLSCE;
> + pcie_write_cmd(ctrl, mask, mask);
> }
>
> void pcie_disable_interrupt(struct controller *ctrl)
> {
> - pcie_write_cmd(ctrl, 0, PCI_EXP_SLTCTL_HPIE);
> + u16 mask;
> +
> + mask = PCI_EXP_SLTCTL_HPIE | PCI_EXP_SLTCTL_DLLSCE;
> + pcie_write_cmd(ctrl, 0, mask);
> }
>
> /*
>
next prev parent reply other threads:[~2019-01-07 22:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 14:39 [PATCH 0/2] PCI: Fix runtime PME generation from D3hot Mika Westerberg
2019-01-07 14:39 ` [PATCH 1/2] Revert "PCI/PME: Implement runtime PM callbacks" Mika Westerberg
2019-01-07 22:26 ` Rafael J. Wysocki
2019-01-07 14:39 ` [PATCH 2/2] PCI: pciehp: Disable Data Link Layer State Changed event on suspend Mika Westerberg
2019-01-07 22:26 ` Rafael J. Wysocki [this message]
2019-01-15 0:24 ` Bjorn Helgaas
2019-01-21 10:22 ` Mika Westerberg
2019-01-07 18:54 ` [PATCH 0/2] PCI: Fix runtime PME generation from D3hot Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3338376.uz3xVmb2pH@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=bhelgaas@google.com \
--cc=hkallweit1@gmail.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=okaya@codeaurora.org \
--cc=poza@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).